[
https://issues.apache.org/jira/browse/YARN-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16014617#comment-16014617
]
Wangda Tan commented on YARN-5949:
--
Latest patch LGTM, will commit tomorrow if no opposite opinions.
[
https://issues.apache.org/jira/browse/YARN-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011610#comment-16011610
]
Hadoop QA commented on YARN-5949:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16011463#comment-16011463
]
Jonathan Hung commented on YARN-5949:
-
Thanks [~leftnoteasy]! Seems reasonable. Attached 005 to address
[
https://issues.apache.org/jira/browse/YARN-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16009593#comment-16009593
]
Wangda Tan commented on YARN-5949:
--
Thanks [~jhung] for updating the patch,
Few comments:
1) Do you think
[
https://issues.apache.org/jira/browse/YARN-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16005586#comment-16005586
]
Hadoop QA commented on YARN-5949:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16005358#comment-16005358
]
Jonathan Hung commented on YARN-5949:
-
004 fixes
[
https://issues.apache.org/jira/browse/YARN-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003837#comment-16003837
]
Hadoop QA commented on YARN-5949:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003668#comment-16003668
]
Jonathan Hung commented on YARN-5949:
-
Attached 003 patch which pushes the client request -> key value
[
https://issues.apache.org/jira/browse/YARN-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16003557#comment-16003557
]
Jonathan Hung commented on YARN-5949:
-
Discussed this offline, will upload a patch addressing scheduler
[
https://issues.apache.org/jira/browse/YARN-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15994089#comment-15994089
]
Wangda Tan commented on YARN-5949:
--
Thanks [~jhung],
bq. This makes sense, should just be able to either
[
https://issues.apache.org/jira/browse/YARN-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15992011#comment-15992011
]
Hadoop QA commented on YARN-5949:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15991882#comment-15991882
]
Jonathan Hung commented on YARN-5949:
-
Attached 002 patch which uses MutableConfScheduler instead of
[
https://issues.apache.org/jira/browse/YARN-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15987979#comment-15987979
]
Jonathan Hung commented on YARN-5949:
-
Thanks for the comments [~leftnoteasy], had a few
[
https://issues.apache.org/jira/browse/YARN-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981951#comment-15981951
]
Wangda Tan commented on YARN-5949:
--
Thanks [~jhung] for your patch, overall looks good to me as well, few
[
https://issues.apache.org/jira/browse/YARN-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981639#comment-15981639
]
Jonathan Hung commented on YARN-5949:
-
Thanks [~xgong] for the review.
Right now the default policy is
[
https://issues.apache.org/jira/browse/YARN-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15978972#comment-15978972
]
Xuan Gong commented on YARN-5949:
-
Thanks for the patch. [~jhung]
Overall looks good.
In the same patch,
[
https://issues.apache.org/jira/browse/YARN-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977622#comment-15977622
]
Jonathan Hung commented on YARN-5949:
-
Rebase branch and resubmit patch.
> Add pluggable configuration
[
https://issues.apache.org/jira/browse/YARN-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15977596#comment-15977596
]
Hadoop QA commented on YARN-5949:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960085#comment-15960085
]
Jonathan Hung commented on YARN-5949:
-
Added 001 patch which creates a policy interface, a default
[
https://issues.apache.org/jira/browse/YARN-5949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15960083#comment-15960083
]
Jonathan Hung commented on YARN-5949:
-
Added 001 patch which creates a policy interface, a default
20 matches
Mail list logo