[jira] [Commented] (YARN-6288) Refactor AppLogAggregatorImpl#uploadLogsForContainers

2017-03-14 Thread Akira Ajisaka (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925554#comment-15925554 ] Akira Ajisaka commented on YARN-6288: - Thanks [~haibochen] for the review. Hi [~dan...@

[jira] [Commented] (YARN-6288) Refactor AppLogAggregatorImpl#uploadLogsForContainers

2017-03-14 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924506#comment-15924506 ] Haibo Chen commented on YARN-6288: -- The latest patch LGTM. +1 non-binding. > Refactor App

[jira] [Commented] (YARN-6288) Refactor AppLogAggregatorImpl#uploadLogsForContainers

2017-03-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15923475#comment-15923475 ] Hadoop QA commented on YARN-6288: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-6288) Refactor AppLogAggregatorImpl#uploadLogsForContainers

2017-03-13 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15908405#comment-15908405 ] Haibo Chen commented on YARN-6288: -- Thanks [~ajisakaa] for updating the patch! One comment

[jira] [Commented] (YARN-6288) Refactor AppLogAggregatorImpl#uploadLogsForContainers

2017-03-13 Thread Akira Ajisaka (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15907033#comment-15907033 ] Akira Ajisaka commented on YARN-6288: - Probably the test failure is not related to the

[jira] [Commented] (YARN-6288) Refactor AppLogAggregatorImpl#uploadLogsForContainers

2017-03-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15907007#comment-15907007 ] Hadoop QA commented on YARN-6288: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (YARN-6288) Refactor AppLogAggregatorImpl#uploadLogsForContainers

2017-03-09 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904039#comment-15904039 ] Haibo Chen commented on YARN-6288: -- Looks like in LogWriter() we create a file and write t

[jira] [Commented] (YARN-6288) Refactor AppLogAggregatorImpl#uploadLogsForContainers

2017-03-09 Thread Akira Ajisaka (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15902868#comment-15902868 ] Akira Ajisaka commented on YARN-6288: - Thanks [~haibochen] for the comment. I tried to

[jira] [Commented] (YARN-6288) Refactor AppLogAggregatorImpl#uploadLogsForContainers

2017-03-08 Thread Haibo Chen (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15902184#comment-15902184 ] Haibo Chen commented on YARN-6288: -- [~ajisakaa] Have you considered making LogWriter closa

[jira] [Commented] (YARN-6288) Refactor AppLogAggregatorImpl#uploadLogsForContainers

2017-03-05 Thread Akira Ajisaka (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15896774#comment-15896774 ] Akira Ajisaka commented on YARN-6288: - If an exception occurs when the writer is not re