[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427934#comment-16427934
]
Rohith Sharma K S commented on YARN-6936:
-
thanks [~haibochen] [~vrushalic] for the discussion and
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427436#comment-16427436
]
Haibo Chen commented on YARN-6936:
--
Done.
> [Atsv2] Retrospect storing entities into sub application
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427348#comment-16427348
]
Rohith Sharma K S commented on YARN-6936:
-
It should good to go in for
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427324#comment-16427324
]
Hudson commented on YARN-6936:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13929 (See
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427294#comment-16427294
]
Haibo Chen commented on YARN-6936:
--
I have committed the patch to trunk. [~rohithsharma] Any other
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427290#comment-16427290
]
Haibo Chen commented on YARN-6936:
--
There seems to be some problem with patch command not parsing the
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16427134#comment-16427134
]
Haibo Chen commented on YARN-6936:
--
I notice one issue with the latest patch. It adds the SubAppEntity in
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426539#comment-16426539
]
genericqa commented on YARN-6936:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426482#comment-16426482
]
Rohith Sharma K S commented on YARN-6936:
-
updated the patch fixing review comments.
> [Atsv2]
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426097#comment-16426097
]
Haibo Chen commented on YARN-6936:
--
The latest patch looks good to me, with two minor comments.
1) "with
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425077#comment-16425077
]
Rohith Sharma K S commented on YARN-6936:
-
As offline discussion with Vrushali and Haibo, primary
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16425071#comment-16425071
]
Vrushali C commented on YARN-6936:
--
Haibo, Rohith and I had a discussion on this over hangouts. I think we
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424958#comment-16424958
]
Vrushali C commented on YARN-6936:
--
That's a great table Haibo. (Not sure why the flow related tables are
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424562#comment-16424562
]
Haibo Chen commented on YARN-6936:
--
I have been thinking about this issue along with YARN-3401. Here is
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424389#comment-16424389
]
Haibo Chen commented on YARN-6936:
--
I can do 10pm.
> [Atsv2] Retrospect storing entities into sub
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424350#comment-16424350
]
Vrushali C commented on YARN-6936:
--
Do you both think we can have a quick call on tuesday night (pacific
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16424343#comment-16424343
]
Vrushali C commented on YARN-6936:
--
Thanks [~haibochen] for checking that entities are posted in one call.
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420357#comment-16420357
]
genericqa commented on YARN-6936:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420239#comment-16420239
]
Rohith Sharma K S commented on YARN-6936:
-
bq. Hence, I think we don't need to create another
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419666#comment-16419666
]
Haibo Chen commented on YARN-6936:
--
I checked the entity publisher in TimelineV2ClientImpl.java
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419609#comment-16419609
]
Vrushali C commented on YARN-6936:
--
Haibo, Rohith and I chatted about this in our weekly call. Summarizing
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417766#comment-16417766
]
Rohith Sharma K S commented on YARN-6936:
-
bq. Let's add the scope of the entities to each of the
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417430#comment-16417430
]
Haibo Chen commented on YARN-6936:
--
Thanks [~rohithsharma] for the new patch. I have a few
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417178#comment-16417178
]
Rohith Sharma K S commented on YARN-6936:
-
[~haibochen] [~vrushalic] Could you review the patch? I
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415689#comment-16415689
]
genericqa commented on YARN-6936:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415543#comment-16415543
]
Rohith Sharma K S commented on YARN-6936:
-
As we discussed on weekly call, I have updated the patch
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415325#comment-16415325
]
Rohith Sharma K S commented on YARN-6936:
-
I caught up with some other issues. I will work on this
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414225#comment-16414225
]
Haibo Chen commented on YARN-6936:
--
[~rohithsharma] Any update on this? I was thinking even though we have
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405289#comment-16405289
]
Vrushali C commented on YARN-6936:
--
Thanks for the patch [~rohithsharma] !
I tend to agree with
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16405268#comment-16405268
]
Haibo Chen commented on YARN-6936:
--
[~rohithsharma]. Can you elaborate on why we want to expose the
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16404385#comment-16404385
]
Rohith Sharma K S commented on YARN-6936:
-
[~vrushalic] Would you take a look at this patch so that
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16398593#comment-16398593
]
genericqa commented on YARN-6936:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392026#comment-16392026
]
Vrushali C commented on YARN-6936:
--
Currently, ATSv2 stores information in an additional table (sub
33 matches
Mail list logo