[jira] [Commented] (YARN-7682) Expose canAssign method in the PlacementConstraintManager

2018-01-03 Thread Panagiotis Garefalakis (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309790#comment-16309790 ] Panagiotis Garefalakis commented on YARN-7682: -- A temporary maven dependency error made

[jira] [Commented] (YARN-7682) Expose canAssign method in the PlacementConstraintManager

2018-01-03 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309729#comment-16309729 ] genericqa commented on YARN-7682: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7682) Expose canAssign method in the PlacementConstraintManager

2018-01-03 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309551#comment-16309551 ] genericqa commented on YARN-7682: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7682) Expose canAssign method in the PlacementConstraintManager

2018-01-03 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309534#comment-16309534 ] genericqa commented on YARN-7682: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7682) Expose canAssign method in the PlacementConstraintManager

2018-01-02 Thread Konstantinos Karanasos (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309227#comment-16309227 ] Konstantinos Karanasos commented on YARN-7682: -- bq. but did not get why we need to assert that

[jira] [Commented] (YARN-7682) Expose canAssign method in the PlacementConstraintManager

2018-01-02 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309217#comment-16309217 ] Arun Suresh commented on YARN-7682: --- [~kkaranasos], I understand why it might be better to swap Long::min

[jira] [Commented] (YARN-7682) Expose canAssign method in the PlacementConstraintManager

2018-01-02 Thread Konstantinos Karanasos (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309205#comment-16309205 ] Konstantinos Karanasos commented on YARN-7682: -- Thanks for the patch, [~pgaref]. Two main

[jira] [Commented] (YARN-7682) Expose canAssign method in the PlacementConstraintManager

2018-01-02 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309060#comment-16309060 ] genericqa commented on YARN-7682: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7682) Expose canAssign method in the PlacementConstraintManager

2018-01-02 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308305#comment-16308305 ] Arun Suresh commented on YARN-7682: --- Thanks for the update [~pgaref] It is starting to look neat now :)

[jira] [Commented] (YARN-7682) Expose canAssign method in the PlacementConstraintManager

2018-01-02 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16308277#comment-16308277 ] genericqa commented on YARN-7682: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7682) Expose canAssign method in the PlacementConstraintManager

2017-12-29 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306649#comment-16306649 ] Arun Suresh commented on YARN-7682: --- bq. What about the following: given that the external API is there

[jira] [Commented] (YARN-7682) Expose canAssign method in the PlacementConstraintManager

2017-12-29 Thread Konstantinos Karanasos (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16306416#comment-16306416 ] Konstantinos Karanasos commented on YARN-7682: -- What about the following: given that the

[jira] [Commented] (YARN-7682) Expose canAssign method in the PlacementConstraintManager

2017-12-28 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305987#comment-16305987 ] Arun Suresh commented on YARN-7682: --- bq. The problem Panagiotis describes with affinity seems to happen

[jira] [Commented] (YARN-7682) Expose canAssign method in the PlacementConstraintManager

2017-12-28 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305698#comment-16305698 ] Arun Suresh commented on YARN-7682: --- bq. affinity with more than 2 in cmin is actually a cardinality

[jira] [Commented] (YARN-7682) Expose canAssign method in the PlacementConstraintManager

2017-12-28 Thread Konstantinos Karanasos (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305684#comment-16305684 ] Konstantinos Karanasos commented on YARN-7682: -- Hi guys, I am on the phone (traveling For the

[jira] [Commented] (YARN-7682) Expose canAssign method in the PlacementConstraintManager

2017-12-28 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305626#comment-16305626 ] Arun Suresh commented on YARN-7682: --- [~pgaref], thanks for the patch. bq. should we promote affinity on

[jira] [Commented] (YARN-7682) Expose canAssign method in the PlacementConstraintManager

2017-12-28 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16305625#comment-16305625 ] genericqa commented on YARN-7682: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7682) Expose canAssign method in the PlacementConstraintManager

2017-12-26 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304079#comment-16304079 ] Arun Suresh commented on YARN-7682: --- bq. Following up on the discussion: My only concern is that

[jira] [Commented] (YARN-7682) Expose canAssign method in the PlacementConstraintManager

2017-12-26 Thread Panagiotis Garefalakis (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304075#comment-16304075 ] Panagiotis Garefalakis commented on YARN-7682: -- bq. I think we need to pass the whole

[jira] [Commented] (YARN-7682) Expose canAssign method in the PlacementConstraintManager

2017-12-26 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304039#comment-16304039 ] Arun Suresh commented on YARN-7682: --- Also, I think we need to pass the whole SchedulerNode in, not just

[jira] [Commented] (YARN-7682) Expose canAssign method in the PlacementConstraintManager

2017-12-26 Thread Konstantinos Karanasos (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304038#comment-16304038 ] Konstantinos Karanasos commented on YARN-7682: -- bq. Cool. What do you think about putting

[jira] [Commented] (YARN-7682) Expose canAssign method in the PlacementConstraintManager

2017-12-26 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304037#comment-16304037 ] Arun Suresh commented on YARN-7682: --- Cool. What do you think about putting method in the

[jira] [Commented] (YARN-7682) Expose canAssign method in the PlacementConstraintManager

2017-12-26 Thread Konstantinos Karanasos (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304034#comment-16304034 ] Konstantinos Karanasos commented on YARN-7682: -- If we pass everything as a parameter, then to

[jira] [Commented] (YARN-7682) Expose canAssign method in the PlacementConstraintManager

2017-12-26 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304032#comment-16304032 ] Arun Suresh commented on YARN-7682: --- To be honest - I prefer passing it as a parameter. That way the API

[jira] [Commented] (YARN-7682) Expose canAssign method in the PlacementConstraintManager

2017-12-26 Thread Konstantinos Karanasos (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304028#comment-16304028 ] Konstantinos Karanasos commented on YARN-7682: -- bq. If we want to make the canAssign be part

[jira] [Commented] (YARN-7682) Expose canAssign method in the PlacementConstraintManager

2017-12-26 Thread Panagiotis Garefalakis (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304026#comment-16304026 ] Panagiotis Garefalakis commented on YARN-7682: -- Thanks for the comments [~asuresh] and

[jira] [Commented] (YARN-7682) Expose canAssign method in the PlacementConstraintManager

2017-12-26 Thread Konstantinos Karanasos (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304021#comment-16304021 ] Konstantinos Karanasos commented on YARN-7682: -- Thanks for the initial patch [~pgaref]. Some

[jira] [Commented] (YARN-7682) Expose canAssign method in the PlacementConstraintManager

2017-12-26 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303925#comment-16303925 ] genericqa commented on YARN-7682: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-7682) Expose canAssign method in the PlacementConstraintManager

2017-12-26 Thread Arun Suresh (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303920#comment-16303920 ] Arun Suresh commented on YARN-7682: --- Thanks for the patch [~pgaref].. bq. We also have the delayedOr