[
https://issues.apache.org/jira/browse/YARN-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16430120#comment-16430120
]
Rohith Sharma K S commented on YARN-8048:
-
I have created YARN-8126 to follow up these comments.
>
[
https://issues.apache.org/jira/browse/YARN-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429361#comment-16429361
]
Rohith Sharma K S commented on YARN-8048:
-
Thanks [~gsaha] for the detailed review. I will create
[
https://issues.apache.org/jira/browse/YARN-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429280#comment-16429280
]
Gour Saha commented on YARN-8048:
-
[~rohithsharma] thank you for the patch. Sorry for the late review. This
[
https://issues.apache.org/jira/browse/YARN-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16429243#comment-16429243
]
Hudson commented on YARN-8048:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13937 (See
[
https://issues.apache.org/jira/browse/YARN-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16426462#comment-16426462
]
Wangda Tan commented on YARN-8048:
--
Thanks [~rohithsharma] for updating the patch.
+1 to the latest patch.
[
https://issues.apache.org/jira/browse/YARN-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16420155#comment-16420155
]
Rohith Sharma K S commented on YARN-8048:
-
[~leftnoteasy] would you take a look at last patch
[
https://issues.apache.org/jira/browse/YARN-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16419058#comment-16419058
]
genericqa commented on YARN-8048:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417980#comment-16417980
]
Gour Saha commented on YARN-8048:
-
I think it is okay to assume that if a service needs to be started as a
[
https://issues.apache.org/jira/browse/YARN-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417956#comment-16417956
]
Rohith Sharma K S commented on YARN-8048:
-
bq. For the 2nd level, it's better to only read files
[
https://issues.apache.org/jira/browse/YARN-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417877#comment-16417877
]
Wangda Tan commented on YARN-8048:
--
[~rohithsharma],
Thanks for your responses.
bq. For the 2nd level,
[
https://issues.apache.org/jira/browse/YARN-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16417304#comment-16417304
]
genericqa commented on YARN-8048:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416839#comment-16416839
]
Rohith Sharma K S commented on YARN-8048:
-
bq. Should we think of a better default location than
[
https://issues.apache.org/jira/browse/YARN-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416827#comment-16416827
]
Gour Saha commented on YARN-8048:
-
{quote} public static final String
[
https://issues.apache.org/jira/browse/YARN-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416804#comment-16416804
]
Rohith Sharma K S commented on YARN-8048:
-
bq. I think we should hardcode this one unless we have
[
https://issues.apache.org/jira/browse/YARN-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16416480#comment-16416480
]
Wangda Tan commented on YARN-8048:
--
Thanks [~rohithsharma],
1) createServiceManager: Why make this
[
https://issues.apache.org/jira/browse/YARN-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415658#comment-16415658
]
genericqa commented on YARN-8048:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415394#comment-16415394
]
Rohith Sharma K S commented on YARN-8048:
-
updated patch fixing review comments.
> Support
[
https://issues.apache.org/jira/browse/YARN-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16415366#comment-16415366
]
genericqa commented on YARN-8048:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414982#comment-16414982
]
Wangda Tan commented on YARN-8048:
--
Thanks [~rohithsharma],
For
{quote}Right, for non RM deployment
[
https://issues.apache.org/jira/browse/YARN-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414910#comment-16414910
]
Rohith Sharma K S commented on YARN-8048:
-
Thanks [~leftnoteasy] for review..
bq. Why
[
https://issues.apache.org/jira/browse/YARN-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16414254#comment-16414254
]
Wangda Tan commented on YARN-8048:
--
Thanks [~rohithsharma],
Still trying to understand the change:
1)
[
https://issues.apache.org/jira/browse/YARN-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413897#comment-16413897
]
genericqa commented on YARN-8048:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16413696#comment-16413696
]
Rohith Sharma K S commented on YARN-8048:
-
Updated patch fixing findbug and test failures.
>
[
https://issues.apache.org/jira/browse/YARN-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408642#comment-16408642
]
genericqa commented on YARN-8048:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16408335#comment-16408335
]
Rohith Sharma K S commented on YARN-8048:
-
Attached the patch with following modifications
#
25 matches
Mail list logo