[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787841#comment-16787841
]
Hudson commented on YARN-9265:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #16161 (See
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787827#comment-16787827
]
Sunil Govindan commented on YARN-9265:
--
+1. lets get this in.
> FPGA plugin fails to recognize Intel
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787429#comment-16787429
]
Hadoop QA commented on YARN-9265:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787300#comment-16787300
]
Peter Bacsko commented on YARN-9265:
Patch v9: addressed failing unit test, ASF license problem and
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786993#comment-16786993
]
Sunil Govindan commented on YARN-9265:
--
[~pbacsko] cud u pls check the ASF license pblm.
> FPGA
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786990#comment-16786990
]
Hadoop QA commented on YARN-9265:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785702#comment-16785702
]
Sunil Govindan commented on YARN-9265:
--
Thanks [~pbacsko]
Few comments:
# I would prefer to take
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785572#comment-16785572
]
Sunil Govindan commented on YARN-9265:
--
+ [~tangzhankun]
Could you please help to review this patch.
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773274#comment-16773274
]
Hadoop QA commented on YARN-9265:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16773193#comment-16773193
]
Peter Bacsko commented on YARN-9265:
I made a slight modification in {{FpgaDiscoverer.discover()}},
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16772075#comment-16772075
]
Hadoop QA commented on YARN-9265:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771261#comment-16771261
]
Hadoop QA commented on YARN-9265:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771170#comment-16771170
]
Hadoop QA commented on YARN-9265:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771097#comment-16771097
]
Peter Bacsko commented on YARN-9265:
Fixed chekstyle + findbugs issues.
Regarding Findbugs, I removed
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771086#comment-16771086
]
Hadoop QA commented on YARN-9265:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771072#comment-16771072
]
Zoltan Siegl commented on YARN-9265:
LGTM +1 (non-binding)
> FPGA plugin fails to recognize Intel
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771005#comment-16771005
]
Peter Bacsko commented on YARN-9265:
Thanks [~zsiegl] it's a reasonable improvement. Will update the
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770966#comment-16770966
]
Zoltan Siegl commented on YARN-9265:
Hi [~pbacsko] thank you for the patch.
In
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16766737#comment-16766737
]
Zhankun Tang commented on YARN-9265:
[~pbacsko] , Thanks for the patch. It looks good to me.
> FPGA
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16766040#comment-16766040
]
Hadoop QA commented on YARN-9265:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16765056#comment-16765056
]
Hadoop QA commented on YARN-9265:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16764841#comment-16764841
]
Peter Bacsko commented on YARN-9265:
I started to work on this.
I decided to handle the script output
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763083#comment-16763083
]
Peter Bacsko commented on YARN-9265:
[~snemeth] yes that is a possibility. A property value has to be
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763056#comment-16763056
]
Szilard Nemeth commented on YARN-9265:
--
Hi [~pbacsko]!
It's also worth to mention here for reference
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16761821#comment-16761821
]
Peter Bacsko commented on YARN-9265:
Today we had a meeting with [~snemeth], [~shuzirra], [~zsiegl],
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760683#comment-16760683
]
Szilard Nemeth commented on YARN-9265:
--
Hi [~pbacsko]!
Regarding your first comment:
As you said,
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758956#comment-16758956
]
Peter Bacsko commented on YARN-9265:
Thanks [~tangzhankun], the new device framework looks promising.
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758312#comment-16758312
]
Zhankun Tang commented on YARN-9265:
[~pbacsko] , Thanks for following up the FPGA features. I think
[
https://issues.apache.org/jira/browse/YARN-9265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16758296#comment-16758296
]
Peter Bacsko commented on YARN-9265:
We _really_ a good solution to this. There are several approach I
29 matches
Mail list logo