[jira] [Commented] (YARN-947) Defining the history data classes for the implementation of the reading/writing interface

[ https://issues.apache.org/jira/browse/YARN-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13808612#comment-13808612 ] Vinod Kumar Vavilapalli commented on YARN-947: -- Tx Mayank too for the reviews!

[jira] [Commented] (YARN-947) Defining the history data classes for the implementation of the reading/writing interface

[ https://issues.apache.org/jira/browse/YARN-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13803262#comment-13803262 ] Vinod Kumar Vavilapalli commented on YARN-947: -- Quick comments on the patch:

[jira] [Commented] (YARN-947) Defining the history data classes for the implementation of the reading/writing interface

[ https://issues.apache.org/jira/browse/YARN-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13803391#comment-13803391 ] Vinod Kumar Vavilapalli commented on YARN-947: -- Turns out ContainerHistoryData

[jira] [Commented] (YARN-947) Defining the history data classes for the implementation of the reading/writing interface

[ https://issues.apache.org/jira/browse/YARN-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13803458#comment-13803458 ] Mayank Bansal commented on YARN-947: [~zjshen] I think we should have seprate store

[jira] [Commented] (YARN-947) Defining the history data classes for the implementation of the reading/writing interface

[ https://issues.apache.org/jira/browse/YARN-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13803542#comment-13803542 ] Zhijie Shen commented on YARN-947: -- Thanks for the comments. Having discussion with

[jira] [Commented] (YARN-947) Defining the history data classes for the implementation of the reading/writing interface

[ https://issues.apache.org/jira/browse/YARN-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13803716#comment-13803716 ] Vinod Kumar Vavilapalli commented on YARN-947: -- Looks good, +1. Will check it

[jira] [Commented] (YARN-947) Defining the history data classes for the implementation of the reading/writing interface

[ https://issues.apache.org/jira/browse/YARN-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13803743#comment-13803743 ] Zhijie Shen commented on YARN-947: -- Thanks for the review. Will file the follow up tickets.

[jira] [Commented] (YARN-947) Defining the history data classes for the implementation of the reading/writing interface

[ https://issues.apache.org/jira/browse/YARN-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13801605#comment-13801605 ] Mayank Bansal commented on YARN-947: BTW yarnapplicationattemptstate is already part of

[jira] [Commented] (YARN-947) Defining the history data classes for the implementation of the reading/writing interface

[ https://issues.apache.org/jira/browse/YARN-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13802013#comment-13802013 ] Zhijie Shen commented on YARN-947: -- bq. BTW yarnapplicationattemptstate is already part of

[jira] [Commented] (YARN-947) Defining the history data classes for the implementation of the reading/writing interface

[ https://issues.apache.org/jira/browse/YARN-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13802024#comment-13802024 ] Hadoop QA commented on YARN-947: {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-947) Defining the history data classes for the implementation of the reading/writing interface

[ https://issues.apache.org/jira/browse/YARN-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13802073#comment-13802073 ] Mayank Bansal commented on YARN-947: bq. Yes, I know that. Xuan Gong, are you fine if I

[jira] [Commented] (YARN-947) Defining the history data classes for the implementation of the reading/writing interface

[ https://issues.apache.org/jira/browse/YARN-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13802349#comment-13802349 ] Mayank Bansal commented on YARN-947: [~zjshen] and I had an offline discussion, and we

[jira] [Commented] (YARN-947) Defining the history data classes for the implementation of the reading/writing interface

[ https://issues.apache.org/jira/browse/YARN-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13801038#comment-13801038 ] Mayank Bansal commented on YARN-947: [~zjshen] I think we still haven't decided on

[jira] [Commented] (YARN-947) Defining the history data classes for the implementation of the reading/writing interface

[ https://issues.apache.org/jira/browse/YARN-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13801056#comment-13801056 ] Mayank Bansal commented on YARN-947: [~zjshen] Some comments:

[jira] [Commented] (YARN-947) Defining the history data classes for the implementation of the reading/writing interface

[ https://issues.apache.org/jira/browse/YARN-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13801067#comment-13801067 ] Zhijie Shen commented on YARN-947: -- ApplicationAttemptState will make this jira depend on

[jira] [Commented] (YARN-947) Defining the history data classes for the implementation of the reading/writing interface

[ https://issues.apache.org/jira/browse/YARN-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13801092#comment-13801092 ] Mayank Bansal commented on YARN-947: Yes it will make it depends on YARN-978 , however i

[jira] [Commented] (YARN-947) Defining the history data classes for the implementation of the reading/writing interface

[ https://issues.apache.org/jira/browse/YARN-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13801470#comment-13801470 ] Zhijie Shen commented on YARN-947: -- I'm thinking that instead of putting

[jira] [Commented] (YARN-947) Defining the history data classes for the implementation of the reading/writing interface

[ https://issues.apache.org/jira/browse/YARN-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13798157#comment-13798157 ] Hadoop QA commented on YARN-947: {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-947) Defining the history data classes for the implementation of the reading/writing interface

[ https://issues.apache.org/jira/browse/YARN-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13797452#comment-13797452 ] Mayank Bansal commented on YARN-947: Over all looks good, however for point 5 please go

[jira] [Commented] (YARN-947) Defining the history data classes for the implementation of the reading/writing interface

[ https://issues.apache.org/jira/browse/YARN-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13796399#comment-13796399 ] Hadoop QA commented on YARN-947: {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (YARN-947) Defining the history data classes for the implementation of the reading/writing interface

[ https://issues.apache.org/jira/browse/YARN-947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13716035#comment-13716035 ] Hadoop QA commented on YARN-947: {color:red}-1 overall{color}. Here are the results of