[
https://issues.apache.org/jira/browse/YARN-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875485#comment-16875485
]
Prabhu Joseph commented on YARN-9581:
-
Thanks [~eyang].
> Fix WebAppUtils#getRMWebAppURLWithScheme
[
https://issues.apache.org/jira/browse/YARN-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875156#comment-16875156
]
Hudson commented on YARN-9581:
--
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #16836 (See
[
https://issues.apache.org/jira/browse/YARN-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16875153#comment-16875153
]
Eric Yang commented on YARN-9581:
-
+1 for addendum patch 001.
> Fix WebAppUtils#getRMWebAppURLWithScheme
[
https://issues.apache.org/jira/browse/YARN-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16874881#comment-16874881
]
Prabhu Joseph commented on YARN-9581:
-
[~eyang] This Jira fixes two rms in case of HA. Have Submitted
[
https://issues.apache.org/jira/browse/YARN-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858833#comment-16858833
]
Prabhu Joseph commented on YARN-9581:
-
[~eyang] Have submitted a addendum patch
[
https://issues.apache.org/jira/browse/YARN-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858832#comment-16858832
]
Hadoop QA commented on YARN-9581:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858782#comment-16858782
]
Prabhu Joseph commented on YARN-9581:
-
Thanks [~BilwaST] for finding the issue. Will reopen this Jira
[
https://issues.apache.org/jira/browse/YARN-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858401#comment-16858401
]
Prabhu Joseph commented on YARN-9581:
-
Yes Sure [~BilwaST].
> Fix
[
https://issues.apache.org/jira/browse/YARN-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858396#comment-16858396
]
Bilwa S T commented on YARN-9581:
-
[~Prabhu Joseph] can we add a addendum patch here only.
[
https://issues.apache.org/jira/browse/YARN-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858348#comment-16858348
]
Prabhu Joseph commented on YARN-9581:
-
[~BilwaST] Have assumed wrongly that
[
https://issues.apache.org/jira/browse/YARN-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858331#comment-16858331
]
Bilwa S T commented on YARN-9581:
-
Hi [~Prabhu Joseph]
[
https://issues.apache.org/jira/browse/YARN-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858292#comment-16858292
]
Prabhu Joseph commented on YARN-9581:
-
Thanks [~eyang].
> Fix WebAppUtils#getRMWebAppURLWithScheme
[
https://issues.apache.org/jira/browse/YARN-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858086#comment-16858086
]
Hudson commented on YARN-9581:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #16699 (See
[
https://issues.apache.org/jira/browse/YARN-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16858063#comment-16858063
]
Eric Yang commented on YARN-9581:
-
+1 for patch 007.
> Fix WebAppUtils#getRMWebAppURLWithScheme ignores
[
https://issues.apache.org/jira/browse/YARN-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857396#comment-16857396
]
Prabhu Joseph commented on YARN-9581:
-
[~eyang] Have changed to WebResource.Builder class in
[
https://issues.apache.org/jira/browse/YARN-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16856542#comment-16856542
]
Hadoop QA commented on YARN-9581:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855946#comment-16855946
]
Eric Yang commented on YARN-9581:
-
[~Prabhu Joseph] There is a bug in WebResource that it doesn't pass
[
https://issues.apache.org/jira/browse/YARN-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16855448#comment-16855448
]
Prabhu Joseph commented on YARN-9581:
-
[~eyang] Can you review this Jira when you get time. This fixes
[
https://issues.apache.org/jira/browse/YARN-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16852795#comment-16852795
]
Szilard Nemeth commented on YARN-9581:
--
Hi [~pbacsko]!
Your proposal for the lambda design is nice,
[
https://issues.apache.org/jira/browse/YARN-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851854#comment-16851854
]
Prabhu Joseph commented on YARN-9581:
-
[~giovanni.fumarola] Can you review this Jira when you get
[
https://issues.apache.org/jira/browse/YARN-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851759#comment-16851759
]
Hadoop QA commented on YARN-9581:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851237#comment-16851237
]
Hadoop QA commented on YARN-9581:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851094#comment-16851094
]
Prabhu Joseph commented on YARN-9581:
-
Thanks [~pbacsko] for the review. [^YARN-9581-005.patch] fixes
[
https://issues.apache.org/jira/browse/YARN-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851090#comment-16851090
]
Peter Bacsko commented on YARN-9581:
Looks like there are some minor checkstyle issues.
> Fix
[
https://issues.apache.org/jira/browse/YARN-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851081#comment-16851081
]
Hadoop QA commented on YARN-9581:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851078#comment-16851078
]
Peter Bacsko commented on YARN-9581:
LGTM +1 (non-binding) - pending Jenkins
> Fix
[
https://issues.apache.org/jira/browse/YARN-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16850956#comment-16850956
]
Prabhu Joseph commented on YARN-9581:
-
Thanks [~pbacsko] for sharing the design. It looks clean. Have
27 matches
Mail list logo