[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344531#comment-17344531 ] Qi Zhu commented on YARN-9615: -- [~chaosju] Sure.:D > Add dispatcher metrics to RM >

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17344505#comment-17344505 ] chaosju commented on YARN-9615: --- [~zhuqi]  Could I friend you on _Wechat_？ChaosJu is _Wechat_ nickname.   

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342768#comment-17342768 ] Peter Bacsko commented on YARN-9615: Committed to branch-3.3. > Add dispatcher metrics to RM >

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342764#comment-17342764 ] Peter Bacsko commented on YARN-9615: OK, the raw type stuff can be ignored, this is the same on trunk,

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17342607#comment-17342607 ] Hadoop QA commented on YARN-9615: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340181#comment-17340181 ] Bilwa S T commented on YARN-9615: - [~pbacsko] No problem. I just want this to be merged before 3.3.1

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340163#comment-17340163 ] Peter Bacsko commented on YARN-9615: [~BilwaST] I'm currently on vacation, I can get back to this on

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17340015#comment-17340015 ] Bilwa S T commented on YARN-9615: - [~pbacsko] can you please backport it to branch-3.3 ? > Add dispatcher

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17331981#comment-17331981 ] Qi Zhu commented on YARN-9615: -- Thanks [~chaosju] for concern. I will improve it later. And i also will

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17331831#comment-17331831 ] chaosju commented on YARN-9615: --- {code:java} // code placeholder protected Dispatcher createDispatcher()

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298072#comment-17298072 ] Qi Zhu commented on YARN-9615: -- Thanks [~pbacsko] for commit and review. > Add dispatcher metrics to RM >

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298069#comment-17298069 ] Peter Bacsko commented on YARN-9615: +1 I had to commit twice because there are actually two authors.

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298068#comment-17298068 ] Peter Bacsko commented on YARN-9615: Thanks [~zhuqi] patch v11 looks good, committing it soon. > Add

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17298032#comment-17298032 ] Hadoop QA commented on YARN-9615: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17297927#comment-17297927 ] Qi Zhu commented on YARN-9615: -- Submitted again, trigger the Jenkins.  > Add dispatcher metrics to RM >

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17297666#comment-17297666 ] Hadoop QA commented on YARN-9615: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17297504#comment-17297504 ] Peter Bacsko commented on YARN-9615: Let's wait for the Jenkins results of patch v10. > Add

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17297483#comment-17297483 ] Qi Zhu commented on YARN-9615: -- [~pbacsko] Fixed the remaining test error caused by test default redundant

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17297416#comment-17297416 ] Hadoop QA commented on YARN-9615: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17297359#comment-17297359 ] Qi Zhu commented on YARN-9615: -- Thanks [~pbacsko] for reply. [~pbacsko] Because the jenkins seem have

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17297311#comment-17297311 ] Peter Bacsko commented on YARN-9615: [~zhuqi] could you investigate the failing unit tests? Something

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17297153#comment-17297153 ] Hadoop QA commented on YARN-9615: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17297061#comment-17297061 ] Qi Zhu commented on YARN-9615: -- [~pbacsko] Rebased and trigger jenkins again. :D > Add dispatcher metrics to

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17294948#comment-17294948 ] Qi Zhu commented on YARN-9615: -- Thanks a lot [~pbacsko] for patient review. Fixed above in latest patch, and

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17294705#comment-17294705 ] Peter Bacsko commented on YARN-9615: Thanks [~zhuqi] for the patch. Minor things left: 1.

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17294531#comment-17294531 ] Hadoop QA commented on YARN-9615: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17294427#comment-17294427 ] Qi Zhu commented on YARN-9615: -- [~pbacsko] [~jhung] [~bibinchundatt] [~gandras]  Add more test about the

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17294365#comment-17294365 ] Hadoop QA commented on YARN-9615: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17294267#comment-17294267 ] Qi Zhu commented on YARN-9615: -- Fixed the checkstyle unused import. :D > Add dispatcher metrics to RM >

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17293801#comment-17293801 ] Hadoop QA commented on YARN-9615: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17293671#comment-17293671 ] Qi Zhu commented on YARN-9615: -- Fixed checkstyle in latest patch. :D > Add dispatcher metrics to RM >

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17293616#comment-17293616 ] Hadoop QA commented on YARN-9615: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17293457#comment-17293457 ] Qi Zhu commented on YARN-9615: -- [~pbacsko] [~gandras]  [~jhung] [~iwasakims]   Updated a patch for review,

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17291416#comment-17291416 ] Qi Zhu commented on YARN-9615: -- Thanks a lot [~pbacsko] for review.  You suggestion is very valid to me, i

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290963#comment-17290963 ] Peter Bacsko commented on YARN-9615: Thanks for the patch [~zhuqi]. Some comments: 1.  {noformat}

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17290237#comment-17290237 ] Peter Bacsko commented on YARN-9615: Thanks [~zhuqi] for the patch. I'll try to review this tomorrow.

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286976#comment-17286976 ] Hadoop QA commented on YARN-9615: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286869#comment-17286869 ] Qi Zhu commented on YARN-9615: -- Trigger the CI, look the result. > Add dispatcher metrics to RM >

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286472#comment-17286472 ] Hadoop QA commented on YARN-9615: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286468#comment-17286468 ] Qi Zhu commented on YARN-9615: -- [~jhung] [~bibinchundatt]  Update a patch, to fix the finding bugs, and the

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17286324#comment-17286324 ] Qi Zhu commented on YARN-9615: -- cc [~bteke] [~gandras]  [~pbacsko]  If you any advice about this? Thanks.

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282594#comment-17282594 ] Hadoop QA commented on YARN-9615: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17282458#comment-17282458 ] Qi Zhu commented on YARN-9615: -- [~jhung] [~bibinchundatt] I want to take it, now attached a patch for

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17281490#comment-17281490 ] Qi Zhu commented on YARN-9615: -- [~jhung] [~bibinchundatt] Is it going on? I think it is helpful for large

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191261#comment-17191261 ] Hadoop QA commented on YARN-9615: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17191258#comment-17191258 ] Masatake Iwasaki commented on YARN-9615: updated the target version for preparing 2.10.1 release.

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938133#comment-16938133 ] Aihua Xu commented on YARN-9615: This seems to be an important feature since sometimes we will see a large

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16923723#comment-16923723 ] Jonathan Hung commented on YARN-9615: - Hi [~bibinchundatt],  you mentioned you had a patch for this, 

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916128#comment-16916128 ] Jonathan Hung commented on YARN-9615: - [~bibinchundatt] that approach looks better. Feel free to take

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868266#comment-16868266 ] Bibin A Chundatt commented on YARN-9615: Thank you [~jhung] adding the poc * We could go for a

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868109#comment-16868109 ] Hadoop QA commented on YARN-9615: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868001#comment-16868001 ] Jonathan Hung commented on YARN-9615: - Thanks [~bibinchundatt], I just attached YARN-9615.poc.patch, 

[jira] [Commented] (YARN-9615) Add dispatcher metrics to RM

[ https://issues.apache.org/jira/browse/YARN-9615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16861745#comment-16861745 ] Bibin A Chundatt commented on YARN-9615: Thank you [~jhung] Incase you havnt started working on