[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13814653#comment-13814653
]
Vinod Kumar Vavilapalli commented on YARN-978:
--
Tx for the reviews Zhijie. Also
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13812682#comment-13812682
]
Zhijie Shen commented on YARN-978:
--
+1
[YARN-321] Adding ApplicationAttemptReport and
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13811390#comment-13811390
]
Zhijie Shen commented on YARN-978:
--
The patch is almost good, but still requires to address
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13811398#comment-13811398
]
Zhijie Shen commented on YARN-978:
--
Sorry for the breaking message above.
The patch is
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13811754#comment-13811754
]
Hadoop QA commented on YARN-978:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13809801#comment-13809801
]
Hadoop QA commented on YARN-978:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13804788#comment-13804788
]
Mayank Bansal commented on YARN-978:
Assigning it back to myself for change due to
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13766572#comment-13766572
]
Xuan Gong commented on YARN-978:
bq. I'm fine with remove it, but trackingUrl is on web UI
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13766916#comment-13766916
]
Hadoop QA commented on YARN-978:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13766935#comment-13766935
]
Mayank Bansal commented on YARN-978:
Looks good +1
Thanks,
Mayank
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13766028#comment-13766028
]
Mayank Bansal commented on YARN-978:
If we can add the tracking url that would be useful
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13764597#comment-13764597
]
Xuan Gong commented on YARN-978:
bq.Should it be the trackingUrl? LogUrl should be part of
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13764579#comment-13764579
]
Zhijie Shen commented on YARN-978:
--
{code}
+ @Private
+ @Unstable
+ public abstract void
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13764670#comment-13764670
]
Zhijie Shen commented on YARN-978:
--
bq. We have already discussed that we would remove the
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13763315#comment-13763315
]
Zhijie Shen commented on YARN-978:
--
The patch looks good, but it's better to add some
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13763898#comment-13763898
]
Xuan Gong commented on YARN-978:
bq.FINISHING to FINISHED is a bad merge, and indeed is a
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13763946#comment-13763946
]
Hadoop QA commented on YARN-978:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760462#comment-13760462
]
Hadoop QA commented on YARN-978:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13760530#comment-13760530
]
Hadoop QA commented on YARN-978:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13759746#comment-13759746
]
Hadoop QA commented on YARN-978:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735572#comment-13735572
]
Zhijie Shen commented on YARN-978:
--
I'm not pretty sure how users would make use of the
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735624#comment-13735624
]
Hitesh Shah commented on YARN-978:
--
In terms of duplication: diagnostics, host and rpcPort
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13733736#comment-13733736
]
Zhijie Shen commented on YARN-978:
--
bq. any reason why we need final application status and
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13729801#comment-13729801
]
Zhijie Shen commented on YARN-978:
--
+1 LGTM. The patch should be clean for trunk.
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13729832#comment-13729832
]
Mayank Bansal commented on YARN-978:
+1
Thanks,
Mayank
[YARN-321]
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13727788#comment-13727788
]
Zhijie Shen commented on YARN-978:
--
bq. We can add that. But do we really need this ?
From
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13727908#comment-13727908
]
Xuan Gong commented on YARN-978:
Add the containerId to AppAttemptReport.
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13727940#comment-13727940
]
Hadoop QA commented on YARN-978:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13727023#comment-13727023
]
Xuan Gong commented on YARN-978:
Open the ticket. Trunk need this, too
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13727084#comment-13727084
]
Hadoop QA commented on YARN-978:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13727188#comment-13727188
]
Xuan Gong commented on YARN-978:
No test cases added
[YARN-321] Adding
[
https://issues.apache.org/jira/browse/YARN-978?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13720551#comment-13720551
]
Hadoop QA commented on YARN-978:
{color:red}-1 overall{color}. Here are the results of
32 matches
Mail list logo
