[jira] [Commented] (YARN-9322) Store metrics for custom resource types into FSQueueMetrics and query them in FairSchedulerQueueInfo

[ https://issues.apache.org/jira/browse/YARN-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783354#comment-16783354 ] Adam Antal commented on YARN-9322: -- Hi [~snemeth], YARN-8842 looks like a big improvement, so it is might

[jira] [Commented] (YARN-9337) GPU auto-discovery script runs even when the resource is given by hand

[ https://issues.apache.org/jira/browse/YARN-9337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781631#comment-16781631 ] Adam Antal commented on YARN-9337: -- I started working on the issue, but it looks like there are several

[jira] [Commented] (YARN-9326) Fair Scheduler configuration defaults are not documented in case of min and maxResources

[ https://issues.apache.org/jira/browse/YARN-9326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780830#comment-16780830 ] Adam Antal commented on YARN-9326: -- Here you can find my patch v4, please tell me your thoughts. I

[jira] [Updated] (YARN-9326) Fair Scheduler configuration defaults are not documented in case of min and maxResources

[ https://issues.apache.org/jira/browse/YARN-9326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Antal updated YARN-9326: - Attachment: YARN-9326.004.patch > Fair Scheduler configuration defaults are not documented in case of min

[jira] [Commented] (YARN-9326) Fair Scheduler configuration defaults are not documented in case of min and maxResources

[ https://issues.apache.org/jira/browse/YARN-9326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780579#comment-16780579 ] Adam Antal commented on YARN-9326: -- Oh, there are lots of trouble around this help page. I did not

[jira] [Commented] (YARN-9337) GPU auto-discovery script runs even when the resource is given by hand

[ https://issues.apache.org/jira/browse/YARN-9337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780527#comment-16780527 ] Adam Antal commented on YARN-9337: -- I'm thinking specifically the

[jira] [Created] (YARN-9337) GPU auto-discovery script runs even when the resource is given by hand

Adam Antal created YARN-9337: Summary: GPU auto-discovery script runs even when the resource is given by hand Key: YARN-9337 URL: https://issues.apache.org/jira/browse/YARN-9337 Project: Hadoop YARN

[jira] [Updated] (YARN-9326) Fair Scheduler configuration defaults are not documented in case of min and maxResources

[ https://issues.apache.org/jira/browse/YARN-9326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Antal updated YARN-9326: - Attachment: YARN-9326.003.patch > Fair Scheduler configuration defaults are not documented in case of min

[jira] [Commented] (YARN-9326) Fair Scheduler configuration defaults are not documented in case of min and maxResources

[ https://issues.apache.org/jira/browse/YARN-9326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779508#comment-16779508 ] Adam Antal commented on YARN-9326: -- Thanks [~wilfreds] and [~templedf] for the useful comments. There

[jira] [Updated] (YARN-9326) Fair Scheduler configuration defaults are not documented in case of min and maxResources

[ https://issues.apache.org/jira/browse/YARN-9326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Antal updated YARN-9326: - Attachment: (was: YARN-9326.001.patch) > Fair Scheduler configuration defaults are not documented in

[jira] [Updated] (YARN-9326) Fair Scheduler configuration defaults are not documented in case of min and maxResources

[ https://issues.apache.org/jira/browse/YARN-9326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Antal updated YARN-9326: - Attachment: YARN-9326.001.patch > Fair Scheduler configuration defaults are not documented in case of min

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777872#comment-16777872 ] Adam Antal commented on YARN-9138: -- Thanks [~snemeth], Yeah, I didn't see that the GpuDiscoverer passes

[jira] [Updated] (YARN-9326) Fair Scheduler configuration defaults are not documented in case of min and maxResources

[ https://issues.apache.org/jira/browse/YARN-9326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Antal updated YARN-9326: - Attachment: YARN-9326.002.patch > Fair Scheduler configuration defaults are not documented in case of min

[jira] [Commented] (YARN-9326) Fair Scheduler configuration defaults are not documented in case of min and maxResources

[ https://issues.apache.org/jira/browse/YARN-9326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777803#comment-16777803 ] Adam Antal commented on YARN-9326: -- Thanks for the review [~snemeth], and [~templedf]. Here you can find

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1698#comment-1698 ] Adam Antal commented on YARN-9138: -- Thanks for your responses [~snemeth], the patch is pretty good now.

[jira] [Commented] (YARN-8662) Fair Scheduler stops scheduling when a queue is configured only CPU and memory

[ https://issues.apache.org/jira/browse/YARN-8662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776890#comment-16776890 ] Adam Antal commented on YARN-8662: -- Hi [~wilfreds] and [~Sen Zhao]. I just bumped into some similar

[jira] [Updated] (YARN-9326) Fair Scheduler configuration defaults are not documented in case of min and maxResources

[ https://issues.apache.org/jira/browse/YARN-9326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Antal updated YARN-9326: - Attachment: YARN-9326.001.patch > Fair Scheduler configuration defaults are not documented in case of min

[jira] [Commented] (YARN-9121) Users of GpuDiscoverer.getInstance() are not possible to test as instance is a static field

[ https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775353#comment-16775353 ] Adam Antal commented on YARN-9121: -- Thanks, +1 (non-binding). > Users of GpuDiscoverer.getInstance() are

[jira] [Created] (YARN-9326) Fair Scheduler configuration defaults are not documented in case of min and maxResources

Adam Antal created YARN-9326: Summary: Fair Scheduler configuration defaults are not documented in case of min and maxResources Key: YARN-9326 URL: https://issues.apache.org/jira/browse/YARN-9326

[jira] [Commented] (YARN-9121) Users of GpuDiscoverer.getInstance() are not possible to test as instance is a static field

[ https://issues.apache.org/jira/browse/YARN-9121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774426#comment-16774426 ] Adam Antal commented on YARN-9121: -- Hi Szilard, As I see through this patch, this is a patch rather about

[jira] [Commented] (YARN-9139) Simplify initializer code of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774409#comment-16774409 ] Adam Antal commented on YARN-9139: -- Hi Szilard! Thanks for the patch, I examined and it looks good as it

[jira] [Commented] (YARN-9138) Test error handling of nvidia-smi binary execution of GpuDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774399#comment-16774399 ] Adam Antal commented on YARN-9138: -- Hi [~snemeth], thanks for the patch! I have some minor comment

[jira] [Commented] (YARN-9322) Store metrics for custom resource types into FSQueueMetrics and query them in FairSchedulerQueueInfo

[ https://issues.apache.org/jira/browse/YARN-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774370#comment-16774370 ] Adam Antal commented on YARN-9322: -- I myself would handle the method visibilities in a seperate jira.

[jira] [Commented] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin

[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771064#comment-16771064 ] Adam Antal commented on YARN-9266: -- Great! +1 from jenkins, and +1 from me (non-binding). > Various

[jira] [Commented] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin

[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770942#comment-16770942 ] Adam Antal commented on YARN-9266: -- Don't forget to remove the instantiation of

[jira] [Commented] (YARN-9283) Javadoc of LinuxContainerExecutor#addSchedPriorityCommand has a wrong property name as reference

[ https://issues.apache.org/jira/browse/YARN-9283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769198#comment-16769198 ] Adam Antal commented on YARN-9283: -- Thanks [~ajisakaa] for the commit, and [~snemeth] for the review. >

[jira] [Commented] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin

[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769159#comment-16769159 ] Adam Antal commented on YARN-9266: -- Thanks for the reaction, [~pbacsko]. I agree with your points. >

[jira] [Commented] (YARN-9283) Javadoc of LinuxContainerExecutor#addSchedPriorityCommand has a wrong property name as reference

[ https://issues.apache.org/jira/browse/YARN-9283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16769064#comment-16769064 ] Adam Antal commented on YARN-9283: -- Good idea, included in [^YARN-9283.001.patch]. Javadoc compiles, and

[jira] [Updated] (YARN-9283) Javadoc of LinuxContainerExecutor#addSchedPriorityCommand has a wrong property name as reference

[ https://issues.apache.org/jira/browse/YARN-9283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Antal updated YARN-9283: - Attachment: YARN-9283.001.patch > Javadoc of LinuxContainerExecutor#addSchedPriorityCommand has a wrong

[jira] [Commented] (YARN-9123) Clean up and split testcases in TestNMWebServices for GPU support

[ https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768506#comment-16768506 ] Adam Antal commented on YARN-9123: -- I missed the TestNMWebServices failure by jenkins, but by int-casting

[jira] [Commented] (YARN-9270) Minor cleanup in TestFpgaDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768391#comment-16768391 ] Adam Antal commented on YARN-9270: -- After that 1 nasty remained checkstyle error it's +1 from me

[jira] [Commented] (YARN-9304) Improve various tests in YARN

[ https://issues.apache.org/jira/browse/YARN-9304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768382#comment-16768382 ] Adam Antal commented on YARN-9304: -- Probably there'll be needed some logs in the not yet created

[jira] [Commented] (YARN-9266) Various fixes are needed in IntelFpgaOpenclPlugin

[ https://issues.apache.org/jira/browse/YARN-9266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768375#comment-16768375 ] Adam Antal commented on YARN-9266: -- Thanks for the patch, [~pbacsko]! It looks good overall, and hope

[jira] [Commented] (YARN-9269) Minor cleanup in FpgaResourceAllocator

[ https://issues.apache.org/jira/browse/YARN-9269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768129#comment-16768129 ] Adam Antal commented on YARN-9269: -- Perfect, +1 (non-binding). > Minor cleanup in FpgaResourceAllocator

[jira] [Created] (YARN-9305) Add logging to TestNMWebServices

Adam Antal created YARN-9305: Summary: Add logging to TestNMWebServices Key: YARN-9305 URL: https://issues.apache.org/jira/browse/YARN-9305 Project: Hadoop YARN Issue Type: Sub-task

[jira] [Commented] (YARN-9123) Clean up and split testcases in TestNMWebServices for GPU support

[ https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16768127#comment-16768127 ] Adam Antal commented on YARN-9123: -- +1 (non-binding). I filed YARN-9304 for my concerns. > Clean up and

[jira] [Created] (YARN-9304) Improve various tests in YARN

Adam Antal created YARN-9304: Summary: Improve various tests in YARN Key: YARN-9304 URL: https://issues.apache.org/jira/browse/YARN-9304 Project: Hadoop YARN Issue Type: Improvement

[jira] [Commented] (YARN-9270) Minor cleanup in TestFpgaDiscoverer

[ https://issues.apache.org/jira/browse/YARN-9270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16766185#comment-16766185 ] Adam Antal commented on YARN-9270: -- Thanks for the patch, [~pbacsko]! Some thought of mine: - If we

[jira] [Commented] (YARN-9123) Clean up and split testcases in TestNMWebServices for GPU support

[ https://issues.apache.org/jira/browse/YARN-9123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16765911#comment-16765911 ] Adam Antal commented on YARN-9123: -- Hi [~snemeth]. Thanks for the patch! The cleaning looks good, I have

[jira] [Updated] (YARN-9283) Javadoc of LinuxContainerExecutor#addSchedPriorityCommand has a wrong property name as reference

[ https://issues.apache.org/jira/browse/YARN-9283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Antal updated YARN-9283: - Affects Version/s: 3.2.0 Component/s: yarn > Javadoc of

[jira] [Commented] (YARN-9283) Javadoc of LinuxContainerExecutor#addSchedPriorityCommand has a wrong property name as reference

[ https://issues.apache.org/jira/browse/YARN-9283?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763444#comment-16763444 ] Adam Antal commented on YARN-9283: -- I checked, and indeed we use that property (also "prioity" was a typo

[jira] [Updated] (YARN-9283) Javadoc of LinuxContainerExecutor#addSchedPriorityCommand has a wrong property name as reference

[ https://issues.apache.org/jira/browse/YARN-9283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Antal updated YARN-9283: - Attachment: YARN-9283.000.patch > Javadoc of LinuxContainerExecutor#addSchedPriorityCommand has a wrong

[jira] [Assigned] (YARN-9283) Javadoc of LinuxContainerExecutor#addSchedPriorityCommand has a wrong property name as reference

[ https://issues.apache.org/jira/browse/YARN-9283?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Adam Antal reassigned YARN-9283: Assignee: Adam Antal > Javadoc of LinuxContainerExecutor#addSchedPriorityCommand has a wrong >

[jira] [Comment Edited] (YARN-9269) Minor cleanup in FpgaResourceAllocator

[ https://issues.apache.org/jira/browse/YARN-9269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762983#comment-16762983 ] Adam Antal edited comment on YARN-9269 at 2/7/19 7:10 PM: -- Thanks you for the

[jira] [Commented] (YARN-9269) Minor cleanup in FpgaResourceAllocator

[ https://issues.apache.org/jira/browse/YARN-9269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762983#comment-16762983 ] Adam Antal commented on YARN-9269: -- Thanks you for the answers, I agree. Sorry for missing YARN-9268,

[jira] [Commented] (YARN-9269) Minor cleanup in FpgaResourceAllocator

[ https://issues.apache.org/jira/browse/YARN-9269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762899#comment-16762899 ] Adam Antal commented on YARN-9269: -- Thanks for the patch, [~pbacsko]. Nice job, the quality of the code

<    4   5   6   7   8   9