[
https://issues.apache.org/jira/browse/YARN-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16774370#comment-16774370
]
Adam Antal commented on YARN-9322:
----------------------------------
I myself would handle the method visibilities in a seperate jira.
Also could you please move the annotation {{@Before}} annotation in
{{TestFSQueueMetrics.java#setUp}}? You can do that in the follow-up issue, if
you decide to resolve the method visibilities in another jira.
Aside from that it's looks good as it is. +1 (non-binding).
> Store metrics for custom resource types into FSQueueMetrics and query them in
> FairSchedulerQueueInfo
> ----------------------------------------------------------------------------------------------------
>
> Key: YARN-9322
> URL: https://issues.apache.org/jira/browse/YARN-9322
> Project: Hadoop YARN
> Issue Type: Improvement
> Reporter: Szilard Nemeth
> Assignee: Szilard Nemeth
> Priority: Major
> Attachments: Screen Shot 2019-02-21 at 12.06.46.png,
> YARN-9322.001.patch
>
>
> YARN-8842 implemented storing and exposing of metrics of custom resources.
> FSQueueMetrics should have a similar implementation.
> All metrics stored in this class should have their custom resource
> counterpart.
> In a consequence of metrics were not stored for custom resource type,
> FairSchedulerQueueInfo haven't contained those values therefore the UI v1
> could not show them, obviously.
> See that gpu is missing from the value of "AM Max Resources" on the attached
> screenshot.
> Additionally, the callees of the following methods (in class
> FairSchedulerQueueInfo) should consider to query values for custom resource
> types too:
> getMaxAMShareMB
> getMaxAMShareVCores
> getAMResourceUsageMB
> getAMResourceUsageVCores
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
