[jira] [Commented] (YARN-8071) Add ability to specify nodemanager environment variables individually

2018-05-16 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478114#comment-16478114 ] Jason Lowe commented on YARN-8071: -- bq. I assume this windows-only test must be failing w

[jira] [Commented] (YARN-8292) Fix the dominant resource preemption cannot happen when some of the resource vector becomes negative

2018-05-16 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478104#comment-16478104 ] Jason Lowe commented on YARN-8292: -- bq. After preemption, there're at least one 0 major re

[jira] [Commented] (YARN-8286) Add NMClient callback on container relaunch

2018-05-16 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16478085#comment-16478085 ] Jason Lowe commented on YARN-8286: -- This could be implemented as something in the AM/NM cl

[jira] [Commented] (YARN-8292) Fix the dominant resource preemption cannot happen when some of the resource vector becomes negative

2018-05-16 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477941#comment-16477941 ] Jason Lowe commented on YARN-8292: -- I'm still confused about the Resources.isAnyMajorResou

[jira] [Commented] (YARN-8071) Add ability to specify nodemanager environment variables individually

2018-05-16 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477863#comment-16477863 ] Jason Lowe commented on YARN-8071: -- Thanks for updating the patch! bq. after further cons

[jira] [Commented] (YARN-8284) get_docker_command refactoring

2018-05-15 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476577#comment-16476577 ] Jason Lowe commented on YARN-8284: -- Thanks for updating the patch! +1 lgtm. I'll commit

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

2018-05-15 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476476#comment-16476476 ] Jason Lowe commented on YARN-8206: -- Thanks for the patch! Calling allowPrivilegedContaine

[jira] [Commented] (YARN-8284) get_docker_command refactoring

2018-05-15 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16476004#comment-16476004 ] Jason Lowe commented on YARN-8284: -- Thanks for the patch! In addition to moving the commo

[jira] [Commented] (YARN-7654) Support ENTRY_POINT for docker container

2018-05-11 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472814#comment-16472814 ] Jason Lowe commented on YARN-7654: -- Thanks for updating the patch! The unit test failure

[jira] [Commented] (YARN-8274) Docker command error during container relaunch

2018-05-11 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472777#comment-16472777 ] Jason Lowe commented on YARN-8274: -- bq. It would be nice if the code was refactored to ad

[jira] [Created] (YARN-8284) get_docker_command refactoring

2018-05-11 Thread Jason Lowe (JIRA)
Jason Lowe created YARN-8284: Summary: get_docker_command refactoring Key: YARN-8284 URL: https://issues.apache.org/jira/browse/YARN-8284 Project: Hadoop YARN Issue Type: Improvement Affects

[jira] [Commented] (YARN-7654) Support ENTRY_POINT for docker container

2018-05-11 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472597#comment-16472597 ] Jason Lowe commented on YARN-7654: -- Thanks for updating the patch! AbstractLauncher still

[jira] [Commented] (YARN-8244) TestContainerSchedulerQueuing.testStartMultipleContainers failed

2018-05-11 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472493#comment-16472493 ] Jason Lowe commented on YARN-8244: -- Thanks for updating the patch! +1 lgtm. Committing t

[jira] [Updated] (YARN-8274) Docker command error during container relaunch

2018-05-11 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Lowe updated YARN-8274: - Attachment: YARN-8274.002.patch > Docker command error during container relaunch >

[jira] [Commented] (YARN-8274) Docker command error during container relaunch

2018-05-11 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472345#comment-16472345 ] Jason Lowe commented on YARN-8274: -- I think I found the bug with the container relaunch an

[jira] [Assigned] (YARN-8274) Docker command error during container relaunch

2018-05-11 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Lowe reassigned YARN-8274: Assignee: Jason Lowe This should fix the pid mode issue, but it shouldn't improve the "not a docker

[jira] [Updated] (YARN-8274) Docker command error during container relaunch

2018-05-11 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8274?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Lowe updated YARN-8274: - Attachment: YARN-8274.001.patch > Docker command error during container relaunch >

[jira] [Commented] (YARN-8274) Docker command error during container relaunch

2018-05-11 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472213#comment-16472213 ] Jason Lowe commented on YARN-8274: -- I think I know what the issue is, sorry I missed it in

[jira] [Commented] (YARN-7654) Support ENTRY_POINT for docker container

2018-05-11 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16472209#comment-16472209 ] Jason Lowe commented on YARN-7654: -- Thanks for updating the patch! This previous comment

[jira] [Commented] (YARN-8242) YARN NM: OOM error while reading back the state store on recovery

2018-05-10 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470724#comment-16470724 ] Jason Lowe commented on YARN-8242: -- Thanks for updating the patch! Handling IOExceptions

[jira] [Commented] (YARN-8244) TestContainerSchedulerQueuing.testStartMultipleContainers failed

2018-05-10 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470492#comment-16470492 ] Jason Lowe commented on YARN-8244: -- Since in practice deserializing the protocol buffers w

[jira] [Commented] (YARN-7654) Support ENTRY_POINT for docker container

2018-05-10 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470427#comment-16470427 ] Jason Lowe commented on YARN-7654: -- bq. The patch writes .env file in the same nmPrivate d

[jira] [Commented] (YARN-7654) Support ENTRY_POINT for docker container

2018-05-09 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469613#comment-16469613 ] Jason Lowe commented on YARN-7654: -- In the interest in trying to get this into 3.1, I'm OK

[jira] [Commented] (YARN-8244) TestContainerSchedulerQueuing.testStartMultipleContainers failed

2018-05-09 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469262#comment-16469262 ] Jason Lowe commented on YARN-8244: -- Thanks for the patch, Jim! There are a lot of other t

[jira] [Comment Edited] (YARN-8244) TestContainerSchedulerQueuing.testStartMultipleContainers failed

2018-05-09 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469262#comment-16469262 ] Jason Lowe edited comment on YARN-8244 at 5/9/18 6:30 PM: -- Thanks

[jira] [Commented] (YARN-7654) Support ENTRY_POINT for docker container

2018-05-09 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468907#comment-16468907 ] Jason Lowe commented on YARN-7654: -- {{docker logs -f}} does what we want (at least as of D

[jira] [Commented] (YARN-7654) Support ENTRY_POINT for docker container

2018-05-08 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467977#comment-16467977 ] Jason Lowe commented on YARN-7654: -- I'll try to find time to take a closer look at this pa

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

2018-05-08 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467936#comment-16467936 ] Jason Lowe commented on YARN-8207: -- Thanks for updating the patch! +1 for patch v10. Tha

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

2018-05-08 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467783#comment-16467783 ] Jason Lowe commented on YARN-8207: -- {quote}One concern about the shallow copy, struct args

[jira] [Updated] (YARN-8261) Docker container launch fails due to .cmd file creation failure

2018-05-08 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Lowe updated YARN-8261: - Attachment: YARN-8261.002.patch > Docker container launch fails due to .cmd file creation failure > ---

[jira] [Commented] (YARN-8261) Docker container launch fails due to .cmd file creation failure

2018-05-08 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467770#comment-16467770 ] Jason Lowe commented on YARN-8261: -- Updating the patch to address the checkstyle issue. >

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

2018-05-08 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467750#comment-16467750 ] Jason Lowe commented on YARN-8207: -- Additional comment on patch 9: extract_execv_args nee

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

2018-05-08 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467725#comment-16467725 ] Jason Lowe commented on YARN-8207: -- init_args would not require the structure to be malloc

[jira] [Updated] (YARN-8263) DockerClient still touches hadoop.tmp.dir

2018-05-08 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Lowe updated YARN-8263: - Labels: Docker (was: ) Description: The DockerClient constructor fails if hadoop.tmp.dir is not s

[jira] [Created] (YARN-8263) DockerClient still touches hadoop.tmp.dir

2018-05-08 Thread Jason Lowe (JIRA)
Jason Lowe created YARN-8263: Summary: DockerClient still touches hadoop.tmp.dir Key: YARN-8263 URL: https://issues.apache.org/jira/browse/YARN-8263 Project: Hadoop YARN Issue Type: Sub-task

[jira] [Updated] (YARN-8261) Docker container launch fails due to .cmd file creation failure

2018-05-08 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Lowe updated YARN-8261: - Attachment: YARN-8261.001.patch > Docker container launch fails due to .cmd file creation failure > ---

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

2018-05-08 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467488#comment-16467488 ] Jason Lowe commented on YARN-8207: -- {quote}Struct args is still evolving. I think it would

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

2018-05-08 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467406#comment-16467406 ] Jason Lowe commented on YARN-8206: -- +1 for proposal 2 from me as well. > Sending a kill d

[jira] [Commented] (YARN-8259) Revisit liveliness checks for privileged Docker containers

2018-05-08 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467394#comment-16467394 ] Jason Lowe commented on YARN-8259: -- Linking YARN-8206 since it's somewhat related. Some i

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

2018-05-07 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16466578#comment-16466578 ] Jason Lowe commented on YARN-8207: -- Thanks for updating the patch! Nit: Needing to initia

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

2018-05-04 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463950#comment-16463950 ] Jason Lowe commented on YARN-8207: -- bq. Args is array of strings. Null terminator is not r

[jira] [Comment Edited] (YARN-8207) Docker container launch use popen have risk of shell expansion

2018-05-04 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463048#comment-16463048 ] Jason Lowe edited comment on YARN-8207 at 5/4/18 2:24 PM: -- Thanks

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

2018-05-03 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463048#comment-16463048 ] Jason Lowe commented on YARN-8207: -- Thanks for updating the patch! It's looking much bett

[jira] [Commented] (YARN-7973) Support ContainerRelaunch for Docker containers

2018-05-03 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462709#comment-16462709 ] Jason Lowe commented on YARN-7973: -- branch-3.1 is no longer building after this was commit

[jira] [Commented] (YARN-8242) YARN NM: OOM error while reading back the state store on recovery

2018-05-03 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462503#comment-16462503 ] Jason Lowe commented on YARN-8242: -- Thanks for the report and the patch! I'm not a fan of

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

2018-05-01 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16459923#comment-16459923 ] Jason Lowe commented on YARN-8207: -- bq. If docker run is aborted prior to complete downloa

[jira] [Commented] (YARN-8209) NPE in DeletionService

2018-05-01 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16459819#comment-16459819 ] Jason Lowe commented on YARN-8209: -- bq. In doing so, the exit code of docker overlaps with

[jira] [Commented] (YARN-8209) NPE in DeletionService

2018-05-01 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16459767#comment-16459767 ] Jason Lowe commented on YARN-8209: -- The patch looks functional to me, so the following are

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

2018-05-01 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16459701#comment-16459701 ] Jason Lowe commented on YARN-8206: -- {quote}Can we send signal to wrong pid, if pid namespa

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

2018-04-30 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16459207#comment-16459207 ] Jason Lowe commented on YARN-8207: -- Thanks for updating the patch! I will try to take a l

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

2018-04-27 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16457085#comment-16457085 ] Jason Lowe commented on YARN-8207: -- Thanks for the patch! Nit: chosen_container_log_dir s

[jira] [Commented] (YARN-8209) NPE in DeletionService

2018-04-27 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456607#comment-16456607 ] Jason Lowe commented on YARN-8209: -- I don't think Eric Badger is proposing to remove the .

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

2018-04-26 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454179#comment-16454179 ] Jason Lowe commented on YARN-8206: -- bq. I expect the Docker maintainers would steer us tow

[jira] [Commented] (YARN-8206) Sending a kill does not immediately kill docker containers

2018-04-25 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453126#comment-16453126 ] Jason Lowe commented on YARN-8206: -- Is it necessary to do a docker kill? We already have

[jira] [Commented] (YARN-7654) Support ENTRY_POINT for docker container

2018-04-25 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453119#comment-16453119 ] Jason Lowe commented on YARN-7654: -- I am not proposing to postpone the execv changes, rath

[jira] [Commented] (YARN-7654) Support ENTRY_POINT for docker container

2018-04-25 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452963#comment-16452963 ] Jason Lowe commented on YARN-7654: -- My apologies for the delay. I hope to get some time t

[jira] [Commented] (YARN-7786) NullPointerException while launching ApplicationMaster

2018-04-20 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16446111#comment-16446111 ] Jason Lowe commented on YARN-7786: -- Thanks for updating the patch! +1 lgtm. Committing t

[jira] [Commented] (YARN-7654) Support ENTRY_POINT for docker container

2018-04-20 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16445904#comment-16445904 ] Jason Lowe commented on YARN-7654: -- {quote}No additional file to clean up, environment var

[jira] [Updated] (YARN-7786) NullPointerException while launching ApplicationMaster

2018-04-18 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Lowe updated YARN-7786: - Affects Version/s: 2.9.0 Target Version/s: 3.2.0, 3.1.1, 2.9.2, 3.0.3 > NullPointerException while lau

[jira] [Commented] (YARN-7786) NullPointerException while launching ApplicationMaster

2018-04-18 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16442815#comment-16442815 ] Jason Lowe commented on YARN-7786: -- Thanks for updating the patch! Looks good overall, ju

[jira] [Updated] (YARN-7996) Allow user supplied Docker client configurations with YARN native services

2018-04-17 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Lowe updated YARN-7996: - Fix Version/s: 3.1.1 Ah, my apologies for the misunderstanding. The wording of the description implied to

[jira] [Commented] (YARN-7786) NullPointerException while launching ApplicationMaster

2018-04-17 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16441114#comment-16441114 ] Jason Lowe commented on YARN-7786: -- Thanks for the report and patch! My apologies for the

[jira] [Commented] (YARN-8071) Add ability to specify nodemanager environment variables individually

2018-04-16 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439678#comment-16439678 ] Jason Lowe commented on YARN-8071: -- Thanks for the patch! The original code passed the cu

[jira] [Commented] (YARN-7189) Container-executor doesn't remove Docker containers that error out early

2018-04-16 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439556#comment-16439556 ] Jason Lowe commented on YARN-7189: -- Thanks for updating the patch! +1 lgtm. I'll commit

[jira] [Commented] (YARN-7996) Allow user supplied Docker client configurations with YARN native services

2018-04-16 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16439543#comment-16439543 ] Jason Lowe commented on YARN-7996: -- Thanks for updating the patch! +1 lgtm. I'll commit

[jira] [Commented] (YARN-7189) Container-executor doesn't remove Docker containers that error out early

2018-04-12 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436358#comment-16436358 ] Jason Lowe commented on YARN-7189: -- Thanks for updating the patch! I agree this looks dif

[jira] [Commented] (YARN-8027) Setting hostname of docker container breaks for --net=host in docker 1.13

2018-04-12 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436301#comment-16436301 ] Jason Lowe commented on YARN-8027: -- Thanks for the branch-3.0 patch! +1 lgtm. Committing

[jira] [Updated] (YARN-8120) JVM can crash with SIGSEGV when exiting due to custom leveldb logger

2018-04-12 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Lowe updated YARN-8120: - Fix Version/s: 2.10.0 > JVM can crash with SIGSEGV when exiting due to custom leveldb logger >

[jira] [Updated] (YARN-8120) JVM can crash with SIGSEGV when exiting due to custom leveldb logger

2018-04-12 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Lowe updated YARN-8120: - Fix Version/s: 3.2.0 > JVM can crash with SIGSEGV when exiting due to custom leveldb logger > -

[jira] [Commented] (YARN-6315) Improve LocalResourcesTrackerImpl#isResourcePresent to return false for corrupted files

2018-04-11 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6315?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434649#comment-16434649 ] Jason Lowe commented on YARN-6315: -- Thanks for updating the patch! Sorry for the delay in

[jira] [Updated] (YARN-8147) TestClientRMService#testGetApplications sporadically fails

2018-04-11 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Lowe updated YARN-8147: - Attachment: YARN-8147.001.patch > TestClientRMService#testGetApplications sporadically fails >

[jira] [Commented] (YARN-8147) TestClientRMService#testGetApplications sporadically fails

2018-04-11 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434125#comment-16434125 ] Jason Lowe commented on YARN-8147: -- The unit test is making the assumption that the machin

[jira] [Created] (YARN-8147) TestClientRMService#testGetApplications sporadically fails

2018-04-11 Thread Jason Lowe (JIRA)
Jason Lowe created YARN-8147: Summary: TestClientRMService#testGetApplications sporadically fails Key: YARN-8147 URL: https://issues.apache.org/jira/browse/YARN-8147 Project: Hadoop YARN Issue Ty

[jira] [Commented] (YARN-7189) Container-executor doesn't remove Docker containers that error out early

2018-04-11 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434063#comment-16434063 ] Jason Lowe commented on YARN-7189: -- Thanks for the patch! The {{i < 5}} check is extraneo

[jira] [Commented] (YARN-7667) Docker Stop grace period should be configurable

2018-04-09 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431176#comment-16431176 ] Jason Lowe commented on YARN-7667: -- The TestContainerManager failure is unrelated, see YAR

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

2018-04-09 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430715#comment-16430715 ] Jason Lowe commented on YARN-7221: -- bq. do we agree on the last change to check submitting

[jira] [Commented] (YARN-7996) Allow user supplied Docker client configurations with YARN native services

2018-04-09 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430708#comment-16430708 ] Jason Lowe commented on YARN-7996: -- Thanks for the patch! Looks good to me overall. I ag

[jira] [Updated] (YARN-8120) JVM can crash with SIGSEGV when exiting due to custom leveldb logger

2018-04-06 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Lowe updated YARN-8120: - Component/s: (was: timelineserver) Patch that removes the use of a custom logger from leveldb instances

[jira] [Updated] (YARN-8120) JVM can crash with SIGSEGV when exiting due to custom leveldb logger

2018-04-06 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8120?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Lowe updated YARN-8120: - Attachment: YARN-8120.001.patch > JVM can crash with SIGSEGV when exiting due to custom leveldb logger > --

[jira] [Commented] (YARN-8120) JVM can crash with SIGSEGV when exiting due to custom leveldb logger

2018-04-05 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427671#comment-16427671 ] Jason Lowe commented on YARN-8120: -- As a workaround we can remove the use of custom user l

[jira] [Created] (YARN-8120) JVM can crash with SIGSEGV when exiting due to custom leveldb logger

2018-04-05 Thread Jason Lowe (JIRA)
Jason Lowe created YARN-8120: Summary: JVM can crash with SIGSEGV when exiting due to custom leveldb logger Key: YARN-8120 URL: https://issues.apache.org/jira/browse/YARN-8120 Project: Hadoop YARN

[jira] [Commented] (YARN-7905) Parent directory permission incorrect during public localization

2018-04-05 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427656#comment-16427656 ] Jason Lowe commented on YARN-7905: -- Thanks for the patch! +1 lgtm. > Parent directory pe

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

2018-04-05 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427611#comment-16427611 ] Jason Lowe commented on YARN-7221: -- Thanks for updating the patch! +1 latest patch looks

[jira] [Commented] (YARN-8118) Better utilize gracefully decommissioning node managers

2018-04-05 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16427591#comment-16427591 ] Jason Lowe commented on YARN-8118: -- This is definitely not desirable in all cases. We oft

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

2018-04-05 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426994#comment-16426994 ] Jason Lowe commented on YARN-7221: -- {quote}WNOHANG flag was used to track all child proces

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

2018-04-04 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426061#comment-16426061 ] Jason Lowe commented on YARN-7221: -- Thanks for updating the patch! I don't think WNOHANG

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

2018-04-04 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16425548#comment-16425548 ] Jason Lowe commented on YARN-7221: -- Thanks for updating the patch! The unit test failure

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

2018-04-03 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424688#comment-16424688 ] Jason Lowe commented on YARN-7221: -- Thanks for updating the patch! The groups variable ne

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

2018-04-03 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16424630#comment-16424630 ] Jason Lowe commented on YARN-7221: -- Thanks for updating the patch! Curious, why does the

[jira] [Commented] (YARN-7654) Support ENTRY_POINT for docker container

2018-04-02 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422893#comment-16422893 ] Jason Lowe commented on YARN-7654: -- We can place the debugging in the already existing lau

[jira] [Comment Edited] (YARN-8082) Include LocalizedResource size information in the NM download log for localization

2018-04-02 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422628#comment-16422628 ] Jason Lowe edited comment on YARN-8082 at 4/2/18 3:39 PM: -- Thanks

[jira] [Updated] (YARN-8082) Include LocalizedResource size information in the NM download log for localization

2018-04-02 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8082?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Lowe updated YARN-8082: - Issue Type: Improvement (was: Bug) > Include LocalizedResource size information in the NM download log for

[jira] [Commented] (YARN-8082) Include LocalizedResource size information in the NM download log for localization

2018-04-02 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-8082?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422628#comment-16422628 ] Jason Lowe commented on YARN-8082: -- Thanks for updating the patch! +1 lgtm. Committing t

[jira] [Commented] (YARN-7654) Support ENTRY_POINT for docker container

2018-04-02 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16422531#comment-16422531 ] Jason Lowe commented on YARN-7654: -- It does not make sense to me to support both options.

[jira] [Commented] (YARN-7654) Support ENTRY_POINT for docker container

2018-03-30 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420736#comment-16420736 ] Jason Lowe commented on YARN-7654: -- {quote}On Mac, it doesn't function the same for key va

[jira] [Commented] (YARN-7654) Support ENTRY_POINT for docker container

2018-03-30 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420623#comment-16420623 ] Jason Lowe commented on YARN-7654: -- {quote}The cmd file section based approach is the best

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

2018-03-30 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16420558#comment-16420558 ] Jason Lowe commented on YARN-7221: -- But 0 does _not_ equal true in C, otherwise we would j

[jira] [Commented] (YARN-7221) Add security check for privileged docker container

2018-03-29 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7221?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16419890#comment-16419890 ] Jason Lowe commented on YARN-7221: -- Sorry to show up late, but there's an uninitialized va

[jira] [Commented] (YARN-7654) Support ENTRY_POINT for docker container

2018-03-29 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16419835#comment-16419835 ] Jason Lowe commented on YARN-7654: -- Thanks for updating the patch! {quote}Is this the prop

[jira] [Updated] (YARN-7999) Docker launch fails when user private filecache directory is missing

2018-03-28 Thread Jason Lowe (JIRA)
[ https://issues.apache.org/jira/browse/YARN-7999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Lowe updated YARN-7999: - Target Version/s: 3.1.0 (was: 3.2.0) Fix Version/s: 3.1.0 > Docker launch fails when user private f

<    1   2   3   4   5   6   7   8   9   10   >