[
https://issues.apache.org/jira/browse/YARN-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17268602#comment-17268602
]
Szilard Nemeth commented on YARN-10578:
---
Hi [~gandras],
Thanks for the patch.
Latest patch LGTM,
[
https://issues.apache.org/jira/browse/YARN-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267879#comment-17267879
]
Andras Gyori commented on YARN-10578:
-
Thank you [~shuzirra], it is a valid point! However, I think
[
https://issues.apache.org/jira/browse/YARN-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267869#comment-17267869
]
Gergely Pollak commented on YARN-10578:
---
[~gandras] thank you for the patch, my only observation is
[
https://issues.apache.org/jira/browse/YARN-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267808#comment-17267808
]
Hadoop QA commented on YARN-10578:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267703#comment-17267703
]
Andras Gyori commented on YARN-10578:
-
Thanks [~wangda] and [~zhuqi] for the review.
[
https://issues.apache.org/jira/browse/YARN-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267601#comment-17267601
]
zhuqi commented on YARN-10578:
--
[~gandras]
If we need created without submit app, we should need write
[
https://issues.apache.org/jira/browse/YARN-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267511#comment-17267511
]
Hadoop QA commented on YARN-10578:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-10578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17267508#comment-17267508
]
Wangda Tan commented on YARN-10578:
---
+1 to the latest patch, submitted patch to trigger Jenkins.
> Fix