[jira] [Commented] (YARN-2940) Fix new findbugs warnings in rest of the hadoop-yarn components
[ https://issues.apache.org/jira/browse/YARN-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14258187#comment-14258187 ] Hudson commented on YARN-2940: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #51 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk-Java8/51/]) CHANGES.txt: add YARN-2940 (junping_du: rev 20674255ad891bb693ecb2faa5bdb37477073dac) * hadoop-yarn-project/CHANGES.txt YARN-2940. Fix new findbugs warnings in rest of the hadoop-yarn components. (Contributed by Li Lu) (junping_du: rev d468c9aaf15e977f12e6214b47996412c907e069) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/impl/zk/RegistrySecurity.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/NodeCLI.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/lib/ZKClient.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/QueueCLI.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/server/services/RegistryAdminService.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/impl/zk/CuratorService.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/AMRMClientImpl.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/utils/BuilderUtils.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-unmanaged-am-launcher/src/main/java/org/apache/hadoop/yarn/applications/unmanagedamlauncher/UnmanagedAMLauncher.java Fix new findbugs warnings in rest of the hadoop-yarn components --- Key: YARN-2940 URL: https://issues.apache.org/jira/browse/YARN-2940 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Li Lu Fix For: 2.7.0 Attachments: YARN-2940-121014-1.patch, YARN-2940-121014.patch, YARN-2940-122314.patch, findbugs_report_yarn.zip Fix findbugs warnings in the following YARN components: hadoop-yarn-applications-distributedshell hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-server-web-proxy hadoop-yarn-registry hadoop-yarn-server-common hadoop-yarn-client -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2940) Fix new findbugs warnings in rest of the hadoop-yarn components
[ https://issues.apache.org/jira/browse/YARN-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14258194#comment-14258194 ] Hudson commented on YARN-2940: -- FAILURE: Integrated in Hadoop-Yarn-trunk #785 (See [https://builds.apache.org/job/Hadoop-Yarn-trunk/785/]) CHANGES.txt: add YARN-2940 (junping_du: rev 20674255ad891bb693ecb2faa5bdb37477073dac) * hadoop-yarn-project/CHANGES.txt YARN-2940. Fix new findbugs warnings in rest of the hadoop-yarn components. (Contributed by Li Lu) (junping_du: rev d468c9aaf15e977f12e6214b47996412c907e069) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/lib/ZKClient.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/QueueCLI.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-unmanaged-am-launcher/src/main/java/org/apache/hadoop/yarn/applications/unmanagedamlauncher/UnmanagedAMLauncher.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/AMRMClientImpl.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/utils/BuilderUtils.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/impl/zk/RegistrySecurity.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/NodeCLI.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/server/services/RegistryAdminService.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/impl/zk/CuratorService.java Fix new findbugs warnings in rest of the hadoop-yarn components --- Key: YARN-2940 URL: https://issues.apache.org/jira/browse/YARN-2940 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Li Lu Fix For: 2.7.0 Attachments: YARN-2940-121014-1.patch, YARN-2940-121014.patch, YARN-2940-122314.patch, findbugs_report_yarn.zip Fix findbugs warnings in the following YARN components: hadoop-yarn-applications-distributedshell hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-server-web-proxy hadoop-yarn-registry hadoop-yarn-server-common hadoop-yarn-client -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2940) Fix new findbugs warnings in rest of the hadoop-yarn components
[ https://issues.apache.org/jira/browse/YARN-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14258274#comment-14258274 ] Hudson commented on YARN-2940: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk #1983 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/1983/]) CHANGES.txt: add YARN-2940 (junping_du: rev 20674255ad891bb693ecb2faa5bdb37477073dac) * hadoop-yarn-project/CHANGES.txt YARN-2940. Fix new findbugs warnings in rest of the hadoop-yarn components. (Contributed by Li Lu) (junping_du: rev d468c9aaf15e977f12e6214b47996412c907e069) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/server/services/RegistryAdminService.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/lib/ZKClient.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-unmanaged-am-launcher/src/main/java/org/apache/hadoop/yarn/applications/unmanagedamlauncher/UnmanagedAMLauncher.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/impl/zk/RegistrySecurity.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/QueueCLI.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/NodeCLI.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/impl/zk/CuratorService.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/AMRMClientImpl.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/utils/BuilderUtils.java Fix new findbugs warnings in rest of the hadoop-yarn components --- Key: YARN-2940 URL: https://issues.apache.org/jira/browse/YARN-2940 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Li Lu Fix For: 2.7.0 Attachments: YARN-2940-121014-1.patch, YARN-2940-121014.patch, YARN-2940-122314.patch, findbugs_report_yarn.zip Fix findbugs warnings in the following YARN components: hadoop-yarn-applications-distributedshell hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-server-web-proxy hadoop-yarn-registry hadoop-yarn-server-common hadoop-yarn-client -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2940) Fix new findbugs warnings in rest of the hadoop-yarn components
[ https://issues.apache.org/jira/browse/YARN-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14258288#comment-14258288 ] Hudson commented on YARN-2940: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #48 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/48/]) CHANGES.txt: add YARN-2940 (junping_du: rev 20674255ad891bb693ecb2faa5bdb37477073dac) * hadoop-yarn-project/CHANGES.txt YARN-2940. Fix new findbugs warnings in rest of the hadoop-yarn components. (Contributed by Li Lu) (junping_du: rev d468c9aaf15e977f12e6214b47996412c907e069) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/QueueCLI.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-unmanaged-am-launcher/src/main/java/org/apache/hadoop/yarn/applications/unmanagedamlauncher/UnmanagedAMLauncher.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/utils/BuilderUtils.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/impl/zk/RegistrySecurity.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/AMRMClientImpl.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/lib/ZKClient.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/server/services/RegistryAdminService.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/impl/zk/CuratorService.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/NodeCLI.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java Fix new findbugs warnings in rest of the hadoop-yarn components --- Key: YARN-2940 URL: https://issues.apache.org/jira/browse/YARN-2940 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Li Lu Fix For: 2.7.0 Attachments: YARN-2940-121014-1.patch, YARN-2940-121014.patch, YARN-2940-122314.patch, findbugs_report_yarn.zip Fix findbugs warnings in the following YARN components: hadoop-yarn-applications-distributedshell hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-server-web-proxy hadoop-yarn-registry hadoop-yarn-server-common hadoop-yarn-client -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2940) Fix new findbugs warnings in rest of the hadoop-yarn components
[ https://issues.apache.org/jira/browse/YARN-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14258317#comment-14258317 ] Hudson commented on YARN-2940: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #52 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/52/]) CHANGES.txt: add YARN-2940 (junping_du: rev 20674255ad891bb693ecb2faa5bdb37477073dac) * hadoop-yarn-project/CHANGES.txt YARN-2940. Fix new findbugs warnings in rest of the hadoop-yarn components. (Contributed by Li Lu) (junping_du: rev d468c9aaf15e977f12e6214b47996412c907e069) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/impl/zk/RegistrySecurity.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/NodeCLI.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/utils/BuilderUtils.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/impl/zk/CuratorService.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-unmanaged-am-launcher/src/main/java/org/apache/hadoop/yarn/applications/unmanagedamlauncher/UnmanagedAMLauncher.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/server/services/RegistryAdminService.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/lib/ZKClient.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/QueueCLI.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/AMRMClientImpl.java * hadoop-yarn-project/CHANGES.txt Fix new findbugs warnings in rest of the hadoop-yarn components --- Key: YARN-2940 URL: https://issues.apache.org/jira/browse/YARN-2940 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Li Lu Fix For: 2.7.0 Attachments: YARN-2940-121014-1.patch, YARN-2940-121014.patch, YARN-2940-122314.patch, findbugs_report_yarn.zip Fix findbugs warnings in the following YARN components: hadoop-yarn-applications-distributedshell hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-server-web-proxy hadoop-yarn-registry hadoop-yarn-server-common hadoop-yarn-client -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2940) Fix new findbugs warnings in rest of the hadoop-yarn components
[ https://issues.apache.org/jira/browse/YARN-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14258335#comment-14258335 ] Hudson commented on YARN-2940: -- SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2002 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2002/]) CHANGES.txt: add YARN-2940 (junping_du: rev 20674255ad891bb693ecb2faa5bdb37477073dac) * hadoop-yarn-project/CHANGES.txt YARN-2940. Fix new findbugs warnings in rest of the hadoop-yarn components. (Contributed by Li Lu) (junping_du: rev d468c9aaf15e977f12e6214b47996412c907e069) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/impl/zk/CuratorService.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/utils/BuilderUtils.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-unmanaged-am-launcher/src/main/java/org/apache/hadoop/yarn/applications/unmanagedamlauncher/UnmanagedAMLauncher.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/NodeCLI.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/server/services/RegistryAdminService.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/lib/ZKClient.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/QueueCLI.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/impl/zk/RegistrySecurity.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/AMRMClientImpl.java Fix new findbugs warnings in rest of the hadoop-yarn components --- Key: YARN-2940 URL: https://issues.apache.org/jira/browse/YARN-2940 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Li Lu Fix For: 2.7.0 Attachments: YARN-2940-121014-1.patch, YARN-2940-121014.patch, YARN-2940-122314.patch, findbugs_report_yarn.zip Fix findbugs warnings in the following YARN components: hadoop-yarn-applications-distributedshell hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-server-web-proxy hadoop-yarn-registry hadoop-yarn-server-common hadoop-yarn-client -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2940) Fix new findbugs warnings in rest of the hadoop-yarn components
[ https://issues.apache.org/jira/browse/YARN-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257073#comment-14257073 ] Junping Du commented on YARN-2940: -- Thanks for upload related findbugs warning messages. Patch looks good to me except one issue below: {code} +Class name=org.apache.hadoop.yarn.server.webproxy.WebAppProxyServlet / +Field name=trackingUriPlugins / +Bug pattern=SE_BAD_FIELD / + /Match + Match {code} I believe the right fix here is to put transient tag to the field of trackingUriPlugins, as it can be recreate from constructor after deserialized so unnecessary to persistent during serialization. Fix new findbugs warnings in rest of the hadoop-yarn components --- Key: YARN-2940 URL: https://issues.apache.org/jira/browse/YARN-2940 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Li Lu Attachments: YARN-2940-121014-1.patch, YARN-2940-121014.patch, findbugs_report_yarn.zip Fix findbugs warnings in the following YARN components: hadoop-yarn-applications-distributedshell hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-server-web-proxy hadoop-yarn-registry hadoop-yarn-server-common hadoop-yarn-client -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2940) Fix new findbugs warnings in rest of the hadoop-yarn components
[ https://issues.apache.org/jira/browse/YARN-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257703#comment-14257703 ] Hadoop QA commented on YARN-2940: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12688936/YARN-2940-122314.patch against trunk revision 66cfe1d. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy: org.apache.hadoop.yarn.client.TestResourceTrackerOnHA org.apache.hadoop.yarn.client.TestApplicationClientProtocolOnHA Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6181//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6181//console This message is automatically generated. Fix new findbugs warnings in rest of the hadoop-yarn components --- Key: YARN-2940 URL: https://issues.apache.org/jira/browse/YARN-2940 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Li Lu Attachments: YARN-2940-121014-1.patch, YARN-2940-121014.patch, YARN-2940-122314.patch, findbugs_report_yarn.zip Fix findbugs warnings in the following YARN components: hadoop-yarn-applications-distributedshell hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-server-web-proxy hadoop-yarn-registry hadoop-yarn-server-common hadoop-yarn-client -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2940) Fix new findbugs warnings in rest of the hadoop-yarn components
[ https://issues.apache.org/jira/browse/YARN-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257759#comment-14257759 ] Li Lu commented on YARN-2940: - Similar to last time, the two UT failures are irrelevant to the changes in this patch. Fix new findbugs warnings in rest of the hadoop-yarn components --- Key: YARN-2940 URL: https://issues.apache.org/jira/browse/YARN-2940 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Li Lu Attachments: YARN-2940-121014-1.patch, YARN-2940-121014.patch, YARN-2940-122314.patch, findbugs_report_yarn.zip Fix findbugs warnings in the following YARN components: hadoop-yarn-applications-distributedshell hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-server-web-proxy hadoop-yarn-registry hadoop-yarn-server-common hadoop-yarn-client -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2940) Fix new findbugs warnings in rest of the hadoop-yarn components
[ https://issues.apache.org/jira/browse/YARN-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257768#comment-14257768 ] Junping Du commented on YARN-2940: -- bq. I updated the patch according to you suggestions. After changing the field into transient I got another SE_TRANSIENT_FIELD_NOT_RESTORED warning. I fixed it by adding a customized readObject method. Interesting... the conf field should be in exactly the same situation but looks like Findbugs didn't complain before. Check some discussions in google, looks like it could due to the bug of Findbugs (see http://blog.gmane.org/gmane.comp.java.findbugs.general/month=20121101). Anyway, the current patch looks good to me. +1. Will commit it soon. Fix new findbugs warnings in rest of the hadoop-yarn components --- Key: YARN-2940 URL: https://issues.apache.org/jira/browse/YARN-2940 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Li Lu Attachments: YARN-2940-121014-1.patch, YARN-2940-121014.patch, YARN-2940-122314.patch, findbugs_report_yarn.zip Fix findbugs warnings in the following YARN components: hadoop-yarn-applications-distributedshell hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-server-web-proxy hadoop-yarn-registry hadoop-yarn-server-common hadoop-yarn-client -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2940) Fix new findbugs warnings in rest of the hadoop-yarn components
[ https://issues.apache.org/jira/browse/YARN-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257776#comment-14257776 ] Li Lu commented on YARN-2940: - Thanks [~djp]. I agree that this looks very weird because we're almost doing exactly the same thing with the conf field. The only thing looks suspicious is the trackingUriPlugins field is init'ed through reflection, which, I suspect, may trigger some findbugs false alarms? But anyways I've fixed the two transient final fields. Fix new findbugs warnings in rest of the hadoop-yarn components --- Key: YARN-2940 URL: https://issues.apache.org/jira/browse/YARN-2940 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Li Lu Attachments: YARN-2940-121014-1.patch, YARN-2940-121014.patch, YARN-2940-122314.patch, findbugs_report_yarn.zip Fix findbugs warnings in the following YARN components: hadoop-yarn-applications-distributedshell hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-server-web-proxy hadoop-yarn-registry hadoop-yarn-server-common hadoop-yarn-client -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2940) Fix new findbugs warnings in rest of the hadoop-yarn components
[ https://issues.apache.org/jira/browse/YARN-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257872#comment-14257872 ] Hudson commented on YARN-2940: -- FAILURE: Integrated in Hadoop-trunk-Commit #6784 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/6784/]) CHANGES.txt: add YARN-2940 (junping_du: rev 20674255ad891bb693ecb2faa5bdb37477073dac) * hadoop-yarn-project/CHANGES.txt Fix new findbugs warnings in rest of the hadoop-yarn components --- Key: YARN-2940 URL: https://issues.apache.org/jira/browse/YARN-2940 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Li Lu Attachments: YARN-2940-121014-1.patch, YARN-2940-121014.patch, YARN-2940-122314.patch, findbugs_report_yarn.zip Fix findbugs warnings in the following YARN components: hadoop-yarn-applications-distributedshell hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-server-web-proxy hadoop-yarn-registry hadoop-yarn-server-common hadoop-yarn-client -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2940) Fix new findbugs warnings in rest of the hadoop-yarn components
[ https://issues.apache.org/jira/browse/YARN-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14257930#comment-14257930 ] Hudson commented on YARN-2940: -- FAILURE: Integrated in Hadoop-trunk-Commit #6785 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/6785/]) YARN-2940. Fix new findbugs warnings in rest of the hadoop-yarn components. (Contributed by Li Lu) (junping_du: rev d468c9aaf15e977f12e6214b47996412c907e069) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/QueueCLI.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-unmanaged-am-launcher/src/main/java/org/apache/hadoop/yarn/applications/unmanagedamlauncher/UnmanagedAMLauncher.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/AMRMClientImpl.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/server/utils/BuilderUtils.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/impl/zk/RegistrySecurity.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/ApplicationCLI.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell/src/main/java/org/apache/hadoop/yarn/applications/distributedshell/ApplicationMaster.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/main/java/org/apache/hadoop/yarn/lib/ZKClient.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/NodeCLI.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/server/services/RegistryAdminService.java * hadoop-yarn-project/CHANGES.txt * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/main/java/org/apache/hadoop/yarn/server/webproxy/WebAppProxyServlet.java * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry/src/main/java/org/apache/hadoop/registry/client/impl/zk/CuratorService.java Fix new findbugs warnings in rest of the hadoop-yarn components --- Key: YARN-2940 URL: https://issues.apache.org/jira/browse/YARN-2940 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Li Lu Fix For: 2.7.0 Attachments: YARN-2940-121014-1.patch, YARN-2940-121014.patch, YARN-2940-122314.patch, findbugs_report_yarn.zip Fix findbugs warnings in the following YARN components: hadoop-yarn-applications-distributedshell hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-server-web-proxy hadoop-yarn-registry hadoop-yarn-server-common hadoop-yarn-client -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2940) Fix new findbugs warnings in rest of the hadoop-yarn components
[ https://issues.apache.org/jira/browse/YARN-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14248413#comment-14248413 ] Junping Du commented on YARN-2940: -- Thanks [~gtCarrera9] for delivering a fix! I am reviewing it now. Could you also post the Findbugs warnings in attached file so that we could review it more conveniently? Thanks! Fix new findbugs warnings in rest of the hadoop-yarn components --- Key: YARN-2940 URL: https://issues.apache.org/jira/browse/YARN-2940 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Li Lu Attachments: YARN-2940-121014-1.patch, YARN-2940-121014.patch Fix findbugs warnings in the following YARN components: hadoop-yarn-applications-distributedshell hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-server-web-proxy hadoop-yarn-registry hadoop-yarn-server-common hadoop-yarn-client -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2940) Fix new findbugs warnings in rest of the hadoop-yarn components
[ https://issues.apache.org/jira/browse/YARN-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14248645#comment-14248645 ] Hadoop QA commented on YARN-2940: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12687529/findbugs_report_yarn.zip against trunk revision b7923a3. {color:red}-1 patch{color}. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6123//console This message is automatically generated. Fix new findbugs warnings in rest of the hadoop-yarn components --- Key: YARN-2940 URL: https://issues.apache.org/jira/browse/YARN-2940 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Li Lu Attachments: YARN-2940-121014-1.patch, YARN-2940-121014.patch, findbugs_report_yarn.zip Fix findbugs warnings in the following YARN components: hadoop-yarn-applications-distributedshell hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-server-web-proxy hadoop-yarn-registry hadoop-yarn-server-common hadoop-yarn-client -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2940) Fix new findbugs warnings in rest of the hadoop-yarn components
[ https://issues.apache.org/jira/browse/YARN-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14248705#comment-14248705 ] Varun Saxena commented on YARN-2940: Hi [~gtCarrera9], how to generate a Findbugs HTML report ? I used to check the xml generated in target folder. I can probably generate HTML reports for other 2 YARN Findbugs issues.. Fix new findbugs warnings in rest of the hadoop-yarn components --- Key: YARN-2940 URL: https://issues.apache.org/jira/browse/YARN-2940 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Li Lu Attachments: YARN-2940-121014-1.patch, YARN-2940-121014.patch, findbugs_report_yarn.zip Fix findbugs warnings in the following YARN components: hadoop-yarn-applications-distributedshell hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-server-web-proxy hadoop-yarn-registry hadoop-yarn-server-common hadoop-yarn-client -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2940) Fix new findbugs warnings in rest of the hadoop-yarn components
[ https://issues.apache.org/jira/browse/YARN-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14248931#comment-14248931 ] Li Lu commented on YARN-2940: - Hi [~varun_saxena], you can firstly run {{mvn findbugs:findbugs}} to generate the xml reports in target directories. Them, make sure you have findbugs in $FINDBUGS_HOME, and run something like: {code} $FINDBUGS_HOME/bin/convertXmlToText -html target/findbugsXml.xml ~/findbugs/report.html {code} You can then check the html file. That's the findbugs report of the directory in which you run the command. Fix new findbugs warnings in rest of the hadoop-yarn components --- Key: YARN-2940 URL: https://issues.apache.org/jira/browse/YARN-2940 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Li Lu Attachments: YARN-2940-121014-1.patch, YARN-2940-121014.patch, findbugs_report_yarn.zip Fix findbugs warnings in the following YARN components: hadoop-yarn-applications-distributedshell hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-server-web-proxy hadoop-yarn-registry hadoop-yarn-server-common hadoop-yarn-client -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2940) Fix new findbugs warnings in rest of the hadoop-yarn components
[ https://issues.apache.org/jira/browse/YARN-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14249370#comment-14249370 ] Varun Saxena commented on YARN-2940: Thanks [~gtCarrera9] Fix new findbugs warnings in rest of the hadoop-yarn components --- Key: YARN-2940 URL: https://issues.apache.org/jira/browse/YARN-2940 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Li Lu Attachments: YARN-2940-121014-1.patch, YARN-2940-121014.patch, findbugs_report_yarn.zip Fix findbugs warnings in the following YARN components: hadoop-yarn-applications-distributedshell hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-server-web-proxy hadoop-yarn-registry hadoop-yarn-server-common hadoop-yarn-client -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2940) Fix new findbugs warnings in rest of the hadoop-yarn components
[ https://issues.apache.org/jira/browse/YARN-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14242890#comment-14242890 ] Li Lu commented on YARN-2940: - Similar to the patch of YARN-2939, I could not reproduce the test failures locally. For the results I can see all of them are connection related, which appears to be unrelated to the changes in this patch. Fix new findbugs warnings in rest of the hadoop-yarn components --- Key: YARN-2940 URL: https://issues.apache.org/jira/browse/YARN-2940 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Li Lu Attachments: YARN-2940-121014-1.patch, YARN-2940-121014.patch Fix findbugs warnings in the following YARN components: hadoop-yarn-applications-distributedshell hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-server-web-proxy hadoop-yarn-registry hadoop-yarn-server-common hadoop-yarn-client -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2940) Fix new findbugs warnings in rest of the hadoop-yarn components
[ https://issues.apache.org/jira/browse/YARN-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14242220#comment-14242220 ] Hadoop QA commented on YARN-2940: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12686459/YARN-2940-121014.patch against trunk revision cb99f43. {color:red}-1 patch{color}. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6081//console This message is automatically generated. Fix new findbugs warnings in rest of the hadoop-yarn components --- Key: YARN-2940 URL: https://issues.apache.org/jira/browse/YARN-2940 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Li Lu Attachments: YARN-2940-121014.patch Fix findbugs warnings in the following YARN components: hadoop-yarn-applications-distributedshell hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-server-web-proxy hadoop-yarn-registry hadoop-yarn-server-common hadoop-yarn-client -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2940) Fix new findbugs warnings in rest of the hadoop-yarn components
[ https://issues.apache.org/jira/browse/YARN-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14242247#comment-14242247 ] Varun Saxena commented on YARN-2940: I wonder what the issue is. Even my patch failed to apply even though its applying on trunk in local. Fix new findbugs warnings in rest of the hadoop-yarn components --- Key: YARN-2940 URL: https://issues.apache.org/jira/browse/YARN-2940 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Li Lu Attachments: YARN-2940-121014-1.patch, YARN-2940-121014.patch Fix findbugs warnings in the following YARN components: hadoop-yarn-applications-distributedshell hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-server-web-proxy hadoop-yarn-registry hadoop-yarn-server-common hadoop-yarn-client -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2940) Fix new findbugs warnings in rest of the hadoop-yarn components
[ https://issues.apache.org/jira/browse/YARN-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14242288#comment-14242288 ] Hadoop QA commented on YARN-2940: - {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12686462/YARN-2940-121014-1.patch against trunk revision cb99f43. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:red}-1 tests included{color}. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 core tests{color}. The patch failed these unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client hadoop-yarn-project/hadoop-yarn/hadoop-yarn-registry hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common: org.apache.hadoop.yarn.client.TestResourceTrackerOnHA org.apache.hadoop.yarn.client.TestApplicationClientProtocolOnHA Test results: https://builds.apache.org/job/PreCommit-YARN-Build/6082//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/6082//console This message is automatically generated. Fix new findbugs warnings in rest of the hadoop-yarn components --- Key: YARN-2940 URL: https://issues.apache.org/jira/browse/YARN-2940 Project: Hadoop YARN Issue Type: Improvement Reporter: Varun Saxena Assignee: Li Lu Attachments: YARN-2940-121014-1.patch, YARN-2940-121014.patch Fix findbugs warnings in the following YARN components: hadoop-yarn-applications-distributedshell hadoop-yarn-applications-unmanaged-am-launcher hadoop-yarn-server-web-proxy hadoop-yarn-registry hadoop-yarn-server-common hadoop-yarn-client -- This message was sent by Atlassian JIRA (v6.3.4#6332)