[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14971124#comment-14971124 ] Varun Saxena commented on YARN-4000: Thanks [~jianhe] for the commit and review. Thanks [~leftnoteasy],

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14967744#comment-14967744 ] Varun Saxena commented on YARN-4000: [~jianhe], I had updated a 2.7 patch just in case you missed. >

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14963940#comment-14963940 ] Hadoop QA commented on YARN-4000: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14960235#comment-14960235 ] Varun Saxena commented on YARN-4000: bq. could you provide a patch for branch-2.7 ? Ok will provide. >

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14959912#comment-14959912 ] Jian He commented on YARN-4000: --- [~varun_saxena], I have committed to trunk and branch-2, could you provide

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14959936#comment-14959936 ] Hudson commented on YARN-4000: -- FAILURE: Integrated in Hadoop-trunk-Commit #8649 (See

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14960022#comment-14960022 ] Hudson commented on YARN-4000: -- FAILURE: Integrated in Hadoop-Yarn-trunk #1277 (See

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14960075#comment-14960075 ] Hudson commented on YARN-4000: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #555 (See

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14959993#comment-14959993 ] Hudson commented on YARN-4000: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #541 (See

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14959895#comment-14959895 ] Jian He commented on YARN-4000: --- bq. check if RMApp is killing sure, we can have this in a separate jira. We

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14960084#comment-14960084 ] Hudson commented on YARN-4000: -- FAILURE: Integrated in Hadoop-Hdfs-trunk #2441 (See

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14960187#comment-14960187 ] Hudson commented on YARN-4000: -- FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #504 (See

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14959474#comment-14959474 ] Varun Saxena commented on YARN-4000: [~jianhe], I get it now as to what you meant when you say this

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14957293#comment-14957293 ] Varun Saxena commented on YARN-4000: Checkstyle is related to file length. I guess no need to fix it.

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14957904#comment-14957904 ] Jian He commented on YARN-4000: --- Forgot about my previous comment: bq. actually, I think this will be a

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14956963#comment-14956963 ] Varun Saxena commented on YARN-4000: [~jianhe], Discussed offline with Rohith. Diagnostic information

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14957285#comment-14957285 ] Hadoop QA commented on YARN-4000: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14953437#comment-14953437 ] Jian He commented on YARN-4000: --- Hi [~varun_saxena], the patch not applying on trunk now, would you like to

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14945318#comment-14945318 ] Rohith Sharma K S commented on YARN-4000: - [~varun_saxena] I see many changes related to diagnosis

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903387#comment-14903387 ] Varun Saxena commented on YARN-4000: [~jianhe] bq. actually, I think this will be a problem in regular

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14903400#comment-14903400 ] Varun Saxena commented on YARN-4000: bq. Is this the case? I think in current code, RM is still

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14901897#comment-14901897 ] Jian He commented on YARN-4000: --- bq. I think this shouldn't be a problem. actually, I think this will be a

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14901892#comment-14901892 ] Jian He commented on YARN-4000: --- bq. In recoverContainersOnNode, we check if application is present in the

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14901272#comment-14901272 ] Varun Saxena commented on YARN-4000: [~jianhe], I think this shouldn't be a problem. In

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14876958#comment-14876958 ] Jian He commented on YARN-4000: --- One more issue, there may be container leak. Depending on when NM

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14805317#comment-14805317 ] Varun Saxena commented on YARN-4000: [~jianhe], kindly review. Checkstyle is related to file length.

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14802698#comment-14802698 ] Jian He commented on YARN-4000: --- - is this if condition a typo ? {code} if

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14802738#comment-14802738 ] Varun Saxena commented on YARN-4000: bq. is this if condition a typo ? Yes. Had updated wrong patch.

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14791814#comment-14791814 ] Hadoop QA commented on YARN-4000: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14803015#comment-14803015 ] Hadoop QA commented on YARN-4000: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14746967#comment-14746967 ] Jian He commented on YARN-4000: --- I see, a few more comments: - QueueException -> QueueInvalidException - If

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14746985#comment-14746985 ] Varun Saxena commented on YARN-4000: [~jianhe], moreover there will be subclasses of RMAppEvent which

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14746999#comment-14746999 ] Jian He commented on YARN-4000: --- sounds good to me. thanks > RM crashes with NPE if leaf queue becomes

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14746997#comment-14746997 ] Jian He commented on YARN-4000: --- sounds good to me. thanks > RM crashes with NPE if leaf queue becomes

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14746998#comment-14746998 ] Jian He commented on YARN-4000: --- sounds good to me. thanks > RM crashes with NPE if leaf queue becomes

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14744884#comment-14744884 ] Jian He commented on YARN-4000: --- [~varun_saxena], thanks for working on the patch, some comments: - We may

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745242#comment-14745242 ] Varun Saxena commented on YARN-4000: Thanks [~jianhe] for the review. Regarding

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14745248#comment-14745248 ] Varun Saxena commented on YARN-4000: [~jianhe], actually there is a problem here.

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736772#comment-14736772 ] Varun Saxena commented on YARN-4000: Agree with using fail fast config. Although we should then use it

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736768#comment-14736768 ] Varun Saxena commented on YARN-4000: I meant in terms starting RM from scratch only. I mean the

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737113#comment-14737113 ] Varun Saxena commented on YARN-4000: Attached a patch with following changes : # If fail fast is false,

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737413#comment-14737413 ] Varun Saxena commented on YARN-4000: Updated a patch to fix checkstyle and whitespace issues. > RM

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737387#comment-14737387 ] Hadoop QA commented on YARN-4000: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737409#comment-14737409 ] Varun Saxena commented on YARN-4000: [~jlowe] / [~leftnoteasy], kindly review. > RM crashes with NPE

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737656#comment-14737656 ] Hadoop QA commented on YARN-4000: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680210#comment-14680210 ] Jason Lowe commented on YARN-4000: -- I don't believe changing a leaf queue into a parent

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680408#comment-14680408 ] Wangda Tan commented on YARN-4000: -- +1 to what [~jlowe]'s suggestion, we should kill app

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14680442#comment-14680442 ] Sunil G commented on YARN-4000: --- Agreeing for killing apps when fail-fast is false. Also as

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14662861#comment-14662861 ] Varun Saxena commented on YARN-4000: [~jlowe] / [~leftnoteasy], your thoughts on this ?

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14663081#comment-14663081 ] Karthik Kambatla commented on YARN-4000: We should use

[jira] [Commented] (YARN-4000) RM crashes with NPE if leaf queue becomes parent queue during restart

[ https://issues.apache.org/jira/browse/YARN-4000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14648416#comment-14648416 ] Jason Lowe commented on YARN-4000: -- Example stacktrace: {noformat} 2015-07-30 22:12:03,424