[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16973205#comment-16973205
]
zhoukang commented on YARN-9537:
Thanks [~yufeigu]
> Add configuration to disable AM preemption
>
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972667#comment-16972667
]
Hudson commented on YARN-9537:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17632 (See
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972654#comment-16972654
]
Yufei Gu commented on YARN-9537:
Committed to trunk. Thanks for the contribution, [~cane]. Thanks for the
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972075#comment-16972075
]
Yufei Gu commented on YARN-9537:
[~cane], Thanks for the patch. +1 for the patch 006. Will commit later.
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16972057#comment-16972057
]
Hadoop QA commented on YARN-9537:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971376#comment-16971376
]
Yufei Gu commented on YARN-9537:
Agreed with [~snemeth]. The production code shouldn't do the null
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971310#comment-16971310
]
Hadoop QA commented on YARN-9537:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16971279#comment-16971279
]
zhoukang commented on YARN-9537:
Thanks [~snemeth] I will remove ths first initialize.
And the null check
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970816#comment-16970816
]
Szilard Nemeth commented on YARN-9537:
--
Hi [~cane]!
Just a minor comment: In FSAppAttempt: Maybe
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16970053#comment-16970053
]
Hadoop QA commented on YARN-9537:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969933#comment-16969933
]
zhoukang commented on YARN-9537:
new patch added [~yufeigu]
> Add configuration to disable AM preemption
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969919#comment-16969919
]
zhoukang commented on YARN-9537:
nice catch [~yufeigu] Thanks.
I agree with you that may be queue level
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16969450#comment-16969450
]
Yufei Gu commented on YARN-9537:
Hi [~cane], sorry to come late. Patch 003 looks good to me overall. Just
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16968947#comment-16968947
]
zhoukang commented on YARN-9537:
[~tangzhankun] could you help review this？ thanks
> Add configuration to
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967534#comment-16967534
]
zhoukang commented on YARN-9537:
[~snemeth][~adam.antal] the style problem has been fixed. any more
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967533#comment-16967533
]
Hadoop QA commented on YARN-9537:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967165#comment-16967165
]
zhoukang commented on YARN-9537:
nice catch [~adam.antal] i ignored this style error.sorry. new patch on
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16966857#comment-16966857
]
Adam Antal commented on YARN-9537:
--
There's one last checkstyle issue but I give a +1 (non-binding) on
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16966705#comment-16966705
]
zhoukang commented on YARN-9537:
[~snemeth] Any more suggestion? Thanks
> Add configuration to disable AM
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957168#comment-16957168
]
Hadoop QA commented on YARN-9537:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957020#comment-16957020
]
zhoukang commented on YARN-9537:
A new patch has been attached [~snemeth]
> Add configuration to disable
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16956961#comment-16956961
]
zhoukang commented on YARN-9537:
Ok i will fix now!thanks [~snemeth]
> Add configuration to disable AM
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16951706#comment-16951706
]
Szilard Nemeth commented on YARN-9537:
--
Hi [~cane]!
Please check the unit test failures, from the
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950991#comment-16950991
]
Hadoop QA commented on YARN-9537:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950882#comment-16950882
]
zhoukang commented on YARN-9537:
ping [~tangzhankun] could you help review this feature?
> Add
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941036#comment-16941036
]
zhoukang commented on YARN-9537:
Ping [~yufeigu][~snemeth]
> Add configuration to disable AM preemption
>
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16935811#comment-16935811
]
zhoukang commented on YARN-9537:
[~yufeigu] could you help retest this patch?
> Add configuration to
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16925101#comment-16925101
]
zhoukang commented on YARN-9537:
Yes, i will. [~yufeigu]thanks a lot!
> Add configuration to disable AM
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16890572#comment-16890572
]
Yufei Gu commented on YARN-9537:
Hi [~cane], added you to contributor, and assign this to you. Will you
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868546#comment-16868546
]
zhoukang commented on YARN-9537:
In our production cluster, we have some problems when AM was preempted,
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865860#comment-16865860
]
Yufei Gu commented on YARN-9537:
Hi [~cane], thanks for the patch. Could you elaborate your use case?
>
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16859934#comment-16859934
]
Hadoop QA commented on YARN-9537:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-9537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16857293#comment-16857293
]
zhoukang commented on YARN-9537:
Thanks [~yufeigu] I have changed the title, we want to add configuration
33 matches
Mail list logo
