[jira] [Commented] (YARN-2117) Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed in finally block
[
https://issues.apache.org/jira/browse/YARN-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020783#comment-14020783
]
Hudson commented on YARN-2117:
--
FAILURE: Integrated in Hadoop-Yarn-trunk #576 (See
[https://builds.apache.org/job/Hadoop-Yarn-trunk/576/])
YARN-2117. Fixed the issue that secret file reader is potentially not closed in
TimelineAuthenticationFilterInitializer. Contributed by Chen He. (zjshen:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1600994)
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/security/TimelineAuthenticationFilterInitializer.java
Close of Reader in TimelineAuthenticationFilterInitializer#initFilter()
should be enclosed in finally block
---
Key: YARN-2117
URL: https://issues.apache.org/jira/browse/YARN-2117
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Ted Yu
Assignee: Chen He
Priority: Minor
Labels: newbie
Fix For: 2.5.0
Attachments: YARN-2117-v2.patch, YARN-2117.patch
Here is related code:
{code}
Reader reader = new FileReader(signatureSecretFile);
int c = reader.read();
while (c -1) {
secret.append((char) c);
c = reader.read();
}
reader.close();
{code}
If IOException is thrown out of reader.read(), reader would be left unclosed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-2117) Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed in finally block
[
https://issues.apache.org/jira/browse/YARN-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020811#comment-14020811
]
Hudson commented on YARN-2117:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk #1767 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1767/])
YARN-2117. Fixed the issue that secret file reader is potentially not closed in
TimelineAuthenticationFilterInitializer. Contributed by Chen He. (zjshen:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1600994)
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/security/TimelineAuthenticationFilterInitializer.java
Close of Reader in TimelineAuthenticationFilterInitializer#initFilter()
should be enclosed in finally block
---
Key: YARN-2117
URL: https://issues.apache.org/jira/browse/YARN-2117
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Ted Yu
Assignee: Chen He
Priority: Minor
Labels: newbie
Fix For: 2.5.0
Attachments: YARN-2117-v2.patch, YARN-2117.patch
Here is related code:
{code}
Reader reader = new FileReader(signatureSecretFile);
int c = reader.read();
while (c -1) {
secret.append((char) c);
c = reader.read();
}
reader.close();
{code}
If IOException is thrown out of reader.read(), reader would be left unclosed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-2117) Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed in finally block
[
https://issues.apache.org/jira/browse/YARN-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020836#comment-14020836
]
Hudson commented on YARN-2117:
--
FAILURE: Integrated in Hadoop-Mapreduce-trunk #1794 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1794/])
YARN-2117. Fixed the issue that secret file reader is potentially not closed in
TimelineAuthenticationFilterInitializer. Contributed by Chen He. (zjshen:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1600994)
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/security/TimelineAuthenticationFilterInitializer.java
Close of Reader in TimelineAuthenticationFilterInitializer#initFilter()
should be enclosed in finally block
---
Key: YARN-2117
URL: https://issues.apache.org/jira/browse/YARN-2117
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Ted Yu
Assignee: Chen He
Priority: Minor
Labels: newbie
Fix For: 2.5.0
Attachments: YARN-2117-v2.patch, YARN-2117.patch
Here is related code:
{code}
Reader reader = new FileReader(signatureSecretFile);
int c = reader.read();
while (c -1) {
secret.append((char) c);
c = reader.read();
}
reader.close();
{code}
If IOException is thrown out of reader.read(), reader would be left unclosed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-2117) Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed in finally block
[
https://issues.apache.org/jira/browse/YARN-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020038#comment-14020038
]
Zhijie Shen commented on YARN-2117:
---
[~airbots], thanks for the patch! Here're some comments:
1. Indent is breaking.
{code}
-throw new RuntimeException(
-Could not read HTTP signature secret file:
+ throw new RuntimeException(
+ Could not read HTTP signature secret file:
+ + signatureSecretFile)
{code}
2. You can use IOUtils to cleanup the closable objects.
Close of Reader in TimelineAuthenticationFilterInitializer#initFilter()
should be enclosed in finally block
---
Key: YARN-2117
URL: https://issues.apache.org/jira/browse/YARN-2117
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Ted Yu
Assignee: Chen He
Priority: Minor
Labels: newbie
Attachments: YARN-2117.patch
Here is related code:
{code}
Reader reader = new FileReader(signatureSecretFile);
int c = reader.read();
while (c -1) {
secret.append((char) c);
c = reader.read();
}
reader.close();
{code}
If IOException is thrown out of reader.read(), reader would be left unclosed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-2117) Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed in finally block
[
https://issues.apache.org/jira/browse/YARN-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020228#comment-14020228
]
Zhijie Shen commented on YARN-2117:
---
+1, will commit it upon jenkins.
Close of Reader in TimelineAuthenticationFilterInitializer#initFilter()
should be enclosed in finally block
---
Key: YARN-2117
URL: https://issues.apache.org/jira/browse/YARN-2117
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Ted Yu
Assignee: Chen He
Priority: Minor
Labels: newbie
Attachments: YARN-2117-v2.patch, YARN-2117.patch
Here is related code:
{code}
Reader reader = new FileReader(signatureSecretFile);
int c = reader.read();
while (c -1) {
secret.append((char) c);
c = reader.read();
}
reader.close();
{code}
If IOException is thrown out of reader.read(), reader would be left unclosed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-2117) Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed in finally block
[
https://issues.apache.org/jira/browse/YARN-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020266#comment-14020266
]
Hadoop QA commented on YARN-2117:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12648678/YARN-2117-v2.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3924//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3924//console
This message is automatically generated.
Close of Reader in TimelineAuthenticationFilterInitializer#initFilter()
should be enclosed in finally block
---
Key: YARN-2117
URL: https://issues.apache.org/jira/browse/YARN-2117
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Ted Yu
Assignee: Chen He
Priority: Minor
Labels: newbie
Attachments: YARN-2117-v2.patch, YARN-2117.patch
Here is related code:
{code}
Reader reader = new FileReader(signatureSecretFile);
int c = reader.read();
while (c -1) {
secret.append((char) c);
c = reader.read();
}
reader.close();
{code}
If IOException is thrown out of reader.read(), reader would be left unclosed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-2117) Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed in finally block
[
https://issues.apache.org/jira/browse/YARN-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020283#comment-14020283
]
Chen He commented on YARN-2117:
---
this patch does not need to introduce new test code.
Close of Reader in TimelineAuthenticationFilterInitializer#initFilter()
should be enclosed in finally block
---
Key: YARN-2117
URL: https://issues.apache.org/jira/browse/YARN-2117
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Ted Yu
Assignee: Chen He
Priority: Minor
Labels: newbie
Attachments: YARN-2117-v2.patch, YARN-2117.patch
Here is related code:
{code}
Reader reader = new FileReader(signatureSecretFile);
int c = reader.read();
while (c -1) {
secret.append((char) c);
c = reader.read();
}
reader.close();
{code}
If IOException is thrown out of reader.read(), reader would be left unclosed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-2117) Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed in finally block
[
https://issues.apache.org/jira/browse/YARN-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14020314#comment-14020314
]
Hudson commented on YARN-2117:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #5658 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/5658/])
YARN-2117. Fixed the issue that secret file reader is potentially not closed in
TimelineAuthenticationFilterInitializer. Contributed by Chen He. (zjshen:
http://svn.apache.org/viewcvs.cgi/?root=Apache-SVNview=revrev=1600994)
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
*
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice/src/main/java/org/apache/hadoop/yarn/server/timeline/security/TimelineAuthenticationFilterInitializer.java
Close of Reader in TimelineAuthenticationFilterInitializer#initFilter()
should be enclosed in finally block
---
Key: YARN-2117
URL: https://issues.apache.org/jira/browse/YARN-2117
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Ted Yu
Assignee: Chen He
Priority: Minor
Labels: newbie
Fix For: 2.5.0
Attachments: YARN-2117-v2.patch, YARN-2117.patch
Here is related code:
{code}
Reader reader = new FileReader(signatureSecretFile);
int c = reader.read();
while (c -1) {
secret.append((char) c);
c = reader.read();
}
reader.close();
{code}
If IOException is thrown out of reader.read(), reader would be left unclosed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-2117) Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed in finally block
[
https://issues.apache.org/jira/browse/YARN-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14015429#comment-14015429
]
Hadoop QA commented on YARN-2117:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12647900/YARN-2117.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-applicationhistoryservice.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-YARN-Build/3885//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3885//console
This message is automatically generated.
Close of Reader in TimelineAuthenticationFilterInitializer#initFilter()
should be enclosed in finally block
---
Key: YARN-2117
URL: https://issues.apache.org/jira/browse/YARN-2117
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Ted Yu
Assignee: Chen He
Priority: Minor
Labels: newbie
Attachments: YARN-2117.patch
Here is related code:
{code}
Reader reader = new FileReader(signatureSecretFile);
int c = reader.read();
while (c -1) {
secret.append((char) c);
c = reader.read();
}
reader.close();
{code}
If IOException is thrown out of reader.read(), reader would be left unclosed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-2117) Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed in finally block
[
https://issues.apache.org/jira/browse/YARN-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14015113#comment-14015113
]
Hadoop QA commented on YARN-2117:
-
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12647835/YARN-2117.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:red}-1 javac{color:red}. The patch appears to cause the build to
fail.
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3883//console
This message is automatically generated.
Close of Reader in TimelineAuthenticationFilterInitializer#initFilter()
should be enclosed in finally block
---
Key: YARN-2117
URL: https://issues.apache.org/jira/browse/YARN-2117
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Ted Yu
Assignee: Chen He
Priority: Minor
Labels: newbie
Attachments: YARN-2117.patch
Here is related code:
{code}
Reader reader = new FileReader(signatureSecretFile);
int c = reader.read();
while (c -1) {
secret.append((char) c);
c = reader.read();
}
reader.close();
{code}
If IOException is thrown out of reader.read(), reader would be left unclosed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Commented] (YARN-2117) Close of Reader in TimelineAuthenticationFilterInitializer#initFilter() should be enclosed in finally block
[
https://issues.apache.org/jira/browse/YARN-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14015115#comment-14015115
]
Chen He commented on YARN-2117:
---
This change does not need include unit test.
Close of Reader in TimelineAuthenticationFilterInitializer#initFilter()
should be enclosed in finally block
---
Key: YARN-2117
URL: https://issues.apache.org/jira/browse/YARN-2117
Project: Hadoop YARN
Issue Type: Sub-task
Reporter: Ted Yu
Assignee: Chen He
Priority: Minor
Labels: newbie
Attachments: YARN-2117.patch
Here is related code:
{code}
Reader reader = new FileReader(signatureSecretFile);
int c = reader.read();
while (c -1) {
secret.append((char) c);
c = reader.read();
}
reader.close();
{code}
If IOException is thrown out of reader.read(), reader would be left unclosed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
