[jira] [Commented] (YARN-2119) Fix the DEFAULT_PROXY_ADDRESS used for getBindAddress to fix 1590

2014-06-02 Thread Hadoop QA (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14015763#comment-14015763
 ] 

Hadoop QA commented on YARN-2119:
-

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12647959/YARN-2119.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-api 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/3888//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3888//console

This message is automatically generated.

 Fix the DEFAULT_PROXY_ADDRESS used for getBindAddress to fix 1590
 -

 Key: YARN-2119
 URL: https://issues.apache.org/jira/browse/YARN-2119
 Project: Hadoop YARN
  Issue Type: Bug
Reporter: Anubhav Dhoot
Assignee: Anubhav Dhoot
 Attachments: YARN-2119.patch


 The fix for [YARN-1590|https://issues.apache.org/jira/browse/YARN-1590] 
 introduced an method to get web proxy bind address with the incorrect default 
 port. Because all the users of the method (only 1 user) ignores the port, its 
 not breaking anything yet. Fixing it in case someone else uses this in the 
 future. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)


[jira] [Commented] (YARN-2119) Fix the DEFAULT_PROXY_ADDRESS used for getBindAddress to fix 1590

2014-06-02 Thread Karthik Kambatla (JIRA)

[ 
https://issues.apache.org/jira/browse/YARN-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14015866#comment-14015866
 ] 

Karthik Kambatla commented on YARN-2119:


Looks good to me. +1. 

I ll commit this in a day if no one else has any comments. 

 Fix the DEFAULT_PROXY_ADDRESS used for getBindAddress to fix 1590
 -

 Key: YARN-2119
 URL: https://issues.apache.org/jira/browse/YARN-2119
 Project: Hadoop YARN
  Issue Type: Bug
Reporter: Anubhav Dhoot
Assignee: Anubhav Dhoot
 Attachments: YARN-2119.patch


 The fix for [YARN-1590|https://issues.apache.org/jira/browse/YARN-1590] 
 introduced an method to get web proxy bind address with the incorrect default 
 port. Because all the users of the method (only 1 user) ignores the port, its 
 not breaking anything yet. Fixing it in case someone else uses this in the 
 future. 



--
This message was sent by Atlassian JIRA
(v6.2#6252)