[jira] [Commented] (YARN-2771) DistributedShell's DSConstants are badly named

2014-10-30 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14189724#comment-14189724
 ] 

Hadoop QA commented on YARN-2771:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12678058/YARN-2771.1.patch
  against trunk revision 0126cf1.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/5638//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5638//console

This message is automatically generated.

 DistributedShell's DSConstants are badly named
 --

 Key: YARN-2771
 URL: https://issues.apache.org/jira/browse/YARN-2771
 Project: Hadoop YARN
  Issue Type: Bug
  Components: applications/distributed-shell
Reporter: Vinod Kumar Vavilapalli
Assignee: Zhijie Shen
 Attachments: YARN-2771.1.patch


 I'd rather have underscores (DISTRIBUTED_SHELL_TIMELINE_DOMAIN instead of 
 DISTRIBUTEDSHELLTIMELINEDOMAIN).
 DISTRIBUTEDSHELLTIMELINEDOMAIN is added in this release, can we rename it to 
 be DISTRIBUTED_SHELL_TIMELINE_DOMAIN?
 For the old envs, we can just add new envs that point to the old-one and 
 deprecate the old ones.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-2771) DistributedShell's DSConstants are badly named

2014-10-30 Thread Zhijie Shen (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14190430#comment-14190430
 ] 

Zhijie Shen commented on YARN-2771:
---

Constant name changes. No need for test case.

 DistributedShell's DSConstants are badly named
 --

 Key: YARN-2771
 URL: https://issues.apache.org/jira/browse/YARN-2771
 Project: Hadoop YARN
  Issue Type: Bug
  Components: applications/distributed-shell
Reporter: Vinod Kumar Vavilapalli
Assignee: Zhijie Shen
 Attachments: YARN-2771.1.patch


 I'd rather have underscores (DISTRIBUTED_SHELL_TIMELINE_DOMAIN instead of 
 DISTRIBUTEDSHELLTIMELINEDOMAIN).
 DISTRIBUTEDSHELLTIMELINEDOMAIN is added in this release, can we rename it to 
 be DISTRIBUTED_SHELL_TIMELINE_DOMAIN?
 For the old envs, we can just add new envs that point to the old-one and 
 deprecate the old ones.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-2771) DistributedShell's DSConstants are badly named

2014-10-30 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14190685#comment-14190685
 ] 

Hadoop QA commented on YARN-2771:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12678276/YARN-2771.2.patch
  against trunk revision c2866ac.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:red}-1 core tests{color}.  The patch failed these unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell:

  
org.apache.hadoop.yarn.applications.distributedshell.TestDistributedShell

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/5642//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5642//console

This message is automatically generated.

 DistributedShell's DSConstants are badly named
 --

 Key: YARN-2771
 URL: https://issues.apache.org/jira/browse/YARN-2771
 Project: Hadoop YARN
  Issue Type: Bug
  Components: applications/distributed-shell
Reporter: Vinod Kumar Vavilapalli
Assignee: Zhijie Shen
 Attachments: YARN-2771.1.patch, YARN-2771.2.patch


 I'd rather have underscores (DISTRIBUTED_SHELL_TIMELINE_DOMAIN instead of 
 DISTRIBUTEDSHELLTIMELINEDOMAIN).
 DISTRIBUTEDSHELLTIMELINEDOMAIN is added in this release, can we rename it to 
 be DISTRIBUTED_SHELL_TIMELINE_DOMAIN?
 For the old envs, we can just add new envs that point to the old-one and 
 deprecate the old ones.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (YARN-2771) DistributedShell's DSConstants are badly named

2014-10-30 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14191089#comment-14191089
 ] 

Hadoop QA commented on YARN-2771:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12678350/YARN-2771.3.patch
  against trunk revision 81fe8e4.

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-distributedshell.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/5645//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5645//console

This message is automatically generated.

 DistributedShell's DSConstants are badly named
 --

 Key: YARN-2771
 URL: https://issues.apache.org/jira/browse/YARN-2771
 Project: Hadoop YARN
  Issue Type: Bug
  Components: applications/distributed-shell
Reporter: Vinod Kumar Vavilapalli
Assignee: Zhijie Shen
 Attachments: YARN-2771.1.patch, YARN-2771.2.patch, YARN-2771.3.patch


 I'd rather have underscores (DISTRIBUTED_SHELL_TIMELINE_DOMAIN instead of 
 DISTRIBUTEDSHELLTIMELINEDOMAIN).
 DISTRIBUTEDSHELLTIMELINEDOMAIN is added in this release, can we rename it to 
 be DISTRIBUTED_SHELL_TIMELINE_DOMAIN?
 For the old envs, we can just add new envs that point to the old-one and 
 deprecate the old ones.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)