[jira] [Commented] (YARN-3770) SerializedException should also handle java.lang.Error
[
https://issues.apache.org/jira/browse/YARN-3770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14610320#comment-14610320
]
Hudson commented on YARN-3770:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk #2172 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/2172/])
YARN-3770. SerializedException should also handle java.lang.Error on
de-serialization. Contributed by Lavkesh Lahngir (jianhe: rev
4672315e2d6abe1cee0210cf7d3e8ab114ba933c)
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/SerializedExceptionPBImpl.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/api/records/impl/pb/TestSerializedExceptionPBImpl.java
SerializedException should also handle java.lang.Error
---
Key: YARN-3770
URL: https://issues.apache.org/jira/browse/YARN-3770
Project: Hadoop YARN
Issue Type: Bug
Reporter: Lavkesh Lahngir
Assignee: Lavkesh Lahngir
Fix For: 2.8.0
Attachments: YARN-3770.1.patch, YARN-3770.patch
IN SerializedExceptionPBImpl deserialize() method
{code}
Class classType = null;
if (YarnException.class.isAssignableFrom(realClass)) {
classType = YarnException.class;
} else if (IOException.class.isAssignableFrom(realClass)) {
classType = IOException.class;
} else if (RuntimeException.class.isAssignableFrom(realClass)) {
classType = RuntimeException.class;
} else {
classType = Exception.class;
}
return instantiateException(realClass.asSubclass(classType), getMessage(),
cause == null ? null : cause.deSerialize());
}
{code}
if realClass is a subclass of java.lang.Error deSerialize() throws
ClassCastException.
in the last else statement classType should be equal to Trowable.class
instead of Exception.class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3770) SerializedException should also handle java.lang.Error
[
https://issues.apache.org/jira/browse/YARN-3770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14610362#comment-14610362
]
Hudson commented on YARN-3770:
--
FAILURE: Integrated in Hadoop-Hdfs-trunk-Java8 #233 (See
[https://builds.apache.org/job/Hadoop-Hdfs-trunk-Java8/233/])
YARN-3770. SerializedException should also handle java.lang.Error on
de-serialization. Contributed by Lavkesh Lahngir (jianhe: rev
4672315e2d6abe1cee0210cf7d3e8ab114ba933c)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/SerializedExceptionPBImpl.java
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/api/records/impl/pb/TestSerializedExceptionPBImpl.java
SerializedException should also handle java.lang.Error
---
Key: YARN-3770
URL: https://issues.apache.org/jira/browse/YARN-3770
Project: Hadoop YARN
Issue Type: Bug
Reporter: Lavkesh Lahngir
Assignee: Lavkesh Lahngir
Fix For: 2.8.0
Attachments: YARN-3770.1.patch, YARN-3770.patch
IN SerializedExceptionPBImpl deserialize() method
{code}
Class classType = null;
if (YarnException.class.isAssignableFrom(realClass)) {
classType = YarnException.class;
} else if (IOException.class.isAssignableFrom(realClass)) {
classType = IOException.class;
} else if (RuntimeException.class.isAssignableFrom(realClass)) {
classType = RuntimeException.class;
} else {
classType = Exception.class;
}
return instantiateException(realClass.asSubclass(classType), getMessage(),
cause == null ? null : cause.deSerialize());
}
{code}
if realClass is a subclass of java.lang.Error deSerialize() throws
ClassCastException.
in the last else statement classType should be equal to Trowable.class
instead of Exception.class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3770) SerializedException should also handle java.lang.Error
[
https://issues.apache.org/jira/browse/YARN-3770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608529#comment-14608529
]
Hudson commented on YARN-3770:
--
SUCCESS: Integrated in Hadoop-Mapreduce-trunk #2190 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/2190/])
YARN-3770. SerializedException should also handle java.lang.Error on
de-serialization. Contributed by Lavkesh Lahngir (jianhe: rev
4672315e2d6abe1cee0210cf7d3e8ab114ba933c)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/api/records/impl/pb/TestSerializedExceptionPBImpl.java
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/SerializedExceptionPBImpl.java
SerializedException should also handle java.lang.Error
---
Key: YARN-3770
URL: https://issues.apache.org/jira/browse/YARN-3770
Project: Hadoop YARN
Issue Type: Bug
Reporter: Lavkesh Lahngir
Assignee: Lavkesh Lahngir
Fix For: 2.8.0
Attachments: YARN-3770.1.patch, YARN-3770.patch
IN SerializedExceptionPBImpl deserialize() method
{code}
Class classType = null;
if (YarnException.class.isAssignableFrom(realClass)) {
classType = YarnException.class;
} else if (IOException.class.isAssignableFrom(realClass)) {
classType = IOException.class;
} else if (RuntimeException.class.isAssignableFrom(realClass)) {
classType = RuntimeException.class;
} else {
classType = Exception.class;
}
return instantiateException(realClass.asSubclass(classType), getMessage(),
cause == null ? null : cause.deSerialize());
}
{code}
if realClass is a subclass of java.lang.Error deSerialize() throws
ClassCastException.
in the last else statement classType should be equal to Trowable.class
instead of Exception.class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3770) SerializedException should also handle java.lang.Error
[
https://issues.apache.org/jira/browse/YARN-3770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608473#comment-14608473
]
Hudson commented on YARN-3770:
--
SUCCESS: Integrated in Hadoop-Mapreduce-trunk-Java8 #242 (See
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Java8/242/])
YARN-3770. SerializedException should also handle java.lang.Error on
de-serialization. Contributed by Lavkesh Lahngir (jianhe: rev
4672315e2d6abe1cee0210cf7d3e8ab114ba933c)
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/api/records/impl/pb/TestSerializedExceptionPBImpl.java
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/SerializedExceptionPBImpl.java
SerializedException should also handle java.lang.Error
---
Key: YARN-3770
URL: https://issues.apache.org/jira/browse/YARN-3770
Project: Hadoop YARN
Issue Type: Bug
Reporter: Lavkesh Lahngir
Assignee: Lavkesh Lahngir
Fix For: 2.8.0
Attachments: YARN-3770.1.patch, YARN-3770.patch
IN SerializedExceptionPBImpl deserialize() method
{code}
Class classType = null;
if (YarnException.class.isAssignableFrom(realClass)) {
classType = YarnException.class;
} else if (IOException.class.isAssignableFrom(realClass)) {
classType = IOException.class;
} else if (RuntimeException.class.isAssignableFrom(realClass)) {
classType = RuntimeException.class;
} else {
classType = Exception.class;
}
return instantiateException(realClass.asSubclass(classType), getMessage(),
cause == null ? null : cause.deSerialize());
}
{code}
if realClass is a subclass of java.lang.Error deSerialize() throws
ClassCastException.
in the last else statement classType should be equal to Trowable.class
instead of Exception.class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3770) SerializedException should also handle java.lang.Error
[
https://issues.apache.org/jira/browse/YARN-3770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14606498#comment-14606498
]
Hudson commented on YARN-3770:
--
FAILURE: Integrated in Hadoop-trunk-Commit #8089 (See
[https://builds.apache.org/job/Hadoop-trunk-Commit/8089/])
YARN-3770. SerializedException should also handle java.lang.Error on
de-serialization. Contributed by Lavkesh Lahngir (jianhe: rev
4672315e2d6abe1cee0210cf7d3e8ab114ba933c)
* hadoop-yarn-project/CHANGES.txt
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/api/records/impl/pb/TestSerializedExceptionPBImpl.java
*
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/api/records/impl/pb/SerializedExceptionPBImpl.java
SerializedException should also handle java.lang.Error
---
Key: YARN-3770
URL: https://issues.apache.org/jira/browse/YARN-3770
Project: Hadoop YARN
Issue Type: Bug
Reporter: Lavkesh Lahngir
Assignee: Lavkesh Lahngir
Fix For: 2.8.0
Attachments: YARN-3770.1.patch, YARN-3770.patch
IN SerializedExceptionPBImpl deserialize() method
{code}
Class classType = null;
if (YarnException.class.isAssignableFrom(realClass)) {
classType = YarnException.class;
} else if (IOException.class.isAssignableFrom(realClass)) {
classType = IOException.class;
} else if (RuntimeException.class.isAssignableFrom(realClass)) {
classType = RuntimeException.class;
} else {
classType = Exception.class;
}
return instantiateException(realClass.asSubclass(classType), getMessage(),
cause == null ? null : cause.deSerialize());
}
{code}
if realClass is a subclass of java.lang.Error deSerialize() throws
ClassCastException.
in the last else statement classType should be equal to Trowable.class
instead of Exception.class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3770) SerializedException should also handle java.lang.Error
[
https://issues.apache.org/jira/browse/YARN-3770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14606441#comment-14606441
]
Jian He commented on YARN-3770:
---
+1
SerializedException should also handle java.lang.Error
---
Key: YARN-3770
URL: https://issues.apache.org/jira/browse/YARN-3770
Project: Hadoop YARN
Issue Type: Bug
Reporter: Lavkesh Lahngir
Assignee: Lavkesh Lahngir
Attachments: YARN-3770.1.patch, YARN-3770.patch
IN SerializedExceptionPBImpl deserialize() method
{code}
Class classType = null;
if (YarnException.class.isAssignableFrom(realClass)) {
classType = YarnException.class;
} else if (IOException.class.isAssignableFrom(realClass)) {
classType = IOException.class;
} else if (RuntimeException.class.isAssignableFrom(realClass)) {
classType = RuntimeException.class;
} else {
classType = Exception.class;
}
return instantiateException(realClass.asSubclass(classType), getMessage(),
cause == null ? null : cause.deSerialize());
}
{code}
if realClass is a subclass of java.lang.Error deSerialize() throws
ClassCastException.
in the last else statement classType should be equal to Trowable.class
instead of Exception.class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3770) SerializedException should also handle java.lang.Error
[
https://issues.apache.org/jira/browse/YARN-3770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14582968#comment-14582968
]
Amareshwari Sriramadasu commented on YARN-3770:
---
+1 for patch. Changes look good.
SerializedException should also handle java.lang.Error
---
Key: YARN-3770
URL: https://issues.apache.org/jira/browse/YARN-3770
Project: Hadoop YARN
Issue Type: Bug
Reporter: Lavkesh Lahngir
Assignee: Lavkesh Lahngir
Attachments: YARN-3770.1.patch, YARN-3770.patch
IN SerializedExceptionPBImpl deserialize() method
{code}
Class classType = null;
if (YarnException.class.isAssignableFrom(realClass)) {
classType = YarnException.class;
} else if (IOException.class.isAssignableFrom(realClass)) {
classType = IOException.class;
} else if (RuntimeException.class.isAssignableFrom(realClass)) {
classType = RuntimeException.class;
} else {
classType = Exception.class;
}
return instantiateException(realClass.asSubclass(classType), getMessage(),
cause == null ? null : cause.deSerialize());
}
{code}
if realClass is a subclass of java.lang.Error deSerialize() throws
ClassCastException.
in the last else statement classType should be equal to Trowable.class
instead of Exception.class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3770) SerializedException should also handle java.lang.Error
[
https://issues.apache.org/jira/browse/YARN-3770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14577245#comment-14577245
]
Hadoop QA commented on YARN-3770:
-
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 16m 35s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 58s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 52s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 22s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 52s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 34s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 32s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 39s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests | 1m 59s | Tests passed in
hadoop-yarn-common. |
| | | 41m 26s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12738350/YARN-3770.1.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 18f6809 |
| hadoop-yarn-common test log |
https://builds.apache.org/job/PreCommit-YARN-Build/8218/artifact/patchprocess/testrun_hadoop-yarn-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/8218/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/8218/console |
This message was automatically generated.
SerializedException should also handle java.lang.Error
---
Key: YARN-3770
URL: https://issues.apache.org/jira/browse/YARN-3770
Project: Hadoop YARN
Issue Type: Bug
Reporter: Lavkesh Lahngir
Assignee: Lavkesh Lahngir
Attachments: YARN-3770.1.patch, YARN-3770.patch
IN SerializedExceptionPBImpl deserialize() method
{code}
Class classType = null;
if (YarnException.class.isAssignableFrom(realClass)) {
classType = YarnException.class;
} else if (IOException.class.isAssignableFrom(realClass)) {
classType = IOException.class;
} else if (RuntimeException.class.isAssignableFrom(realClass)) {
classType = RuntimeException.class;
} else {
classType = Exception.class;
}
return instantiateException(realClass.asSubclass(classType), getMessage(),
cause == null ? null : cause.deSerialize());
}
{code}
if realClass is a subclass of java.lang.Error deSerialize() throws
ClassCastException.
in the last else statement classType should be equal to Trowable.class
instead of Exception.class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3770) SerializedException should also handle java.lang.Error
[
https://issues.apache.org/jira/browse/YARN-3770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14574439#comment-14574439
]
Hadoop QA commented on YARN-3770:
-
\\
\\
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 16m 1s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:green}+1{color} | tests included | 0m 0s | The patch appears to
include 1 new or modified test files. |
| {color:green}+1{color} | javac | 7m 22s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 9m 45s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 52s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 31s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 31s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests | 1m 55s | Tests passed in
hadoop-yarn-common. |
| | | 39m 58s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12737919/YARN-3770.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 790a861 |
| hadoop-yarn-common test log |
https://builds.apache.org/job/PreCommit-YARN-Build/8197/artifact/patchprocess/testrun_hadoop-yarn-common.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/8197/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf908.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/8197/console |
This message was automatically generated.
SerializedException should also handle java.lang.Error
---
Key: YARN-3770
URL: https://issues.apache.org/jira/browse/YARN-3770
Project: Hadoop YARN
Issue Type: Bug
Reporter: Lavkesh Lahngir
Assignee: Lavkesh Lahngir
Attachments: YARN-3770.patch
IN SerializedExceptionPBImpl deserialize() method
{code}
Class classType = null;
if (YarnException.class.isAssignableFrom(realClass)) {
classType = YarnException.class;
} else if (IOException.class.isAssignableFrom(realClass)) {
classType = IOException.class;
} else if (RuntimeException.class.isAssignableFrom(realClass)) {
classType = RuntimeException.class;
} else {
classType = Exception.class;
}
return instantiateException(realClass.asSubclass(classType), getMessage(),
cause == null ? null : cause.deSerialize());
}
{code}
if realClass is a subclass of java.lang.Error deSerialize() throws
ClassCastException.
in the last else statement classType should be equal to Trowable.class
instead of Exception.class.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
