[
https://issues.apache.org/jira/browse/YARN-4409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15369823#comment-15369823
]
Hudson commented on YARN-4409:
--
SUCCESS: Integrated in Hadoop-trunk-Commit #10074 (See
[
https://issues.apache.org/jira/browse/YARN-4409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15139669#comment-15139669
]
Varun Saxena commented on YARN-4409:
Thanks [~sjlee0] for the commit.
> Fix javadoc and checkstyle
[
https://issues.apache.org/jira/browse/YARN-4409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15137462#comment-15137462
]
Sangjin Lee commented on YARN-4409:
---
The latest patch LGTM. I checked timelineservice manually.
I'll
[
https://issues.apache.org/jira/browse/YARN-4409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136184#comment-15136184
]
Hadoop QA commented on YARN-4409:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136008#comment-15136008
]
Varun Saxena commented on YARN-4409:
[~sjlee0], kindly review the latest patch.
The build timed out on
[
https://issues.apache.org/jira/browse/YARN-4409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15136068#comment-15136068
]
Hadoop QA commented on YARN-4409:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134696#comment-15134696
]
Varun Saxena commented on YARN-4409:
That can be fixed. Its newly added code in v2.
> Fix javadoc and
[
https://issues.apache.org/jira/browse/YARN-4409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134261#comment-15134261
]
Varun Saxena commented on YARN-4409:
javadoc seems to be fine.
Should we fix checkstyle issue in
[
https://issues.apache.org/jira/browse/YARN-4409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135409#comment-15135409
]
Sangjin Lee commented on YARN-4409:
---
The checkstyle error for JobHistoryEventHandler.java:138 seems
[
https://issues.apache.org/jira/browse/YARN-4409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135405#comment-15135405
]
Hadoop QA commented on YARN-4409:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135620#comment-15135620
]
Varun Saxena commented on YARN-4409:
Yes it is relevant and fixable. Will fix it.
> Fix javadoc and
[
https://issues.apache.org/jira/browse/YARN-4409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133315#comment-15133315
]
Sangjin Lee commented on YARN-4409:
---
I meant "no javadoc errors or findbugs errors from our code with
[
https://issues.apache.org/jira/browse/YARN-4409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133281#comment-15133281
]
Sangjin Lee commented on YARN-4409:
---
I'm not sure what the status of the jenkins result is, but I see the
[
https://issues.apache.org/jira/browse/YARN-4409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15133778#comment-15133778
]
Varun Saxena commented on YARN-4409:
Yes.
For javadoc too, it will show just first 100 warnings.
Do
[
https://issues.apache.org/jira/browse/YARN-4409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132328#comment-15132328
]
Hadoop QA commented on YARN-4409:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132747#comment-15132747
]
Hadoop QA commented on YARN-4409:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132753#comment-15132753
]
Hadoop QA commented on YARN-4409:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131893#comment-15131893
]
Varun Saxena commented on YARN-4409:
It seems javadoc for hadoop-yarn-server-timelineservice was not
[
https://issues.apache.org/jira/browse/YARN-4409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131464#comment-15131464
]
Sangjin Lee commented on YARN-4409:
---
Hi [~varun_saxena], could you refresh this patch to apply cleanly on
[
https://issues.apache.org/jira/browse/YARN-4409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131568#comment-15131568
]
Varun Saxena commented on YARN-4409:
Yes, will do so.
I have the patch ready.
> Fix javadoc and
[
https://issues.apache.org/jira/browse/YARN-4409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131866#comment-15131866
]
Hadoop QA commented on YARN-4409:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15124962#comment-15124962
]
Varun Saxena commented on YARN-4409:
This patch is on top of YARN-4446
> Fix javadoc and checkstyle
22 matches
Mail list logo
