[
https://issues.apache.org/jira/browse/YARN-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15189697#comment-15189697
]
Li Lu commented on YARN-4696:
-
I'll commit this patch shortly.
> EntityGroupFSTimelineStore to work in the
[
https://issues.apache.org/jira/browse/YARN-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15188392#comment-15188392
]
Li Lu commented on YARN-4696:
-
Last patch LGTM. I believe that a volatile boolean would also do the work of
[
https://issues.apache.org/jira/browse/YARN-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15188127#comment-15188127
]
Hadoop QA commented on YARN-4696:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186090#comment-15186090
]
Hadoop QA commented on YARN-4696:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15185680#comment-15185680
]
Steve Loughran commented on YARN-4696:
--
hi, I'll reply to these later; the current patches don't
[
https://issues.apache.org/jira/browse/YARN-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15185261#comment-15185261
]
Steve Loughran commented on YARN-4696:
--
BTW, I managed to create an exception in scale tests; when the
[
https://issues.apache.org/jira/browse/YARN-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15183990#comment-15183990
]
Li Lu commented on YARN-4696:
-
Reformatting the previous comment:
FileSystemTimelineWriter.java
-
[
https://issues.apache.org/jira/browse/YARN-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15183986#comment-15183986
]
Li Lu commented on YARN-4696:
-
Thanks [~ste...@apache.org] for the work! Mostly LGTM, only a few nits:
[
https://issues.apache.org/jira/browse/YARN-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15183401#comment-15183401
]
Steve Loughran commented on YARN-4696:
--
ignore the comment about numbers for now, something
[
https://issues.apache.org/jira/browse/YARN-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15183235#comment-15183235
]
Steve Loughran commented on YARN-4696:
--
I should add that now I've started with some scale tests, my
[
https://issues.apache.org/jira/browse/YARN-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15175578#comment-15175578
]
Steve Loughran commented on YARN-4696:
--
Findbugs is in code to determine scheme. It's correct; this is
[
https://issues.apache.org/jira/browse/YARN-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15173824#comment-15173824
]
Hadoop QA commented on YARN-4696:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15172800#comment-15172800
]
Hadoop QA commented on YARN-4696:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163307#comment-15163307
]
Hadoop QA commented on YARN-4696:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163273#comment-15163273
]
Hadoop QA commented on YARN-4696:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157474#comment-15157474
]
Hadoop QA commented on YARN-4696:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157187#comment-15157187
]
Steve Loughran commented on YARN-4696:
--
the next patch I put up will implement YARN-4716; you can use
[
https://issues.apache.org/jira/browse/YARN-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154989#comment-15154989
]
Steve Loughran commented on YARN-4696:
--
This is another iteration with some other things needed to
[
https://issues.apache.org/jira/browse/YARN-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15152923#comment-15152923
]
Li Lu commented on YARN-4696:
-
Thanks [~ste...@apache.org]! The latest patch LGTM. Could some committers have
[
https://issues.apache.org/jira/browse/YARN-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15152656#comment-15152656
]
Steve Loughran commented on YARN-4696:
--
Patch -003. Adds more robustness/diagnostics to the plugin
[
https://issues.apache.org/jira/browse/YARN-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15152271#comment-15152271
]
Hadoop QA commented on YARN-4696:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15152148#comment-15152148
]
Steve Loughran commented on YARN-4696:
--
# forgot about the -default.xml; will fix
# anyone overrriding
[
https://issues.apache.org/jira/browse/YARN-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151422#comment-15151422
]
Li Lu commented on YARN-4696:
-
Thanks [~ste...@apache.org]! This new override based solution works better
[
https://issues.apache.org/jira/browse/YARN-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15151085#comment-15151085
]
Hadoop QA commented on YARN-4696:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15150557#comment-15150557
]
Steve Loughran commented on YARN-4696:
--
It is for testing: the previous ATS ran happily standalone,
[
https://issues.apache.org/jira/browse/YARN-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15149562#comment-15149562
]
Li Lu commented on YARN-4696:
-
Thanks for the work [~ste...@apache.org]! My main question is that what is the
[
https://issues.apache.org/jira/browse/YARN-4696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15148995#comment-15148995
]
Hadoop QA commented on YARN-4696:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
27 matches
Mail list logo