[
https://issues.apache.org/jira/browse/YARN-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15194316#comment-15194316
]
Hudson commented on YARN-4719:
--
FAILURE: Integrated in Hadoop-trunk-Commit #9460 (See
[
https://issues.apache.org/jira/browse/YARN-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15193857#comment-15193857
]
Wangda Tan commented on YARN-4719:
--
+1, thanks [~kasha].
> Add a helper library to maintain node state
[
https://issues.apache.org/jira/browse/YARN-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192123#comment-15192123
]
Karthik Kambatla commented on YARN-4719:
The checkstyle warnings are innocuous, and the test
[
https://issues.apache.org/jira/browse/YARN-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15192119#comment-15192119
]
Hadoop QA commented on YARN-4719:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191839#comment-15191839
]
Hadoop QA commented on YARN-4719:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191596#comment-15191596
]
Karthik Kambatla commented on YARN-4719:
bq. Can we make ClusterNodeTracker an interface and make
[
https://issues.apache.org/jira/browse/YARN-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191351#comment-15191351
]
Wangda Tan commented on YARN-4719:
--
Looks good to me in general, +1
One nit: CS#reintializeQueues:
[
https://issues.apache.org/jira/browse/YARN-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15191326#comment-15191326
]
Arun Suresh commented on YARN-4719:
---
Can we make {{ClusterNodeTracker}} an interface and make the current
[
https://issues.apache.org/jira/browse/YARN-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15186618#comment-15186618
]
Hadoop QA commented on YARN-4719:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15185411#comment-15185411
]
Hadoop QA commented on YARN-4719:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15185059#comment-15185059
]
Hadoop QA commented on YARN-4719:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15185037#comment-15185037
]
Hadoop QA commented on YARN-4719:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15183328#comment-15183328
]
Karthik Kambatla commented on YARN-4719:
Oh, and when the NodeFilter is null or an "IdentityFilter"
[
https://issues.apache.org/jira/browse/YARN-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15183324#comment-15183324
]
Karthik Kambatla commented on YARN-4719:
bq. I may not understand about this, could you elaborate?
[
https://issues.apache.org/jira/browse/YARN-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15182591#comment-15182591
]
Wangda Tan commented on YARN-4719:
--
Hi [~kasha],
bq. through addNode and removeNode so
[
https://issues.apache.org/jira/browse/YARN-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176644#comment-15176644
]
Karthik Kambatla commented on YARN-4719:
[~leftnoteasy] - thanks for chiming in, you make some
[
https://issues.apache.org/jira/browse/YARN-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176555#comment-15176555
]
Hadoop QA commented on YARN-4719:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176278#comment-15176278
]
Wangda Tan commented on YARN-4719:
--
[~kasha],
bq. Not sure I understand the suggestion. Elaborate?
In
[
https://issues.apache.org/jira/browse/YARN-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176248#comment-15176248
]
Karthik Kambatla commented on YARN-4719:
[~rkanter] - this code touches the adaptive max allocation
[
https://issues.apache.org/jira/browse/YARN-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15174594#comment-15174594
]
Karthik Kambatla commented on YARN-4719:
bq. For ClusterNodeTracker#nodes, can we use lock-free
[
https://issues.apache.org/jira/browse/YARN-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15173319#comment-15173319
]
Wangda Tan commented on YARN-4719:
--
Hi [~kasha],
Thanks for working on this patch, this is very useful.
[
https://issues.apache.org/jira/browse/YARN-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15173137#comment-15173137
]
Karthik Kambatla commented on YARN-4719:
bq. May also be useful to expose functionality in the
[
https://issues.apache.org/jira/browse/YARN-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15173101#comment-15173101
]
Arun Suresh commented on YARN-4719:
---
Much needed patch [~kasha]..
Took a quick look, some comments
# You
[
https://issues.apache.org/jira/browse/YARN-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171456#comment-15171456
]
Hadoop QA commented on YARN-4719:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-4719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15171347#comment-15171347
]
Hadoop QA commented on YARN-4719:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
25 matches
Mail list logo