[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15593965#comment-15593965
]
Hudson commented on YARN-5047:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10652 (See
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15593913#comment-15593913
]
Karthik Kambatla commented on YARN-5047:
The checkstyle issues reported are benign, and test
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15593886#comment-15593886
]
Hadoop QA commented on YARN-5047:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15593888#comment-15593888
]
Hadoop QA commented on YARN-5047:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15586920#comment-15586920
]
Daniel Templeton commented on YARN-5047:
Latest patch looks great. Thanks for doing that refactor.
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15549956#comment-15549956
]
Hadoop QA commented on YARN-5047:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423565#comment-15423565
]
Daniel Templeton commented on YARN-5047:
Thanks for the patch, [~rchiang]! A few comments:
* The
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15421919#comment-15421919
]
Hadoop QA commented on YARN-5047:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416042#comment-15416042
]
Hadoop QA commented on YARN-5047:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15414266#comment-15414266
]
Daniel Templeton commented on YARN-5047:
Looks like the current patch needs to be rebased. I see
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389905#comment-15389905
]
Ray Chiang commented on YARN-5047:
--
RE: checkstyle
Same protected variable warning as before.
>
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15388896#comment-15388896
]
Hadoop QA commented on YARN-5047:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15383067#comment-15383067
]
Ray Chiang commented on YARN-5047:
--
RE: checkstyle
Same issue as before (protected variable being used by
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15383062#comment-15383062
]
Hadoop QA commented on YARN-5047:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380318#comment-15380318
]
Ray Chiang commented on YARN-5047:
--
Will do. Thanks [~ajisakaa].
> Refactor nodeUpdate across schedulers
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380288#comment-15380288
]
Akira Ajisaka commented on YARN-5047:
-
mvn javadoc:javadoc fails by error.
{noformat}
[ERROR]
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380282#comment-15380282
]
Ray Chiang commented on YARN-5047:
--
RE: checkstyle
Same issue with protected variable
RE: Javadoc
Looks
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15380238#comment-15380238
]
Hadoop QA commented on YARN-5047:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15379922#comment-15379922
]
Karthik Kambatla commented on YARN-5047:
There is one pending comment that needs addressing. I can
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15379920#comment-15379920
]
Wangda Tan commented on YARN-5047:
--
Patch LGTM, +1, Thanks [~rchiang] and reviews from [~kasha].
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378956#comment-15378956
]
Wangda Tan commented on YARN-5047:
--
[~kasha], please give me one more day to look at this, please feel
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15378279#comment-15378279
]
Karthik Kambatla commented on YARN-5047:
Sorry for missing this in my previous review.
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15359869#comment-15359869
]
Ray Chiang commented on YARN-5047:
--
RE: No new tests
Pure code refactoring.
RE: Checkstyle
Complaining
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15359850#comment-15359850
]
Karthik Kambatla commented on YARN-5047:
[~rchiang] - the latest patch looks good. Is the CS test
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15351642#comment-15351642
]
Hadoop QA commented on YARN-5047:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15342631#comment-15342631
]
Ray Chiang commented on YARN-5047:
--
Thanks [~wangda] and [~kasha]. I've filed the following JIRAs:
*
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15311209#comment-15311209
]
Wangda Tan commented on YARN-5047:
--
[~kasha]/[~rchiang].
bq. Unlike other schedulers, CS seems to call
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15306981#comment-15306981
]
Karthik Kambatla commented on YARN-5047:
Thanks for the update, Ray. Almost there. Comments:
# The
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297344#comment-15297344
]
Ray Chiang commented on YARN-5047:
--
RE: checkstyle
Same issue with protected member variable.
RE:
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297216#comment-15297216
]
Hadoop QA commented on YARN-5047:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297041#comment-15297041
]
Ray Chiang commented on YARN-5047:
--
Filed follow up JIRAs YARN-5128 and YARN-5129.
> Refactor nodeUpdate
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15297002#comment-15297002
]
Ray Chiang commented on YARN-5047:
--
Thanks for the feedback guys. I agree with doing #1, but it looks
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15296548#comment-15296548
]
Karthik Kambatla commented on YARN-5047:
Thanks for the review, Wangda.
Agree that #1 is simpler.
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15294147#comment-15294147
]
Wangda Tan commented on YARN-5047:
--
Thanks [~rchiang],
I have a similar comment which is mentioned by
[
https://issues.apache.org/jira/browse/YARN-5047?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15290416#comment-15290416
]
Karthik Kambatla commented on YARN-5047:
Excited to see progress here. Thanks for working on this,
35 matches
Mail list logo
