[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037135#comment-16037135 ] Sunil G commented on YARN-5333: --- Yes [~ebadger]. I will make sure necessary comments are also added in main

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037054#comment-16037054 ] Eric Badger commented on YARN-5333: --- [~sunilg], backporting this to 2.8 broke a unit test. It would also

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15410467#comment-15410467 ] Jun Gong commented on YARN-5333: Thanks [~rohithsharma], [~jianhe] and [~sunilg] > Some recovered apps

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409650#comment-15409650 ] Hudson commented on YARN-5333: -- SUCCESS: Integrated in Hadoop-trunk-Commit #10223 (See

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409608#comment-15409608 ] Rohith Sharma K S commented on YARN-5333: - Thanks Sunil and Jian, I will commit it shortly. > Some

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409604#comment-15409604 ] Sunil G commented on YARN-5333: --- In that case, we could keep existing test case itself. +1 from my side. >

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409576#comment-15409576 ] Jian He commented on YARN-5333: --- Im fine with that, thx > Some recovered apps are put into default queue

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409577#comment-15409577 ] Jian He commented on YARN-5333: --- Im fine with that, thx > Some recovered apps are put into default queue

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409307#comment-15409307 ] Rohith Sharma K S commented on YARN-5333: - Overall patch look clean now and good!! One thing is I

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15409275#comment-15409275 ] Jun Gong commented on YARN-5333: Test case errors are not related, addressed in YARN-5157 and YARN-5057. >

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407585#comment-15407585 ] Hadoop QA commented on YARN-5333: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407449#comment-15407449 ] Sunil G commented on YARN-5333: --- Yes, you are correct. As I see, {{TestRMRestart}} uses

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407442#comment-15407442 ] Jun Gong commented on YARN-5333: Hi [~sunilg], in order to reproduce the error case, we need to create some

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407426#comment-15407426 ] Sunil G commented on YARN-5333: --- Thanks [~hex108] Sorry for sharing a late comment. I think the test case is

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407374#comment-15407374 ] Jun Gong commented on YARN-5333: Yes, I read comments in YARN-3893 again, I agree with it too. I'll update

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407366#comment-15407366 ] Hadoop QA commented on YARN-5333: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407363#comment-15407363 ] Jian He commented on YARN-5333: --- I see, I think this makes sense. Otherwise, RM will continuously retry.

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407212#comment-15407212 ] Sunil G commented on YARN-5333: --- Hi [~jianhe] and [~rohithsharma] [~hex108] bq.I think the

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407189#comment-15407189 ] Jun Gong commented on YARN-5333: Attach a new patch 09.patch. Rename {{refreshXXXWithoutCheck}} to

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407041#comment-15407041 ] Jun Gong commented on YARN-5333: Thanks [~rohithsharma] for the review. bq. refreshXXXWithoutCheck does

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406995#comment-15406995 ] Hadoop QA commented on YARN-5333: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406980#comment-15406980 ] Rohith Sharma K S commented on YARN-5333: - The approach seems looks good. Few things to consider #

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406144#comment-15406144 ] Hadoop QA commented on YARN-5333: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406060#comment-15406060 ] Jun Gong commented on YARN-5333: Thanks [~jianhe]. Attach a new patch to address above comments. It also

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405539#comment-15405539 ] Jian He commented on YARN-5333: --- bq. then call rm.handleTransitionToStandBy. I think the ActiveStandbyElector

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405503#comment-15405503 ] Jun Gong commented on YARN-5333: Hi [~jianhe], I think the

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15405478#comment-15405478 ] Jian He commented on YARN-5333: --- Not related to this patch, I noticed that, if anything fails in the refresh

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404243#comment-15404243 ] Hadoop QA commented on YARN-5333: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15404150#comment-15404150 ] Jun Gong commented on YARN-5333: Attach a new patch. According to the suggestion, I abstracted

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403741#comment-15403741 ] Jun Gong commented on YARN-5333: Thanks [~rohithsharma], [~jianhe] for the review and comments! bq. 1.

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403439#comment-15403439 ] Jian He commented on YARN-5333: --- Instead of reusing the existing refreshAll method, I checked each refresh

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403423#comment-15403423 ] Rohith Sharma K S commented on YARN-5333: - Thanks for the patch, some comments # Should {{private

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403265#comment-15403265 ] Hadoop QA commented on YARN-5333: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15403213#comment-15403213 ] Jun Gong commented on YARN-5333: Attach a new patch to fix checkstyle error. Test cases error are not

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402247#comment-15402247 ] Hadoop QA commented on YARN-5333: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15402120#comment-15402120 ] Jun Gong commented on YARN-5333: Thanks [~rohithsharma] for verifying it and suggestion! I attached a new

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399237#comment-15399237 ] Rohith Sharma K S commented on YARN-5333: - I just tried modifying the code, the below error I was

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15397441#comment-15397441 ] Rohith Sharma K S commented on YARN-5333: - bq. Do you mean ResourceManager#startWepApp will fail to

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15397352#comment-15397352 ] Jun Gong commented on YARN-5333: Sorry for late reply. Thanks [~rohithsharma], [~sunilg] and [~jianhe]'s

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393292#comment-15393292 ] Jian He commented on YARN-5333: --- I prefer doing initialization of services before starting it. Then we don't

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15392379#comment-15392379 ] Sunil G commented on YARN-5333: --- [~rohithsharma] [~jianhe] [~hex108] I think its better to refresh config OR

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389302#comment-15389302 ] Rohith Sharma K S commented on YARN-5333: - I think for fixing this issue, for any

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389266#comment-15389266 ] Rohith Sharma K S commented on YARN-5333: - Apologies for coming late! bq. didn't quite get this:

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15389022#comment-15389022 ] Jian He commented on YARN-5333: --- If the initialization of active services is done before starting services,

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15388710#comment-15388710 ] Jun Gong commented on YARN-5333: Thanks [~sunilg]. Yes, fail-fast seems better. {quote} However one

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387915#comment-15387915 ] Sunil G commented on YARN-5333: --- [~hex108], thanks for the clarification. With YARN-3893, we were trying to

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387649#comment-15387649 ] Jun Gong commented on YARN-5333: {{refreshQueues}} will cause StandbyException, however

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387552#comment-15387552 ] Sunil G commented on YARN-5333: --- Thanks [~hex108] Yes, we are recovering apps (by calling

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387533#comment-15387533 ] Jun Gong commented on YARN-5333: {quote}Could you also please confirm that whether you have added new queue

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387503#comment-15387503 ] Sunil G commented on YARN-5333: --- HI [~hex108], Thanks for pointing out regarding {{refreshQueues}} failure

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387462#comment-15387462 ] Jun Gong commented on YARN-5333: Thanks [~sunilg] for review and comments. I tested with normal config

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387427#comment-15387427 ] Sunil G commented on YARN-5333: --- Hi [~hex108] Thanks for working on this patch. I have few doubts on the test

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15387152#comment-15387152 ] Hadoop QA commented on YARN-5333: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386941#comment-15386941 ] Hadoop QA commented on YARN-5333: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15386003#comment-15386003 ] Jun Gong commented on YARN-5333: Attach a new patch 03.patch to fix the test case error. Could someone

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15385978#comment-15385978 ] Jun Gong commented on YARN-5333: I verified it for CapacityScheduler: 1. Without the patch, apps that

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15376219#comment-15376219 ] Jun Gong commented on YARN-5333: The reason for test case errors in TestRMWebServicesAppsModification(e.g.

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375143#comment-15375143 ] Hadoop QA commented on YARN-5333: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375019#comment-15375019 ] Jun Gong commented on YARN-5333: Add a test case in the new patch to reproduce the problem. > Some

[jira] [Commented] (YARN-5333) Some recovered apps are put into default queue when RM HA

[ https://issues.apache.org/jira/browse/YARN-5333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373227#comment-15373227 ] Hadoop QA commented on YARN-5333: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||