[jira] [Commented] (YARN-5748) Backport YARN-5718 to branch-2
[ https://issues.apache.org/jira/browse/YARN-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951664#comment-16951664 ] Hadoop QA commented on YARN-5748: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 17m 27s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} branch-2 Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 31s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 14m 19s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 8m 14s{color} | {color:green} branch-2 passed with JDK v1.7.0_95 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 7m 27s{color} | {color:green} branch-2 passed with JDK v1.8.0_222 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 8s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 2m 37s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 38s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 20s{color} | {color:green} branch-2 passed with JDK v1.7.0_95 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 56s{color} | {color:green} branch-2 passed with JDK v1.8.0_222 {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 13s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:red}-1{color} | {color:red} mvninstall {color} | {color:red} 0m 39s{color} | {color:red} hadoop-yarn-server-resourcemanager in the patch failed. {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 2m 47s{color} | {color:red} hadoop-yarn in the patch failed with JDK v1.7.0_95. {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 2m 47s{color} | {color:red} hadoop-yarn in the patch failed with JDK v1.7.0_95. {color} | | {color:red}-1{color} | {color:red} compile {color} | {color:red} 2m 26s{color} | {color:red} hadoop-yarn in the patch failed with JDK v1.8.0_222. {color} | | {color:red}-1{color} | {color:red} javac {color} | {color:red} 2m 26s{color} | {color:red} hadoop-yarn in the patch failed with JDK v1.8.0_222. {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 54s{color} | {color:orange} hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 270 unchanged - 0 fixed = 272 total (was 270) {color} | | {color:red}-1{color} | {color:red} mvnsite {color} | {color:red} 0m 42s{color} | {color:red} hadoop-yarn-server-resourcemanager in the patch failed. {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 29s{color} | {color:red} hadoop-yarn-server-resourcemanager in the patch failed. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 41s{color} | {color:green} the patch passed with JDK v1.7.0_95 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 21s{color} | {color:green} the patch passed with JDK v1.8.0_222 {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 39s{color} | {color:green} hadoop-yarn-api in the patch passed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 3m 23s{color} | {color:green} hadoop-yarn-common in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 0m 38s{color} | {color:red} hadoop-yarn-server-resourcemanager in the patch failed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 27s{color} | {color:green} The patch does not g
[jira] [Commented] (YARN-5748) Backport YARN-5718 to branch-2
[ https://issues.apache.org/jira/browse/YARN-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16951621#comment-16951621 ] Wang, Xinglong commented on YARN-5748: -- I went through hdfs code, and also found the issue is only with No-HA hdfs setup. The original description is not correct. As the following code, only in Non_HA case, retry config will be used. In HA case, RetryPolicies.failoverOnNetworkException will be used. {code:java} public static ProxyAndInfo createProxy(Configuration conf, URI nameNodeUri, Class xface, AtomicBoolean fallbackToSimpleAuth) throws IOException { AbstractNNFailoverProxyProvider failoverProxyProvider = createFailoverProxyProvider(conf, nameNodeUri, xface, true, fallbackToSimpleAuth); if (failoverProxyProvider == null) { // Non-HA case return createNonHAProxy(conf, NameNode.getAddress(conf, nameNodeUri), xface, UserGroupInformation.getCurrentUser(), true, fallbackToSimpleAuth); } else { // HA case Conf config = new Conf(conf); T proxy = (T) RetryProxy.create(xface, failoverProxyProvider, RetryPolicies.failoverOnNetworkException( RetryPolicies.TRY_ONCE_THEN_FAIL, config.maxFailoverAttempts, config.maxRetryAttempts, config.failoverSleepBaseMillis, config.failoverSleepMaxMillis)); {code} > Backport YARN-5718 to branch-2 > -- > > Key: YARN-5748 > URL: https://issues.apache.org/jira/browse/YARN-5748 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Junping Du >Assignee: Masatake Iwasaki >Priority: Major > Attachments: YARN-5748-branch-2.001.patch, > YARN-5748-branch-2.002.patch > > > In YARN-5718, we have identify several unnecessary config to over-write HDFS > client behavior in several components of YARN (FSRMStore, TimelineClient, > NodeLabelStore, etc.) which cause job failure in some cases (NN HA, etc.) - > that's definitely belongs to bug. In YARN-5718, we proposed to remove the > config as it shouldn't be supposed to work, which get committed to trunk > already as alpha stage has more flexibility for incompatible changes. In > branch-2, we want to play a bit more safe and get more discussion. > Obviously, there are several options here: > 1. Don't fix anything, let bug exist > 2. Fix the bug, but keep the configuration, or mark it deprecated and add > some explanation to say this configuration is not supposed to work any more. > 3. Exactly like YARN-5718, fix the bug and remove the unnecessary > configuration. > This ticket is filed for more discussion. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5748) Backport YARN-5718 to branch-2
[ https://issues.apache.org/jira/browse/YARN-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16538215#comment-16538215 ] Masatake Iwasaki commented on YARN-5748: [~hexiaoqiao], I looked into the code again. Since "dfs.client.retry.policy.enabled" is used only in non-HA setup, testFSRMStateStoreNNFailover added by the 002 patch is useless. It always succeeds in current branch-2 regardless to retry policy settings. I think FSRMStateStore has no problem caused by overwriting retry policy spec. If you have setup to reproduce the issue, it will be help to rewrite the unit test. > Backport YARN-5718 to branch-2 > -- > > Key: YARN-5748 > URL: https://issues.apache.org/jira/browse/YARN-5748 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Junping Du >Assignee: Masatake Iwasaki >Priority: Major > Attachments: YARN-5748-branch-2.001.patch, > YARN-5748-branch-2.002.patch > > > In YARN-5718, we have identify several unnecessary config to over-write HDFS > client behavior in several components of YARN (FSRMStore, TimelineClient, > NodeLabelStore, etc.) which cause job failure in some cases (NN HA, etc.) - > that's definitely belongs to bug. In YARN-5718, we proposed to remove the > config as it shouldn't be supposed to work, which get committed to trunk > already as alpha stage has more flexibility for incompatible changes. In > branch-2, we want to play a bit more safe and get more discussion. > Obviously, there are several options here: > 1. Don't fix anything, let bug exist > 2. Fix the bug, but keep the configuration, or mark it deprecated and add > some explanation to say this configuration is not supposed to work any more. > 3. Exactly like YARN-5718, fix the bug and remove the unnecessary > configuration. > This ticket is filed for more discussion. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5748) Backport YARN-5718 to branch-2
[ https://issues.apache.org/jira/browse/YARN-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528763#comment-16528763 ] genericqa commented on YARN-5748: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 18m 36s{color} | {color:blue} Docker mode activated. {color} | || || || || {color:brown} Prechecks {color} || | {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | || || || || {color:brown} branch-2 Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 34s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 13m 44s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 12m 58s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 1m 26s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 3m 3s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 2m 21s{color} | {color:green} branch-2 passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 15s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 2m 15s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 12m 14s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 12m 14s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 1m 7s{color} | {color:orange} hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 269 unchanged - 0 fixed = 271 total (was 269) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 2m 38s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 53s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 41s{color} | {color:green} hadoop-yarn-api in the patch passed. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 62m 42s{color} | {color:red} hadoop-yarn-common in the patch failed. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 64m 14s{color} | {color:green} hadoop-yarn-server-resourcemanager in the patch passed. {color} | | {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 41s{color} | {color:red} The patch generated 1 ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black}203m 46s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:f667ef1 | | JIRA Issue | YARN-5748 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12861866/YARN-5748-branch-2.002.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml | | uname | Linux 4c5fdee32f43 3.13.0-139-generic #188-Ubuntu SMP Tue Jan 9 14:43:09 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/patchprocess/precommit/personality/provided.sh | | git revision | branch-2 / f951d92 | | maven | version: Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T16:41:47+00:00) | | Default Java | 1.7.0_181 | | checkstyle | https://builds.apache.org/job/PreCommit-YARN-Build/21159/artifact/out/diff-checkstyle-hadoop-yarn-project_hadoop-yarn.txt | | unit | https://builds.apache.org/job/P
[jira] [Commented] (YARN-5748) Backport YARN-5718 to branch-2
[ https://issues.apache.org/jira/browse/YARN-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16528660#comment-16528660 ] He Xiaoqiao commented on YARN-5748: --- [~djp],[~iwasakims] is this issue still going work? > Backport YARN-5718 to branch-2 > -- > > Key: YARN-5748 > URL: https://issues.apache.org/jira/browse/YARN-5748 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Junping Du >Assignee: Masatake Iwasaki >Priority: Major > Attachments: YARN-5748-branch-2.001.patch, > YARN-5748-branch-2.002.patch > > > In YARN-5718, we have identify several unnecessary config to over-write HDFS > client behavior in several components of YARN (FSRMStore, TimelineClient, > NodeLabelStore, etc.) which cause job failure in some cases (NN HA, etc.) - > that's definitely belongs to bug. In YARN-5718, we proposed to remove the > config as it shouldn't be supposed to work, which get committed to trunk > already as alpha stage has more flexibility for incompatible changes. In > branch-2, we want to play a bit more safe and get more discussion. > Obviously, there are several options here: > 1. Don't fix anything, let bug exist > 2. Fix the bug, but keep the configuration, or mark it deprecated and add > some explanation to say this configuration is not supposed to work any more. > 3. Exactly like YARN-5718, fix the bug and remove the unnecessary > configuration. > This ticket is filed for more discussion. -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5748) Backport YARN-5718 to branch-2
[ https://issues.apache.org/jira/browse/YARN-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955488#comment-15955488 ] Junping Du commented on YARN-5748: -- Thanks [~iwasakims] for taking this up. I will review it today. Thx! > Backport YARN-5718 to branch-2 > -- > > Key: YARN-5748 > URL: https://issues.apache.org/jira/browse/YARN-5748 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Junping Du >Assignee: Masatake Iwasaki > Attachments: YARN-5748-branch-2.001.patch, > YARN-5748-branch-2.002.patch > > > In YARN-5718, we have identify several unnecessary config to over-write HDFS > client behavior in several components of YARN (FSRMStore, TimelineClient, > NodeLabelStore, etc.) which cause job failure in some cases (NN HA, etc.) - > that's definitely belongs to bug. In YARN-5718, we proposed to remove the > config as it shouldn't be supposed to work, which get committed to trunk > already as alpha stage has more flexibility for incompatible changes. In > branch-2, we want to play a bit more safe and get more discussion. > Obviously, there are several options here: > 1. Don't fix anything, let bug exist > 2. Fix the bug, but keep the configuration, or mark it deprecated and add > some explanation to say this configuration is not supposed to work any more. > 3. Exactly like YARN-5718, fix the bug and remove the unnecessary > configuration. > This ticket is filed for more discussion. -- This message was sent by Atlassian JIRA (v6.3.15#6346) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5748) Backport YARN-5718 to branch-2
[ https://issues.apache.org/jira/browse/YARN-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15955038#comment-15955038 ] Hadoop QA commented on YARN-5748: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 23s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m 0s{color} | {color:green} The patch appears to include 1 new or modified test files. {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 48s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 46s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 55s{color} | {color:green} branch-2 passed with JDK v1.8.0_121 {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 14s{color} | {color:green} branch-2 passed with JDK v1.7.0_121 {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 45s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 40s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 45s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 3m 37s{color} | {color:green} branch-2 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 6s{color} | {color:green} branch-2 passed with JDK v1.8.0_121 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 16s{color} | {color:green} branch-2 passed with JDK v1.7.0_121 {color} | | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 10s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 25s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 49s{color} | {color:green} the patch passed with JDK v1.8.0_121 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 2m 13s{color} | {color:green} the patch passed with JDK v1.7.0_121 {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 2m 13s{color} | {color:green} the patch passed {color} | | {color:orange}-0{color} | {color:orange} checkstyle {color} | {color:orange} 0m 42s{color} | {color:orange} hadoop-yarn-project/hadoop-yarn: The patch generated 2 new + 270 unchanged - 0 fixed = 272 total (was 270) {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 37s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 41s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 1s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 4m 14s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 2s{color} | {color:green} the patch passed with JDK v1.8.0_121 {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 14s{color} | {color:green} the patch passed with JDK v1.7.0_121 {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 0m 27s{color} | {color:green} hadoop-yarn-api in the patch passed with JDK v1.7.0_121. {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 2m 24s{color} | {color:green} hadoop-yarn-common in the patch passed with JDK v1.7.0_121. {color} | | {color:red}-1{color} | {color:red} unit {color} | {color:red} 39m 47s{color} | {color:red} hadoop-yarn-server-resourcemanager in the patch failed with JDK v1.7.0_121. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 19s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {col
[jira] [Commented] (YARN-5748) Backport YARN-5718 to branch-2
[ https://issues.apache.org/jira/browse/YARN-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15586012#comment-15586012 ] Vrushali C commented on YARN-5748: -- Agree with fixing the bug. I am going back and forth between #2 and #3. I am thinking we can remove it's usage but we can keep the variable and mark it deprecated and perhaps log a warning saying this is no longer taking effect? > Backport YARN-5718 to branch-2 > -- > > Key: YARN-5748 > URL: https://issues.apache.org/jira/browse/YARN-5748 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Junping Du >Assignee: Junping Du > > In YARN-5718, we have identify several unnecessary config to over-write HDFS > client behavior in several components of YARN (FSRMStore, TimelineClient, > NodeLabelStore, etc.) which cause job failure in some cases (NN HA, etc.) - > that's definitely belongs to bug. In YARN-5718, we proposed to remove the > config as it shouldn't be supposed to work, which get committed to trunk > already as alpha stage has more flexibility for incompatible changes. In > branch-2, we want to play a bit more safe and get more discussion. > Obviously, there are several options here: > 1. Don't fix anything, let bug exist > 2. Fix the bug, but keep the configuration, or mark it deprecated and add > some explanation to say this configuration is not supposed to work any more. > 3. Exactly like YARN-5718, fix the bug and remove the unnecessary > configuration. > This ticket is filed for more discussion. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-5748) Backport YARN-5718 to branch-2
[ https://issues.apache.org/jira/browse/YARN-5748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15584113#comment-15584113 ] Junping Du commented on YARN-5748: -- I don't think option 1 should be our choice. I would prefer option 3 over 2. Thoughts? > Backport YARN-5718 to branch-2 > -- > > Key: YARN-5748 > URL: https://issues.apache.org/jira/browse/YARN-5748 > Project: Hadoop YARN > Issue Type: Bug >Reporter: Junping Du >Assignee: Junping Du > > In YARN-5718, we have identify several unnecessary config to over-write HDFS > client behavior in several components of YARN (FSRMStore, TimelineClient, > NodeLabelStore, etc.) which cause job failure in some cases (NN HA, etc.) - > that's definitely belongs to bug. In YARN-5718, we proposed to remove the > config as it shouldn't be supposed to work, which get committed to trunk > already as alpha stage has more flexibility for incompatible changes. In > branch-2, we want to play a bit more safe and get more discussion. > Obviously, there are several options here: > 1. Don't fix anything, let bug exist > 2. Fix the bug, but keep the configuration, or mark it deprecated and add > some explanation to say this configuration is not supposed to work any more. > 3. Exactly like YARN-5718, fix the bug and remove the unnecessary > configuration. > This ticket is filed for more discussion. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org