[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16054770#comment-16054770
]
Sunil G commented on YARN-5892:
---
Thanks [~leftnoteasy] and [~eepayne]
Committing it shortly.
> Capacity
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16052169#comment-16052169
]
Wangda Tan commented on YARN-5892:
--
Thanks [~eepayne] and reviews from [~sunilg], patch looks good.
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16047468#comment-16047468
]
Hadoop QA commented on YARN-5892:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032499#comment-16032499
]
Sunil G commented on YARN-5892:
---
Latest patch seems fine for me. [~leftnoteasy], could you also please take a
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031352#comment-16031352
]
Eric Payne commented on YARN-5892:
--
The findbugs warning was in code that was not changed by this patch.
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029925#comment-16029925
]
Hadoop QA commented on YARN-5892:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16025713#comment-16025713
]
Sunil G commented on YARN-5892:
---
Thanks [~eepayne]
bq.which then multiplies the value of userLimitResource
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16025425#comment-16025425
]
Eric Payne commented on YARN-5892:
--
Thank you for the reviews.
bq. allUsersTimesWeights will be less than
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16022672#comment-16022672
]
Sunil G commented on YARN-5892:
---
[~eepayne]
Few more doubts on patch.
1.
{code}
// For
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16022151#comment-16022151
]
Wangda Tan commented on YARN-5892:
--
Thanks [~eepayne], one minor comment:
1) Could you move
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021343#comment-16021343
]
Sunil G commented on YARN-5892:
---
Yes [~eepayne]. I will do a round of review and some tests today and share
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021209#comment-16021209
]
Eric Payne commented on YARN-5892:
--
[~jlowe], [~leftnoteasy], [~sunilg], just checking to see if you have
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16007009#comment-16007009
]
Hadoop QA commented on YARN-5892:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15998847#comment-15998847
]
Eric Payne commented on YARN-5892:
--
Sorry [~sunilg]. I missed your comment.
{quote}
I have few doubts
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985882#comment-15985882
]
Hadoop QA commented on YARN-5892:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15985868#comment-15985868
]
Sunil G commented on YARN-5892:
---
[~eepayne]
Thanks for the work here.
I have few doubts related to YARN-2113
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15983628#comment-15983628
]
Wangda Tan commented on YARN-5892:
--
1) For UsersManager
- updateUserWeights: Should we re-count
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15983235#comment-15983235
]
Eric Payne commented on YARN-5892:
--
I will need to upload a new patch at any rate, because the check for
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15983076#comment-15983076
]
Jason Lowe commented on YARN-5892:
--
I won't block this patch over the MULP*weight <= 100 check, but I
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981974#comment-15981974
]
Wangda Tan commented on YARN-5892:
--
[~eepayne], [~jlowe], ideally MULP is guaranteed resource for users in
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981939#comment-15981939
]
Eric Payne commented on YARN-5892:
--
bq. I don't understand imposing a hard limit of weight < 100/MULP.
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15981164#comment-15981164
]
Jason Lowe commented on YARN-5892:
--
I don't understand imposing a hard limit of weight < 100/MULP. For
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15980101#comment-15980101
]
Hadoop QA commented on YARN-5892:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973200#comment-15973200
]
Wangda Tan commented on YARN-5892:
--
Thanks [~eepayne] for your detailed explanations:
bq. No, that's not
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973191#comment-15973191
]
Wangda Tan commented on YARN-5892:
--
[~jlowe], thanks for your comments.
bq. I think the weight needs to
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15973168#comment-15973168
]
Jason Lowe commented on YARN-5892:
--
bq. Also, weight of users applies to hard limit of user (user limit
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972821#comment-15972821
]
Jason Lowe commented on YARN-5892:
--
I'm +1 for weight == 0. As long as it doesn't break the code (e.g.:
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15972782#comment-15972782
]
Eric Payne commented on YARN-5892:
--
[~leftnoteasy], thank you very much for your in-depth review and
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971666#comment-15971666
]
Wangda Tan commented on YARN-5892:
--
Thanks [~eepayne] for updating the patch, got some time to check the
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971588#comment-15971588
]
Eric Payne commented on YARN-5892:
--
{quote}
Having 0 as a user weight doesn't hurt anything except the
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971108#comment-15971108
]
Eric Payne commented on YARN-5892:
--
bq. Yes, we could discuss more about the definition in separate jira.
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15971041#comment-15971041
]
Eric Payne commented on YARN-5892:
--
Thanks a lot [~sunilg] for your review and comments.
{quote}
{code}
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15969256#comment-15969256
]
Sunil G commented on YARN-5892:
---
bq.Yes, the user weight of 0 case is a special one that we would like to
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966789#comment-15966789
]
Eric Payne commented on YARN-5892:
--
By the way, the latest patch reverts the behavior of what is displayed
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15966368#comment-15966368
]
Hadoop QA commented on YARN-5892:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15963994#comment-15963994
]
Sunil G commented on YARN-5892:
---
Thanks [~eepayne].
Few comments from end:
#
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15962745#comment-15962745
]
Eric Payne commented on YARN-5892:
--
{quote}
||*User Name*||*Max Resource*||*Weight*||*Used Resource*||
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15961993#comment-15961993
]
Hadoop QA commented on YARN-5892:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15957125#comment-15957125
]
Hadoop QA commented on YARN-5892:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956944#comment-15956944
]
Eric Payne commented on YARN-5892:
--
Build failure seems unrelated:
{noformat}
[ERROR] Failed to execute
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956223#comment-15956223
]
Wangda Tan commented on YARN-5892:
--
Thanks [~eepayne],
Haven't reviewed your latest patch, regarding to
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15956151#comment-15956151
]
Hadoop QA commented on YARN-5892:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953876#comment-15953876
]
Wangda Tan commented on YARN-5892:
--
[~eepayne],
bq. I think it's good to allow setting user weights at
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15953639#comment-15953639
]
Eric Payne commented on YARN-5892:
--
Thanks [~leftnoteasy] for your detailed review. I really appreciate
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951539#comment-15951539
]
Wangda Tan commented on YARN-5892:
--
Thanks [~eepayne] to update the patch.
Several comments:
1) For User
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941314#comment-15941314
]
Hadoop QA commented on YARN-5892:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15939235#comment-15939235
]
Eric Payne commented on YARN-5892:
--
Thanks for your comments, [~sunilg].
bq. Is it possible to keep
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15935823#comment-15935823
]
Sunil G commented on YARN-5892:
---
Hi [~eepayne]
Thanks for working on this patch.
I have some doubts which
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930295#comment-15930295
]
Sunil G commented on YARN-5892:
---
Sorry for late entry. I am also reviewing and will share my thoughts at
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15930280#comment-15930280
]
Hadoop QA commented on YARN-5892:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15926626#comment-15926626
]
Hadoop QA commented on YARN-5892:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925029#comment-15925029
]
Wangda Tan commented on YARN-5892:
--
bq. My reasoning is that UsersManager#addUser always retrieves a fresh
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15925012#comment-15925012
]
Eric Payne commented on YARN-5892:
--
Thanks a lot, [~leftnoteasy], for your comments.
bq. 1) Can this patch
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15924727#comment-15924727
]
Wangda Tan commented on YARN-5892:
--
Thanks [~eepayne] for updating the patch, haven't looked into details
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905924#comment-15905924
]
Hadoop QA commented on YARN-5892:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891712#comment-15891712
]
Wangda Tan commented on YARN-5892:
--
bq. In my mind, overriding queue's MULP with user-specific MULP is
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891256#comment-15891256
]
Eric Payne commented on YARN-5892:
--
{quote}
So I preferred to keep the semantic more similar to existing
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15886351#comment-15886351
]
Wangda Tan commented on YARN-5892:
--
Thanks [~eepayne] for the elaborations,
I have a discussion with
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882720#comment-15882720
]
Eric Payne commented on YARN-5892:
--
Thanks, [~leftnoteasy], for your feedback. I really value your input.
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881649#comment-15881649
]
Hadoop QA commented on YARN-5892:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881614#comment-15881614
]
Wangda Tan commented on YARN-5892:
--
Hi [~eepayne],
Apologize for my late responses, finally get some time
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15879673#comment-15879673
]
Hadoop QA commented on YARN-5892:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5892?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15677954#comment-15677954
]
Wangda Tan commented on YARN-5892:
--
Linked this JIRA to YARN-5889, I think this is more like a special
63 matches
Mail list logo
