[jira] [Commented] (YARN-6307) Refactor FairShareComparator#compare

2018-09-19 Thread stefanlee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620523#comment-16620523 ] stefanlee commented on YARN-6307: - Hi, [~yufeigu] ,after merge this patch, we met the problem YARN-4743.

[jira] [Commented] (YARN-6307) Refactor FairShareComparator#compare

2018-07-25 Thread stefanlee (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1626#comment-1626 ] stefanlee commented on YARN-6307: - thanks for this jira,[~yufeigu] [~templedf], I have a  doubt that what 

[jira] [Commented] (YARN-6307) Refactor FairShareComparator#compare

2017-11-23 Thread zhengchenyu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16264151#comment-16264151 ] zhengchenyu commented on YARN-6307: --- We know the demand which is returned by getDemand is the

[jira] [Commented] (YARN-6307) Refactor FairShareComparator#compare

2017-07-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16100732#comment-16100732 ] Hudson commented on YARN-6307: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12054 (See

[jira] [Commented] (YARN-6307) Refactor FairShareComparator#compare

2017-07-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099571#comment-16099571 ] Hadoop QA commented on YARN-6307: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6307) Refactor FairShareComparator#compare

2017-07-24 Thread Yufei Gu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099195#comment-16099195 ] Yufei Gu commented on YARN-6307: The overhead of this refactoring would be 1. More check on variable

[jira] [Commented] (YARN-6307) Refactor FairShareComparator#compare

2017-07-24 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099175#comment-16099175 ] Daniel Templeton commented on YARN-6307: LGTM. Given the frequency with which this method is

[jira] [Commented] (YARN-6307) Refactor FairShareComparator#compare

2017-07-24 Thread Yufei Gu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099164#comment-16099164 ] Yufei Gu commented on YARN-6307: Thanks [~templedf] for the review. Uploaded patch v3 for your comments. >

[jira] [Commented] (YARN-6307) Refactor FairShareComparator#compare

2017-07-24 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099134#comment-16099134 ] Daniel Templeton commented on YARN-6307: Nice patch, [~yufeigu]. Here are my comments: # Since

[jira] [Commented] (YARN-6307) Refactor FairShareComparator#compare

2017-07-14 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088355#comment-16088355 ] Hadoop QA commented on YARN-6307: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6307) Refactor FairShareComparator#compare

2017-07-12 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16085011#comment-16085011 ] Hadoop QA commented on YARN-6307: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-6307) Refactor FairShareComparator#compare

2017-07-12 Thread Yufei Gu (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16084921#comment-16084921 ] Yufei Gu commented on YARN-6307: [~Tao Jie], I like the idea of reduce queue sort frequency, but I don't

[jira] [Commented] (YARN-6307) Refactor FairShareComparator#compare

2017-03-08 Thread Tao Jie (JIRA)
[ https://issues.apache.org/jira/browse/YARN-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15902482#comment-15902482 ] Tao Jie commented on YARN-6307: --- Thank you [~yufeigu], FairShareComparator#compare is called very frequently