[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16674893#comment-16674893
]
Sunil Govindan commented on YARN-8191:
--
[~grepas] [~haibochen]
This is an incompatib
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16509316#comment-16509316
]
Takanobu Asanuma commented on YARN-8191:
Thanks for working on this, but it may cr
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490382#comment-16490382
]
Gergo Repas commented on YARN-8191:
---
[~haibochen] - Thanks for the review and committing
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490052#comment-16490052
]
Hudson commented on YARN-8191:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #1428
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489751#comment-16489751
]
Haibo Chen commented on YARN-8191:
--
+1 on the latest patch. Will check it in later today.
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489701#comment-16489701
]
genericqa commented on YARN-8191:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote |
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489481#comment-16489481
]
Gergo Repas commented on YARN-8191:
---
[~haibochen] - that's a nice catch, I fixed it.
> F
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489410#comment-16489410
]
Haibo Chen commented on YARN-8191:
--
Findbugs is complaining about `return
!Boolean.FALSE.
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489379#comment-16489379
]
genericqa commented on YARN-8191:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16489132#comment-16489132
]
Gergo Repas commented on YARN-8191:
---
Thanks [~haibochen]. I changed the return value remo
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487621#comment-16487621
]
Haibo Chen commented on YARN-8191:
--
+1 pending the findbug fix. The TestAMRestart.testPree
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487573#comment-16487573
]
Gergo Repas commented on YARN-8191:
---
Thanks [~haibochen] for the review!
{quote}
In this
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16487490#comment-16487490
]
genericqa commented on YARN-8191:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16484491#comment-16484491
]
Haibo Chen commented on YARN-8191:
--
{quote}The point here is that the set of removed queue
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16484050#comment-16484050
]
genericqa commented on YARN-8191:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16483864#comment-16483864
]
Gergo Repas commented on YARN-8191:
---
[~haibochen] Thanks for the review!
1) - Good point,
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16481341#comment-16481341
]
Haibo Chen commented on YARN-8191:
--
Thanks [~grepas] for the patch! I have some comments.
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480608#comment-16480608
]
genericqa commented on YARN-8191:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480478#comment-16480478
]
Gergo Repas commented on YARN-8191:
---
[~wilfreds] Thanks for the review! All your suggesti
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16480234#comment-16480234
]
Wilfred Spiegelenburg commented on YARN-8191:
-
The way the return value for {{r
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16479363#comment-16479363
]
genericqa commented on YARN-8191:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477218#comment-16477218
]
Gergo Repas commented on YARN-8191:
---
[~wilfreds] Actually, please ignore my last patch, I
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475740#comment-16475740
]
Gergo Repas commented on YARN-8191:
---
[~wilfreds] I have uploaded an updated patch version
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16475705#comment-16475705
]
genericqa commented on YARN-8191:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473961#comment-16473961
]
Gergo Repas commented on YARN-8191:
---
[~wilfreds] Thanks for the explanation. I think retu
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16473188#comment-16473188
]
Wilfred Spiegelenburg commented on YARN-8191:
-
It is a temporary place for now
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471704#comment-16471704
]
Gergo Repas commented on YARN-8191:
---
[~wilfreds] Thanks. What would be the motivation to
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471471#comment-16471471
]
Wilfred Spiegelenburg commented on YARN-8191:
-
We're almost there.
First the s
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471048#comment-16471048
]
genericqa commented on YARN-8191:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote |
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470865#comment-16470865
]
Gergo Repas commented on YARN-8191:
---
Unit test failure is unrelated, the last patch addre
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470838#comment-16470838
]
genericqa commented on YARN-8191:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16470570#comment-16470570
]
Gergo Repas commented on YARN-8191:
---
[~wilfreds] Thank you for the review! I have a quest
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468939#comment-16468939
]
Wilfred Spiegelenburg commented on YARN-8191:
-
# Can we add a test for this cas
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468891#comment-16468891
]
genericqa commented on YARN-8191:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468755#comment-16468755
]
Gergo Repas commented on YARN-8191:
---
Regarding the TestRMWebServicesReservation failures:
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468634#comment-16468634
]
Gergo Repas commented on YARN-8191:
---
Thanks [~wilfreds], I'll address those issues. Yes,
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16468459#comment-16468459
]
Wilfred Spiegelenburg commented on YARN-8191:
-
[~grepas] I see you are still wo
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467621#comment-16467621
]
Gergo Repas commented on YARN-8191:
---
TestRMWebServicesReservation is broken by my changes
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16467445#comment-16467445
]
genericqa commented on YARN-8191:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16466613#comment-16466613
]
genericqa commented on YARN-8191:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16465436#comment-16465436
]
Wilfred Spiegelenburg commented on YARN-8191:
-
thank you for the updated patch:
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16463701#comment-16463701
]
Gergo Repas commented on YARN-8191:
---
(The builds server is down, I cannot access the unit
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462617#comment-16462617
]
genericqa commented on YARN-8191:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462385#comment-16462385
]
Szilard Nemeth commented on YARN-8191:
--
Hi [~grepas]!
Thanks for the latest patch, LG
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462364#comment-16462364
]
Gergo Repas commented on YARN-8191:
---
[~snemeth] Thanks for the review! I've added these c
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16462289#comment-16462289
]
Szilard Nemeth commented on YARN-8191:
--
Hi [~grepas]!
Thanks for the updated patch.
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461444#comment-16461444
]
genericqa commented on YARN-8191:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote |
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461238#comment-16461238
]
Gergo Repas commented on YARN-8191:
---
[~wilfreds] Thank you for the review! I uploaded an
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454412#comment-16454412
]
genericqa commented on YARN-8191:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote |
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454314#comment-16454314
]
Wilfred Spiegelenburg commented on YARN-8191:
-
Thanks [~grepas] for working on
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454191#comment-16454191
]
Szilard Nemeth commented on YARN-8191:
--
# Please remove block comment from QueueManage
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449872#comment-16449872
]
genericqa commented on YARN-8191:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448776#comment-16448776
]
genericqa commented on YARN-8191:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-8191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16445986#comment-16445986
]
genericqa commented on YARN-8191:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
54 matches
Mail list logo
