[
https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680570#comment-16680570
]
Wangda Tan commented on YARN-8763:
--
[~sunilg] , I highly suggest reverting this from branch-3.2 if
[
https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679369#comment-16679369
]
Sunil Govindan commented on YARN-8763:
--
Hi [~eyang]
I am getting errors of undefined refererence
[
https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679446#comment-16679446
]
Sunil Govindan commented on YARN-8763:
--
Sorry. Apologies.
I had some old files in my .m2 repo and
[
https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642268#comment-16642268
]
Hudson commented on YARN-8763:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #15141 (See
[
https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642219#comment-16642219
]
Zian Chen commented on YARN-8763:
-
[~eyang], thanks for +1. Could you help me commit this patch? Thanks
[
https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16642203#comment-16642203
]
Eric Yang commented on YARN-8763:
-
+1 on patch 5.
> Add WebSocket logic to the Node Manager web server to
[
https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640531#comment-16640531
]
Hadoop QA commented on YARN-8763:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16640482#comment-16640482
]
Zian Chen commented on YARN-8763:
-
[~eyang] sorry for getting back late. I'm curious why
[
https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16639006#comment-16639006
]
Eric Yang commented on YARN-8763:
-
[~Zian Chen] DefaultContainerExecutor execContainer method is causing
[
https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638918#comment-16638918
]
Hadoop QA commented on YARN-8763:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638901#comment-16638901
]
Eric Yang commented on YARN-8763:
-
[~Zian Chen] +1 on patch 4. One small improvement that we can do it
[
https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638730#comment-16638730
]
Zian Chen commented on YARN-8763:
-
[~eyang], just uploaded patch 004, please help review it. Thanks
>
[
https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16638658#comment-16638658
]
Zian Chen commented on YARN-8763:
-
Thanks for the comments, Eric, I'll update the patch later today.
>
[
https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16637100#comment-16637100
]
Eric Yang commented on YARN-8763:
-
[~Zian Chen] Thank you for the patch. A few minor problems:
{code}
[
https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636687#comment-16636687
]
Hadoop QA commented on YARN-8763:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636543#comment-16636543
]
Zian Chen commented on YARN-8763:
-
Hi [~eyang], could you help review patch 003? It address comments as we
[
https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16634486#comment-16634486
]
Zian Chen commented on YARN-8763:
-
Hi [~eyang] , make sense. I'll work on patch 003 to address comments &
[
https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16633062#comment-16633062
]
Eric Yang commented on YARN-8763:
-
[~Zian Chen] Thank you for the patch, in TestNMWebServer test case,
[
https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632702#comment-16632702
]
Hadoop QA commented on YARN-8763:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16632636#comment-16632636
]
Zian Chen commented on YARN-8763:
-
Update patch-002 for review. really appreciate the help from [~eyang]
[
https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16610186#comment-16610186
]
Zian Chen commented on YARN-8763:
-
Hi [~eyang], thanks for the detailed suggestions. Make sense. Let me
[
https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609972#comment-16609972
]
Hadoop QA commented on YARN-8763:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609926#comment-16609926
]
Eric Yang commented on YARN-8763:
-
[~Zian Chen] Thank you for the patch. We usually have dependent
[
https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609919#comment-16609919
]
Zian Chen commented on YARN-8763:
-
Hi [~eyang], could you help review the patch? Thanks!
> Add WebSocket
[
https://issues.apache.org/jira/browse/YARN-8763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609917#comment-16609917
]
Zian Chen commented on YARN-8763:
-
Provide initial patch for this.
> Add WebSocket logic to the Node
25 matches
Mail list logo
