[jira] [Commented] (YARN-8984) OutstandingSchedRequests in AMRMClient could not be removed when AllocationTags is null or empty

2018-11-06 Thread Weiwei Yang (JIRA)


[ 
https://issues.apache.org/jira/browse/YARN-8984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677660#comment-16677660
 ] 

Weiwei Yang commented on YARN-8984:
---

Thanks [~fly_in_gis] for creating this issue, I have increased the priority to 
critical.

The patch looks good to me, one nit is instead of adding a new class 
\{{TestAMRMClientOutstandingSchedulingRequest}}, can we move this test case to 
\{{TestAMRMClientPlacementConstraints}}?

Cc [~botong], [~asuresh].

 

> OutstandingSchedRequests in AMRMClient could not be removed when 
> AllocationTags is null or empty
> 
>
> Key: YARN-8984
> URL: https://issues.apache.org/jira/browse/YARN-8984
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Yang Wang
>Assignee: Yang Wang
>Priority: Critical
> Attachments: YARN-8984-001.patch
>
>
> In AMRMClient, outstandingSchedRequests should be removed or decreased when 
> container allocated. However, it could not work when allocation tag is null 
> or empty.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-8984) OutstandingSchedRequests in AMRMClient could not be removed when AllocationTags is null or empty

2018-11-06 Thread Yang Wang (JIRA)


[ 
https://issues.apache.org/jira/browse/YARN-8984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677649#comment-16677649
 ] 

Yang Wang commented on YARN-8984:
-

It could be a critical bug when resync, all the outstandingSchedRequests of 
empty allocation tags will be sent again. In a big cluster, when the active RM 
swiched, the RM will receive lots of requests.

[~cheersyang] Could you please take a look?

> OutstandingSchedRequests in AMRMClient could not be removed when 
> AllocationTags is null or empty
> 
>
> Key: YARN-8984
> URL: https://issues.apache.org/jira/browse/YARN-8984
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Yang Wang
>Assignee: Yang Wang
>Priority: Critical
> Attachments: YARN-8984-001.patch
>
>
> In AMRMClient, outstandingSchedRequests should be removed or decreased when 
> container allocated. However, it could not work when allocation tag is null 
> or empty.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org