[jira] [Commented] (YARN-9474) Remove hard coded sleep from Opportunistic Scheduler tests.

2019-04-14 Thread Hudson (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-9474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817521#comment-16817521
 ] 

Hudson commented on YARN-9474:
--

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #16407 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/16407/])
YARN-9474. Remove hard coded sleep from Opportunistic Scheduler tests. 
(inigoiri: rev 7a68e7abd51b9a0e25758e182eaa0a5cbbf13d87)
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/scheduler/TestOpportunisticContainerAllocator.java
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/TestOpportunisticContainerAllocatorAMService.java


> Remove hard coded sleep from Opportunistic Scheduler tests.
> ---
>
> Key: YARN-9474
> URL: https://issues.apache.org/jira/browse/YARN-9474
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Abhishek Modi
>Assignee: Abhishek Modi
>Priority: Major
> Fix For: 3.3.0
>
> Attachments: YARN-9474.001.patch, YARN-9474.002.patch
>
>
> Remove hard coded sleep from Opportunistic Scheduler tests and improve logs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-9474) Remove hard coded sleep from Opportunistic Scheduler tests.

2019-04-14 Thread Abhishek Modi (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-9474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817517#comment-16817517
 ] 

Abhishek Modi commented on YARN-9474:
-

Thanks [~elgoiri] for review and committing it.

> Remove hard coded sleep from Opportunistic Scheduler tests.
> ---
>
> Key: YARN-9474
> URL: https://issues.apache.org/jira/browse/YARN-9474
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Abhishek Modi
>Assignee: Abhishek Modi
>Priority: Major
> Fix For: 3.3.0
>
> Attachments: YARN-9474.001.patch, YARN-9474.002.patch
>
>
> Remove hard coded sleep from Opportunistic Scheduler tests and improve logs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-9474) Remove hard coded sleep from Opportunistic Scheduler tests.

2019-04-14 Thread JIRA 


[ 
https://issues.apache.org/jira/browse/YARN-9474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817516#comment-16817516
 ] 

Íñigo Goiri commented on YARN-9474:
---

Thanks [~abmodi] for the patch.
Committed to trunk.

> Remove hard coded sleep from Opportunistic Scheduler tests.
> ---
>
> Key: YARN-9474
> URL: https://issues.apache.org/jira/browse/YARN-9474
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Abhishek Modi
>Assignee: Abhishek Modi
>Priority: Major
> Fix For: 3.3.0
>
> Attachments: YARN-9474.001.patch, YARN-9474.002.patch
>
>
> Remove hard coded sleep from Opportunistic Scheduler tests and improve logs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-9474) Remove hard coded sleep from Opportunistic Scheduler tests.

2019-04-14 Thread JIRA 


[ 
https://issues.apache.org/jira/browse/YARN-9474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817509#comment-16817509
 ] 

Íñigo Goiri commented on YARN-9474:
---

+1 on  [^YARN-9474.002.patch].
Committing shortly.

> Remove hard coded sleep from Opportunistic Scheduler tests.
> ---
>
> Key: YARN-9474
> URL: https://issues.apache.org/jira/browse/YARN-9474
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Abhishek Modi
>Assignee: Abhishek Modi
>Priority: Major
> Attachments: YARN-9474.001.patch, YARN-9474.002.patch
>
>
> Remove hard coded sleep from Opportunistic Scheduler tests and improve logs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-9474) Remove hard coded sleep from Opportunistic Scheduler tests.

2019-04-13 Thread Abhishek Modi (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-9474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817176#comment-16817176
 ] 

Abhishek Modi commented on YARN-9474:
-

Assert for null for rmContaner is not required as we are doing the null check 
above and assigning it to new variable. That was a redundant Assert so removed 
it.

> Remove hard coded sleep from Opportunistic Scheduler tests.
> ---
>
> Key: YARN-9474
> URL: https://issues.apache.org/jira/browse/YARN-9474
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Abhishek Modi
>Assignee: Abhishek Modi
>Priority: Major
> Attachments: YARN-9474.001.patch, YARN-9474.002.patch
>
>
> Remove hard coded sleep from Opportunistic Scheduler tests and improve logs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-9474) Remove hard coded sleep from Opportunistic Scheduler tests.

2019-04-13 Thread JIRA 


[ 
https://issues.apache.org/jira/browse/YARN-9474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16817159#comment-16817159
 ] 

Íñigo Goiri commented on YARN-9474:
---

Should we keep the assert for null for rmContiner?
If so, we should switch it to {{assertNotNull()}}.

> Remove hard coded sleep from Opportunistic Scheduler tests.
> ---
>
> Key: YARN-9474
> URL: https://issues.apache.org/jira/browse/YARN-9474
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Abhishek Modi
>Assignee: Abhishek Modi
>Priority: Major
> Attachments: YARN-9474.001.patch, YARN-9474.002.patch
>
>
> Remove hard coded sleep from Opportunistic Scheduler tests and improve logs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-9474) Remove hard coded sleep from Opportunistic Scheduler tests.

2019-04-12 Thread Abhishek Modi (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-9474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816829#comment-16816829
 ] 

Abhishek Modi commented on YARN-9474:
-

Test failure and findbugs warnings are not related to this patch.

> Remove hard coded sleep from Opportunistic Scheduler tests.
> ---
>
> Key: YARN-9474
> URL: https://issues.apache.org/jira/browse/YARN-9474
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Abhishek Modi
>Assignee: Abhishek Modi
>Priority: Major
> Attachments: YARN-9474.001.patch, YARN-9474.002.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-9474) Remove hard coded sleep from Opportunistic Scheduler tests.

2019-04-12 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-9474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816670#comment-16816670
 ] 

Hadoop QA commented on YARN-9474:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
17s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
32s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 17m 
13s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 
47s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
 2s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 
26s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
13m 44s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m 
15s{color} | {color:red} 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
 in trunk has 2 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
58s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
13s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
13s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  2m 
39s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 
18s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
11m 27s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
43s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
34s{color} | {color:green} hadoop-yarn-server-common in the patch passed. 
{color} |
| {color:red}-1{color} | {color:red} unit {color} | {color:red} 78m 32s{color} 
| {color:red} hadoop-yarn-server-resourcemanager in the patch failed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
30s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}141m 26s{color} | 
{color:black} {color} |
\\
\\
|| Reason || Tests ||
| Failed junit tests | 
hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerPreemption |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:bdbca0e |
| JIRA Issue | YARN-9474 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12965747/YARN-9474.002.patch |
| Optional Tests |  dupname  asflicense  compile  javac  javadoc  mvninstall  
mvnsite  unit  shadedclient  findbugs  checkstyle  |
| uname | Linux c6191d3d4aef 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 0c1fec3 |
|

[jira] [Commented] (YARN-9474) Remove hard coded sleep from Opportunistic Scheduler tests.

2019-04-12 Thread Abhishek Modi (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-9474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816575#comment-16816575
 ] 

Abhishek Modi commented on YARN-9474:
-

Thanks [~elgoiri] for reviewing it. I have fixed the review comments in v2 
patch.

> Remove hard coded sleep from Opportunistic Scheduler tests.
> ---
>
> Key: YARN-9474
> URL: https://issues.apache.org/jira/browse/YARN-9474
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Abhishek Modi
>Assignee: Abhishek Modi
>Priority: Major
> Attachments: YARN-9474.001.patch, YARN-9474.002.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-9474) Remove hard coded sleep from Opportunistic Scheduler tests.

2019-04-12 Thread JIRA 


[ 
https://issues.apache.org/jira/browse/YARN-9474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816531#comment-16816531
 ] 

Íñigo Goiri commented on YARN-9474:
---

Thanks [~abmodi] for this, getting rid of sleeps is always good.

For the new log lines, can we use the full logger format? 
{{LOG.info("Containers: {}", containers);}}
For the waits, I would leave the timeout exception go through as the rest of 
the tests do; it's true it's a little verbose but it's clear.
In addition, in the waits we probably want to use lambdas:
{code}
GenericTestUtils.waitFor(() -> amservice.getLeastLoadedNodes().size() == 4);
{code}



> Remove hard coded sleep from Opportunistic Scheduler tests.
> ---
>
> Key: YARN-9474
> URL: https://issues.apache.org/jira/browse/YARN-9474
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Abhishek Modi
>Assignee: Abhishek Modi
>Priority: Major
> Attachments: YARN-9474.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-9474) Remove hard coded sleep from Opportunistic Scheduler tests.

2019-04-12 Thread Abhishek Modi (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-9474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816288#comment-16816288
 ] 

Abhishek Modi commented on YARN-9474:
-

Findbugs warning is unrelated to this change.

[~elgoiri] [~giovanni.fumarola] could you please review this. Thanks.

> Remove hard coded sleep from Opportunistic Scheduler tests.
> ---
>
> Key: YARN-9474
> URL: https://issues.apache.org/jira/browse/YARN-9474
> Project: Hadoop YARN
>  Issue Type: Sub-task
>Reporter: Abhishek Modi
>Assignee: Abhishek Modi
>Priority: Major
> Attachments: YARN-9474.001.patch
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org

[jira] [Commented] (YARN-9474) Remove hard coded sleep from Opportunistic Scheduler tests.

2019-04-12 Thread Hadoop QA (JIRA) 


[ 
https://issues.apache.org/jira/browse/YARN-9474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16816227#comment-16816227
 ] 

Hadoop QA commented on YARN-9474:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
18s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green}  0m 
 0s{color} | {color:green} The patch appears to include 2 new or modified test 
files. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
32s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 17m 
 0s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 
47s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  1m 
 1s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 
27s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
13m  4s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red}  1m 
12s{color} | {color:red} 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager
 in trunk has 2 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
45s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue}  0m 
10s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  1m 
10s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  2m 
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  2m 
37s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green}  0m 
49s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  1m 
12s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
11m  0s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} findbugs {color} | {color:green}  2m 
21s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
46s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  2m 
37s{color} | {color:green} hadoop-yarn-server-common in the patch passed. 
{color} |
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 77m 
58s{color} | {color:green} hadoop-yarn-server-resourcemanager in the patch 
passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
28s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black}139m  7s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:bdbca0e |
| JIRA Issue | YARN-9474 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12965702/YARN-9474.001.patch |
| Optional Tests |  dupname  asflicense  compile  javac  javadoc  mvninstall  
mvnsite  unit  shadedclient  findbugs  checkstyle  |
| uname | Linux ada21dae8146 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 
10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 75ba719 |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_191 |
| findbugs | v3.1.0-RC1 |
| findbugs |