[jira] [Commented] (YARN-9631) hadoop-yarn-applications-catalog-webapp doesn't respect mvn test -D parameter

2019-06-19 Thread Hudson (JIRA)


[ 
https://issues.apache.org/jira/browse/YARN-9631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868067#comment-16868067
 ] 

Hudson commented on YARN-9631:
--

FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #16793 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/16793/])
YARN-9631.  Added ability to select JavaScript test or skip JavaScript (eyang: 
rev 5bfdf62614735e09b67d6c70a0db4e0dbd2743b2)
* (edit) 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp/pom.xml


> hadoop-yarn-applications-catalog-webapp doesn't respect mvn test -D parameter
> -
>
> Key: YARN-9631
> URL: https://issues.apache.org/jira/browse/YARN-9631
> Project: Hadoop YARN
>  Issue Type: Improvement
>Affects Versions: 3.3.0
> Environment:  
>  
>Reporter: Wei-Chiu Chuang
>Assignee: Eric Yang
>Priority: Major
> Attachments: YARN-9631.001.patch, YARN-9631.002.patch, 
> YARN-9631.003.patch
>
>
> When I run a HDFS test {{mvn test -Dtest=TestMaintenanceState}} from the 
> Hadoop source code root, hadoop-yarn-applications-catalog-webapp doesn't 
> respect the test filter and always runs its tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-9631) hadoop-yarn-applications-catalog-webapp doesn't respect mvn test -D parameter

2019-06-19 Thread Wei-Chiu Chuang (JIRA)


[ 
https://issues.apache.org/jira/browse/YARN-9631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868062#comment-16868062
 ] 

Wei-Chiu Chuang commented on YARN-9631:
---

Spoke with [~eyang] offline, the approach is good +1.

There is a problem where the Jetty server starts but cannot be connected, which 
blocks. But Eric verified this is not an issue on other Mac/Linux machines, so 
most likely a local configuration problem (firewall or something)

> hadoop-yarn-applications-catalog-webapp doesn't respect mvn test -D parameter
> -
>
> Key: YARN-9631
> URL: https://issues.apache.org/jira/browse/YARN-9631
> Project: Hadoop YARN
>  Issue Type: Improvement
>Affects Versions: 3.3.0
> Environment:  
>  
>Reporter: Wei-Chiu Chuang
>Assignee: Eric Yang
>Priority: Major
> Attachments: YARN-9631.001.patch, YARN-9631.002.patch, 
> YARN-9631.003.patch
>
>
> When I run a HDFS test {{mvn test -Dtest=TestMaintenanceState}} from the 
> Hadoop source code root, hadoop-yarn-applications-catalog-webapp doesn't 
> respect the test filter and always runs its tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-9631) hadoop-yarn-applications-catalog-webapp doesn't respect mvn test -D parameter

2019-06-19 Thread Eric Yang (JIRA)


[ 
https://issues.apache.org/jira/browse/YARN-9631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868026#comment-16868026
 ] 

Eric Yang commented on YARN-9631:
-

To skip all tests:

{code}mvn package -DskipTests{code}

The result would be:

{code}
[INFO] --- maven-surefire-plugin:3.0.0-M1:test (default-test) @ 
hadoop-yarn-applications-catalog-webapp ---
[INFO] Tests are skipped.
[INFO] 
[INFO] --- jasmine-maven-plugin:2.1:test (default) @ 
hadoop-yarn-applications-catalog-webapp ---
[INFO] Skipping Jasmine Specs
{code}

There is no reason to use -Dtest and -DskipTests parameters together because 
they contradicts each other, and no test will be performed.

> hadoop-yarn-applications-catalog-webapp doesn't respect mvn test -D parameter
> -
>
> Key: YARN-9631
> URL: https://issues.apache.org/jira/browse/YARN-9631
> Project: Hadoop YARN
>  Issue Type: Improvement
>Affects Versions: 3.3.0
> Environment:  
>  
>Reporter: Wei-Chiu Chuang
>Assignee: Eric Yang
>Priority: Major
> Attachments: YARN-9631.001.patch, YARN-9631.002.patch, 
> YARN-9631.003.patch
>
>
> When I run a HDFS test {{mvn test -Dtest=TestMaintenanceState}} from the 
> Hadoop source code root, hadoop-yarn-applications-catalog-webapp doesn't 
> respect the test filter and always runs its tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-9631) hadoop-yarn-applications-catalog-webapp doesn't respect mvn test -D parameter

2019-06-19 Thread Eric Yang (JIRA)


[ 
https://issues.apache.org/jira/browse/YARN-9631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16868018#comment-16868018
 ] 

Eric Yang commented on YARN-9631:
-

[~jojochuang] Javascript tests can be skipped if there is no matching test case 
filename with -Dtest property by using:
{code}
mvn test -Dtest=TestMaintenanceState
{code}

The resulting output is:
{code}
---
 J A S M I N E   S P E C S
---
[INFO] 

Results: 0 specs, 0 failures, 0 pending
{code}

I don't think -DskipTests option needs to be specified, unless you wish to skip 
all tests.

> hadoop-yarn-applications-catalog-webapp doesn't respect mvn test -D parameter
> -
>
> Key: YARN-9631
> URL: https://issues.apache.org/jira/browse/YARN-9631
> Project: Hadoop YARN
>  Issue Type: Improvement
>Affects Versions: 3.3.0
> Environment:  
>  
>Reporter: Wei-Chiu Chuang
>Assignee: Eric Yang
>Priority: Major
> Attachments: YARN-9631.001.patch, YARN-9631.002.patch, 
> YARN-9631.003.patch
>
>
> When I run a HDFS test {{mvn test -Dtest=TestMaintenanceState}} from the 
> Hadoop source code root, hadoop-yarn-applications-catalog-webapp doesn't 
> respect the test filter and always runs its tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-9631) hadoop-yarn-applications-catalog-webapp doesn't respect mvn test -D parameter

2019-06-19 Thread Wei-Chiu Chuang (JIRA)


[ 
https://issues.apache.org/jira/browse/YARN-9631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867915#comment-16867915
 ] 

Wei-Chiu Chuang commented on YARN-9631:
---

Thank you Eric!
It seems like with this patch I would still need to specify the following in 
order to filter tests and skip the javascript tests.
{code:java}
mvn test -Dtest=TestMaintenanceState -DskipTests
{code}

IMHO this is a little confusing because I would have expected -DskipTests would 
skip all tests. What do you think?

> hadoop-yarn-applications-catalog-webapp doesn't respect mvn test -D parameter
> -
>
> Key: YARN-9631
> URL: https://issues.apache.org/jira/browse/YARN-9631
> Project: Hadoop YARN
>  Issue Type: Improvement
>Affects Versions: 3.3.0
> Environment:  
>  
>Reporter: Wei-Chiu Chuang
>Assignee: Eric Yang
>Priority: Major
> Attachments: YARN-9631.001.patch, YARN-9631.002.patch, 
> YARN-9631.003.patch
>
>
> When I run a HDFS test {{mvn test -Dtest=TestMaintenanceState}} from the 
> Hadoop source code root, hadoop-yarn-applications-catalog-webapp doesn't 
> respect the test filter and always runs its tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-9631) hadoop-yarn-applications-catalog-webapp doesn't respect mvn test -D parameter

2019-06-18 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/YARN-9631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866930#comment-16866930
 ] 

Hadoop QA commented on YARN-9631:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  0m 
20s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 20m 
11s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
41s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
42s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
32m 46s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
19s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
36s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
38s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
12m 58s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
17s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  0m 
54s{color} | {color:green} hadoop-yarn-applications-catalog-webapp in the patch 
passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
33s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 51m  2s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:bdbca0e |
| JIRA Issue | YARN-9631 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12972126/YARN-9631.003.patch |
| Optional Tests |  dupname  asflicense  compile  javac  javadoc  mvninstall  
mvnsite  unit  shadedclient  xml  |
| uname | Linux 9bbd2b91f9f9 4.4.0-144-generic #170~14.04.1-Ubuntu SMP Mon Mar 
18 15:02:05 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / 3c1a1ce |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_212 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/24284/testReport/ |
| Max. process+thread count | 307 (vs. ulimit of 1) |
| modules | C: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp
 U: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp
 |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/24284/console |
| Powered by | Apache Yetus 0.8.0   http://yetus.apache.org |


This message was automatically generated.



> hadoop-yarn-applications-catalog-webapp doesn't respect mvn test -D parameter
> -
>
> Key: YARN-9631
> URL: 

[jira] [Commented] (YARN-9631) hadoop-yarn-applications-catalog-webapp doesn't respect mvn test -D parameter

2019-06-18 Thread Eric Yang (JIRA)


[ 
https://issues.apache.org/jira/browse/YARN-9631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866883#comment-16866883
 ] 

Eric Yang commented on YARN-9631:
-

[~jojochuang] Patch 003 will allow controlling javascript tests using 
-DskipTests and -Dtest= flag to be more aligned with surefire plugin working 
model.  Thanks for the suggestion.

> hadoop-yarn-applications-catalog-webapp doesn't respect mvn test -D parameter
> -
>
> Key: YARN-9631
> URL: https://issues.apache.org/jira/browse/YARN-9631
> Project: Hadoop YARN
>  Issue Type: Improvement
>Affects Versions: 3.3.0
> Environment:  
>  
>Reporter: Wei-Chiu Chuang
>Assignee: Eric Yang
>Priority: Major
> Attachments: YARN-9631.001.patch, YARN-9631.002.patch, 
> YARN-9631.003.patch
>
>
> When I run a HDFS test {{mvn test -Dtest=TestMaintenanceState}} from the 
> Hadoop source code root, hadoop-yarn-applications-catalog-webapp doesn't 
> respect the test filter and always runs its tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-9631) hadoop-yarn-applications-catalog-webapp doesn't respect mvn test -D parameter

2019-06-17 Thread Eric Yang (JIRA)


[ 
https://issues.apache.org/jira/browse/YARN-9631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866126#comment-16866126
 ] 

Eric Yang commented on YARN-9631:
-

On the second thought, I think we can map skipTests to skipJsTests to eliminate 
the need to introduce yet another flag, and make javascript tests to adopt the 
same working model as surefire plugin triggered tests.

> hadoop-yarn-applications-catalog-webapp doesn't respect mvn test -D parameter
> -
>
> Key: YARN-9631
> URL: https://issues.apache.org/jira/browse/YARN-9631
> Project: Hadoop YARN
>  Issue Type: Improvement
>Affects Versions: 3.3.0
> Environment:  
>  
>Reporter: Wei-Chiu Chuang
>Assignee: Eric Yang
>Priority: Major
> Attachments: YARN-9631.001.patch, YARN-9631.002.patch
>
>
> When I run a HDFS test {{mvn test -Dtest=TestMaintenanceState}} from the 
> Hadoop source code root, hadoop-yarn-applications-catalog-webapp doesn't 
> respect the test filter and always runs its tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-9631) hadoop-yarn-applications-catalog-webapp doesn't respect mvn test -D parameter

2019-06-17 Thread Hadoop QA (JIRA)


[ 
https://issues.apache.org/jira/browse/YARN-9631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866113#comment-16866113
 ] 

Hadoop QA commented on YARN-9631:
-

| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | {color:blue} reexec {color} | {color:blue}  1m 
15s{color} | {color:blue} Docker mode activated. {color} |
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green}  0m  
0s{color} | {color:green} The patch does not contain any @author tags. {color} |
| {color:red}-1{color} | {color:red} test4tests {color} | {color:red}  0m  
0s{color} | {color:red} The patch doesn't appear to include any new or modified 
tests. Please justify why no new tests are needed for this patch. Also please 
list what manual steps were performed to verify this patch. {color} |
|| || || || {color:brown} trunk Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 29m 
 5s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
49s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
57s{color} | {color:green} trunk passed {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
44m 25s{color} | {color:green} branch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
27s{color} | {color:green} trunk passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green}  0m 
46s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green}  0m 
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green}  0m 
42s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} mvnsite {color} | {color:green}  0m 
40s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} whitespace {color} | {color:green}  0m 
 0s{color} | {color:green} The patch has no whitespace issues. {color} |
| {color:green}+1{color} | {color:green} xml {color} | {color:green}  0m  
1s{color} | {color:green} The patch has no ill-formed XML file. {color} |
| {color:green}+1{color} | {color:green} shadedclient {color} | {color:green} 
14m 58s{color} | {color:green} patch has no errors when building and testing 
our client artifacts. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green}  0m 
22s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green}  1m 
11s{color} | {color:green} hadoop-yarn-applications-catalog-webapp in the patch 
passed. {color} |
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green}  0m 
37s{color} | {color:green} The patch does not generate ASF License warnings. 
{color} |
| {color:black}{color} | {color:black} {color} | {color:black} 66m 38s{color} | 
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Docker | Client=18.09.5 Server=18.09.5 Image:yetus/hadoop:bdbca0e53b4 |
| JIRA Issue | YARN-9631 |
| JIRA Patch URL | 
https://issues.apache.org/jira/secure/attachment/12972023/YARN-9631.002.patch |
| Optional Tests |  dupname  asflicense  compile  javac  javadoc  mvninstall  
mvnsite  unit  shadedclient  xml  |
| uname | Linux eb51b3500af6 4.15.0-48-generic #51-Ubuntu SMP Wed Apr 3 
08:28:49 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / a95e87d |
| maven | version: Apache Maven 3.3.9 |
| Default Java | 1.8.0_212 |
|  Test Results | 
https://builds.apache.org/job/PreCommit-YARN-Build/24278/testReport/ |
| Max. process+thread count | 307 (vs. ulimit of 5500) |
| modules | C: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp
 U: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-applications/hadoop-yarn-applications-catalog/hadoop-yarn-applications-catalog-webapp
 |
| Console output | 
https://builds.apache.org/job/PreCommit-YARN-Build/24278/console |
| Powered by | Apache Yetus 0.8.0   http://yetus.apache.org |


This message was automatically generated.



> hadoop-yarn-applications-catalog-webapp doesn't respect mvn test -D parameter
> -
>
> Key: YARN-9631
> URL: 

[jira] [Commented] (YARN-9631) hadoop-yarn-applications-catalog-webapp doesn't respect mvn test -D parameter

2019-06-17 Thread Eric Yang (JIRA)


[ 
https://issues.apache.org/jira/browse/YARN-9631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866081#comment-16866081
 ] 

Eric Yang commented on YARN-9631:
-

[~jojochuang] Patch 002 made some improvement to allow test property to map to 
JavaScript test.

> hadoop-yarn-applications-catalog-webapp doesn't respect mvn test -D parameter
> -
>
> Key: YARN-9631
> URL: https://issues.apache.org/jira/browse/YARN-9631
> Project: Hadoop YARN
>  Issue Type: Improvement
>Affects Versions: 3.3.0
> Environment:  
>  
>Reporter: Wei-Chiu Chuang
>Priority: Major
> Attachments: YARN-9631.001.patch, YARN-9631.002.patch
>
>
> When I run a HDFS test {{mvn test -Dtest=TestMaintenanceState}} from the 
> Hadoop source code root, hadoop-yarn-applications-catalog-webapp doesn't 
> respect the test filter and always runs its tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-9631) hadoop-yarn-applications-catalog-webapp doesn't respect mvn test -D parameter

2019-06-17 Thread Wei-Chiu Chuang (JIRA)


[ 
https://issues.apache.org/jira/browse/YARN-9631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866062#comment-16866062
 ] 

Wei-Chiu Chuang commented on YARN-9631:
---

Thank you [~eyang] agree I should have moved under hdfs codebase to run the 
tests.

A skipJsTests sounds good to me.

> hadoop-yarn-applications-catalog-webapp doesn't respect mvn test -D parameter
> -
>
> Key: YARN-9631
> URL: https://issues.apache.org/jira/browse/YARN-9631
> Project: Hadoop YARN
>  Issue Type: Improvement
>Affects Versions: 3.3.0
> Environment:  
>  
>Reporter: Wei-Chiu Chuang
>Priority: Major
> Attachments: YARN-9631.001.patch
>
>
> When I run a HDFS test {{mvn test -Dtest=TestMaintenanceState}} from the 
> Hadoop source code root, hadoop-yarn-applications-catalog-webapp doesn't 
> respect the test filter and always runs its tests.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org



[jira] [Commented] (YARN-9631) hadoop-yarn-applications-catalog-webapp doesn't respect mvn test -D parameter

2019-06-17 Thread Eric Yang (JIRA)


[ 
https://issues.apache.org/jira/browse/YARN-9631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866054#comment-16866054
 ] 

Eric Yang commented on YARN-9631:
-

[~jojochuang], test property flag is honored by Maven Surefire plugin.  
Hadoop-yarn-application-catalog does respect mvn test parameter for Java based 
test cases according to my local testing.  However, there is test cases written 
in another language (i.e. javascript), which does not know about Surefire 
plugin test property flag concept.  This is the reason some test cases get 
triggered.  Hadoop C++ code can also trigger non-related test cases to run with 
test flag is given.

Maven encourages to trigger as many test to run as possible for new developer 
that start with mvn clean package command to ensure that we have wide coverage 
of tests by default.  If this gets in the way of your development efficiency, 
then I would recommend to make builds from hadoop-hdfs-project to prevent 
non-related test case from trigger.  This may save huge amount of time for 
working on smaller set instead of always having to build from global.

Alternatively, I can also propose a new flag to skip javascript related test, 
such as:
{code:java}
mvn clean test -DskipJsTests -Dtest=TestMaintenanceState{code}
If this is what you prefer.

> hadoop-yarn-applications-catalog-webapp doesn't respect mvn test -D parameter
> -
>
> Key: YARN-9631
> URL: https://issues.apache.org/jira/browse/YARN-9631
> Project: Hadoop YARN
>  Issue Type: Improvement
>Affects Versions: 3.3.0
> Environment: When I run a HDFS test {{mvn test 
> -Dtest=TestMaintenanceState}} from the Hadoop source code root, 
> hadoop-yarn-applications-catalog-webapp doesn't respect the test filter and 
> always runs its tests.
>Reporter: Wei-Chiu Chuang
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

-
To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org