[jira] [Commented] (YARN-2042) String shouldn't be compared using == in QueuePlacementRule#NestedUserQueue#getQueueForApp()

2014-05-16 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998999#comment-13998999
 ] 

Hudson commented on YARN-2042:
--

SUCCESS: Integrated in Hadoop-trunk-Commit #5605 (See 
[https://builds.apache.org/job/Hadoop-trunk-Commit/5605/])
YARN-2042. String shouldn't be compared using == in 
QueuePlacementRule#NestedUserQueue#getQueueForApp (Chen He via Sandy Ryza) 
(sandy: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1594482)
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueuePlacementRule.java


> String shouldn't be compared using == in 
> QueuePlacementRule#NestedUserQueue#getQueueForApp()
> 
>
> Key: YARN-2042
> URL: https://issues.apache.org/jira/browse/YARN-2042
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Chen He
>Priority: Minor
> Attachments: YARN-2042.patch
>
>
> {code}
>   if (queueName != null && queueName != "") {
> {code}
> queueName.isEmpty() should be used instead of comparing against ""



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (YARN-2042) String shouldn't be compared using == in QueuePlacementRule#NestedUserQueue#getQueueForApp()

2014-05-15 Thread Henry Saputra (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13996665#comment-13996665
 ] 

Henry Saputra commented on YARN-2042:
-

+1 for the patch

> String shouldn't be compared using == in 
> QueuePlacementRule#NestedUserQueue#getQueueForApp()
> 
>
> Key: YARN-2042
> URL: https://issues.apache.org/jira/browse/YARN-2042
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Chen He
>Priority: Minor
> Attachments: YARN-2042.patch
>
>
> {code}
>   if (queueName != null && queueName != "") {
> {code}
> queueName.isEmpty() should be used instead of comparing against ""



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (YARN-2042) String shouldn't be compared using == in QueuePlacementRule#NestedUserQueue#getQueueForApp()

2014-05-15 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998205#comment-13998205
 ] 

Hudson commented on YARN-2042:
--

FAILURE: Integrated in Hadoop-Hdfs-trunk #1753 (See 
[https://builds.apache.org/job/Hadoop-Hdfs-trunk/1753/])
YARN-2042. String shouldn't be compared using == in 
QueuePlacementRule#NestedUserQueue#getQueueForApp (Chen He via Sandy Ryza) 
(sandy: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1594482)
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueuePlacementRule.java


> String shouldn't be compared using == in 
> QueuePlacementRule#NestedUserQueue#getQueueForApp()
> 
>
> Key: YARN-2042
> URL: https://issues.apache.org/jira/browse/YARN-2042
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Chen He
>Priority: Minor
> Attachments: YARN-2042.patch
>
>
> {code}
>   if (queueName != null && queueName != "") {
> {code}
> queueName.isEmpty() should be used instead of comparing against ""



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (YARN-2042) String shouldn't be compared using == in QueuePlacementRule#NestedUserQueue#getQueueForApp()

2014-05-15 Thread Hudson (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13998167#comment-13998167
 ] 

Hudson commented on YARN-2042:
--

FAILURE: Integrated in Hadoop-Mapreduce-trunk #1779 (See 
[https://builds.apache.org/job/Hadoop-Mapreduce-trunk/1779/])
YARN-2042. String shouldn't be compared using == in 
QueuePlacementRule#NestedUserQueue#getQueueForApp (Chen He via Sandy Ryza) 
(sandy: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1594482)
* /hadoop/common/trunk/hadoop-yarn-project/CHANGES.txt
* 
/hadoop/common/trunk/hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/fair/QueuePlacementRule.java


> String shouldn't be compared using == in 
> QueuePlacementRule#NestedUserQueue#getQueueForApp()
> 
>
> Key: YARN-2042
> URL: https://issues.apache.org/jira/browse/YARN-2042
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Chen He
>Priority: Minor
> Attachments: YARN-2042.patch
>
>
> {code}
>   if (queueName != null && queueName != "") {
> {code}
> queueName.isEmpty() should be used instead of comparing against ""



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (YARN-2042) String shouldn't be compared using == in QueuePlacementRule#NestedUserQueue#getQueueForApp()

2014-05-14 Thread Sandy Ryza (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13997334#comment-13997334
 ] 

Sandy Ryza commented on YARN-2042:
--

+1

> String shouldn't be compared using == in 
> QueuePlacementRule#NestedUserQueue#getQueueForApp()
> 
>
> Key: YARN-2042
> URL: https://issues.apache.org/jira/browse/YARN-2042
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Chen He
>Priority: Minor
> Attachments: YARN-2042.patch
>
>
> {code}
>   if (queueName != null && queueName != "") {
> {code}
> queueName.isEmpty() should be used instead of comparing against ""



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (YARN-2042) String shouldn't be compared using == in QueuePlacementRule#NestedUserQueue#getQueueForApp()

2014-05-12 Thread Chen He (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13995505#comment-13995505
 ] 

Chen He commented on YARN-2042:
---

The change in this patch does not need to include test.

> String shouldn't be compared using == in 
> QueuePlacementRule#NestedUserQueue#getQueueForApp()
> 
>
> Key: YARN-2042
> URL: https://issues.apache.org/jira/browse/YARN-2042
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Chen He
>Priority: Minor
> Attachments: YARN-2042.patch
>
>
> {code}
>   if (queueName != null && queueName != "") {
> {code}
> queueName.isEmpty() should be used instead of comparing against ""



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (YARN-2042) String shouldn't be compared using == in QueuePlacementRule#NestedUserQueue#getQueueForApp()

2014-05-12 Thread Hadoop QA (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13995485#comment-13995485
 ] 

Hadoop QA commented on YARN-2042:
-

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12644357/YARN-2042.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
Please justify why no new tests are needed for this 
patch.
Also please list what manual steps were performed to 
verify this patch.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

{color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

{color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager.

{color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-YARN-Build/3732//testReport/
Console output: https://builds.apache.org/job/PreCommit-YARN-Build/3732//console

This message is automatically generated.

> String shouldn't be compared using == in 
> QueuePlacementRule#NestedUserQueue#getQueueForApp()
> 
>
> Key: YARN-2042
> URL: https://issues.apache.org/jira/browse/YARN-2042
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Chen He
>Priority: Minor
> Attachments: YARN-2042.patch
>
>
> {code}
>   if (queueName != null && queueName != "") {
> {code}
> queueName.isEmpty() should be used instead of comparing against ""



--
This message was sent by Atlassian JIRA
(v6.2#6252)

[jira] [Commented] (YARN-2042) String shouldn't be compared using == in QueuePlacementRule#NestedUserQueue#getQueueForApp()

2014-05-11 Thread Chen He (JIRA) 

[ 
https://issues.apache.org/jira/browse/YARN-2042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13994683#comment-13994683
 ] 

Chen He commented on YARN-2042:
---

string.isEmpty() is supported by Java 1.6 and later. For compatibility, 
"string.length != 0" may be  the most efficient way. Patch is provided.

> String shouldn't be compared using == in 
> QueuePlacementRule#NestedUserQueue#getQueueForApp()
> 
>
> Key: YARN-2042
> URL: https://issues.apache.org/jira/browse/YARN-2042
> Project: Hadoop YARN
>  Issue Type: Bug
>Reporter: Ted Yu
>Assignee: Chen He
>Priority: Minor
> Attachments: YARN-2042.patch
>
>
> {code}
>   if (queueName != null && queueName != "") {
> {code}
> queueName.isEmpty() should be used instead of comparing against ""



--
This message was sent by Atlassian JIRA
(v6.2#6252)