[jira] [Commented] (YARN-2767) RM web services - add test case to ensure the http static user can kill or submit apps in secure mode
[ https://issues.apache.org/jira/browse/YARN-2767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14192944#comment-14192944 ] Hadoop QA commented on YARN-2767: - {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12678652/apache-yarn-2767.2.patch against trunk revision 260ab6d. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/5675//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5675//console This message is automatically generated. > RM web services - add test case to ensure the http static user can kill or > submit apps in secure mode > - > > Key: YARN-2767 > URL: https://issues.apache.org/jira/browse/YARN-2767 > Project: Hadoop YARN > Issue Type: Test > Components: resourcemanager >Reporter: Varun Vasudev >Assignee: Varun Vasudev > Attachments: apache-yarn-2767.0.patch, apache-yarn-2767.1.patch, > apache-yarn-2767.2.patch > > > We should add a test to ensure that the http static user used to access the > RM web interface can't submit or kill apps if the cluster is running in > secure mode. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2767) RM web services - add test case to ensure the http static user can kill or submit apps in secure mode
[ https://issues.apache.org/jira/browse/YARN-2767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14192761#comment-14192761 ] Zhijie Shen commented on YARN-2767: --- [~vvasudev], thanks for the patch. The test cases look good. Just some minor comments for code refactoring: 1. Use Assert.fail()? {code} assertTrue("Couldn't create MiniKDC", false); {code} 2. miniKDCStarted is not necessary. {code} miniKDCStarted = true; {code} 3. It seems not to be necessary. Maybe we can refactor the code of setUp(). {code} private static MiniKdc getKdc() { return testMiniKDC; } {code} > RM web services - add test case to ensure the http static user can kill or > submit apps in secure mode > - > > Key: YARN-2767 > URL: https://issues.apache.org/jira/browse/YARN-2767 > Project: Hadoop YARN > Issue Type: Test > Components: resourcemanager >Reporter: Varun Vasudev >Assignee: Varun Vasudev > Attachments: apache-yarn-2767.0.patch, apache-yarn-2767.1.patch > > > We should add a test to ensure that the http static user used to access the > RM web interface can't submit or kill apps if the cluster is running in > secure mode. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2767) RM web services - add test case to ensure the http static user can kill or submit apps in secure mode
[ https://issues.apache.org/jira/browse/YARN-2767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14188182#comment-14188182 ] Hadoop QA commented on YARN-2767: - {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12677848/apache-yarn-2767.1.patch against trunk revision ec63a3f. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/5623//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5623//console This message is automatically generated. > RM web services - add test case to ensure the http static user can kill or > submit apps in secure mode > - > > Key: YARN-2767 > URL: https://issues.apache.org/jira/browse/YARN-2767 > Project: Hadoop YARN > Issue Type: Test > Components: resourcemanager >Reporter: Varun Vasudev >Assignee: Varun Vasudev > Attachments: apache-yarn-2767.0.patch, apache-yarn-2767.1.patch > > > We should add a test to ensure that the http static user used to access the > RM web interface can't submit or kill apps if the cluster is running in > secure mode. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-2767) RM web services - add test case to ensure the http static user can kill or submit apps in secure mode
[ https://issues.apache.org/jira/browse/YARN-2767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14188127#comment-14188127 ] Hadoop QA commented on YARN-2767: - {color:green}+1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12677839/apache-yarn-2767.0.patch against trunk revision ec63a3f. {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 1 new or modified test files. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:green}+1 javadoc{color}. There were no new javadoc warning messages. {color:green}+1 eclipse:eclipse{color}. The patch built with eclipse:eclipse. {color:green}+1 findbugs{color}. The patch does not introduce any new Findbugs (version 2.0.3) warnings. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:green}+1 core tests{color}. The patch passed unit tests in hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager. {color:green}+1 contrib tests{color}. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-YARN-Build/5621//testReport/ Console output: https://builds.apache.org/job/PreCommit-YARN-Build/5621//console This message is automatically generated. > RM web services - add test case to ensure the http static user can kill or > submit apps in secure mode > - > > Key: YARN-2767 > URL: https://issues.apache.org/jira/browse/YARN-2767 > Project: Hadoop YARN > Issue Type: Test > Components: resourcemanager >Reporter: Varun Vasudev >Assignee: Varun Vasudev > Attachments: apache-yarn-2767.0.patch > > > We should add a test to ensure that the http static user used to access the > RM web interface can't submit or kill apps if the cluster is running in > secure mode. -- This message was sent by Atlassian JIRA (v6.3.4#6332)