[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369808#comment-15369808 ] Hudson commented on YARN-3411: -- SUCCESS: Integrated in Hadoop-trunk-Commit #10074 (See [https

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14571607#comment-14571607 ] Vrushali C commented on YARN-3411: -- After evaluating both approaches of backend storage im

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14561741#comment-14561741 ] Varun Saxena commented on YARN-3411: [~zjshen], I was actually talking about store inse

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14561739#comment-14561739 ] Varun Saxena commented on YARN-3411: [~zjshen], I was actually talking about store inse

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14561682#comment-14561682 ] Zhijie Shen commented on YARN-3411: --- Yeah, in v1, there's a starttime for entity, which i

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14561659#comment-14561659 ] Varun Saxena commented on YARN-3411: In ATSv1, we consider the timestamp when entity is

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555133#comment-14555133 ] Junping Du commented on YARN-3411: -- Excellent work! Thanks [~vrushalic], [~sjlee0] and all

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555056#comment-14555056 ] Sangjin Lee commented on YARN-3411: --- Just committed the patch. Thanks much [~vrushalic] f

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554968#comment-14554968 ] Sangjin Lee commented on YARN-3411: --- Any other review feedback? > [Storage implementatio

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554959#comment-14554959 ] Vrushali C commented on YARN-3411: -- Thanks [~djp], filed YARN-3699 for the flow version d

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554877#comment-14554877 ] Junping Du commented on YARN-3411: -- Address 2nd one in YARN-3696 also sounds good. > [Sto

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554868#comment-14554868 ] Vrushali C commented on YARN-3411: -- Sounds good, done > [Storage implementation] explore

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554855#comment-14554855 ] Junping Du commented on YARN-3411: -- Thanks [~jrottinghuis] for comments! bq. I think it is

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554820#comment-14554820 ] Sangjin Lee commented on YARN-3411: --- [~vrushalic], how about making YARN-3696 a little br

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554803#comment-14554803 ] Junping Du commented on YARN-3411: -- Sounds like a plan. I think we need a separated JIRA t

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554794#comment-14554794 ] Junping Du commented on YARN-3411: -- bq. While I was discussing the patches with Joep Rotti

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554787#comment-14554787 ] Junping Du commented on YARN-3411: -- I see. Thanks for sharing this background. I agree tha

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554786#comment-14554786 ] Junping Du commented on YARN-3411: -- I see. Thanks for sharing this background. I agree tha

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554690#comment-14554690 ] Li Lu commented on YARN-3411: - Sorry about the delayed reply. Firstly, I thought flowVersion wa

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554606#comment-14554606 ] Joep Rottinghuis commented on YARN-3411: With respect to discussion on auto-creatin

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554599#comment-14554599 ] Sangjin Lee commented on YARN-3411: --- This constructor ({{HBaseTimelineWriterImpl(Configur

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554595#comment-14554595 ] Joep Rottinghuis commented on YARN-3411: I think it is reasonable that two implemen

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554586#comment-14554586 ] Sangjin Lee commented on YARN-3411: --- [~djp], I understand your concern on this. That said

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554544#comment-14554544 ] Vrushali C commented on YARN-3411: -- Yes, I in fact filed a jira https://issues.apache.org/

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554532#comment-14554532 ] Vrushali C commented on YARN-3411: -- HI [~djp] Thanks, appreciate your review very much! b

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554521#comment-14554521 ] Vrushali C commented on YARN-3411: -- Hi [~djp] I understand your point. The schema between

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554268#comment-14554268 ] Junping Du commented on YARN-3411: -- Beside the major comment above, some minor comments ov

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554142#comment-14554142 ] Junping Du commented on YARN-3411: -- Hi [~vrushalic], I had the same concern with [~zjshen]

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554076#comment-14554076 ] Junping Du commented on YARN-3411: -- Automation is a good point. However, the other point i

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14554063#comment-14554063 ] Junping Du commented on YARN-3411: -- Sure. The plan sounds good to me. Just make sure we ke

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14553369#comment-14553369 ] Li Lu commented on YARN-3411: - I looked at the latest patch and think it's in a good shape for

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14553370#comment-14553370 ] Sangjin Lee commented on YARN-3411: --- The latest patch LGTM. I'm fine with having a follow

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14553352#comment-14553352 ] Vrushali C commented on YARN-3411: -- bq. Or we cannot diff value with null and real 0. Hi

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14553353#comment-14553353 ] Vrushali C commented on YARN-3411: -- bq. Or we cannot diff value with null and real 0. Hi

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14553302#comment-14553302 ] Hadoop QA commented on YARN-3411: - \\ \\ | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14553186#comment-14553186 ] Li Lu commented on YARN-3411: - Hi [~vrushalic], sure, don't worry about the test code clean up

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14551251#comment-14551251 ] Vrushali C commented on YARN-3411: -- Thanks [~gtCarrera9]! Will make the access modifier ch

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14551238#comment-14551238 ] Li Lu commented on YARN-3411: - Hi [~vrushalic], thanks for working on this! I just got back and

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14551018#comment-14551018 ] Zhijie Shen commented on YARN-3411: --- bq. A flow can be uniquely identified with the flow

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14550858#comment-14550858 ] Vrushali C commented on YARN-3411: -- Thanks [~djp] ! I will make these changes.. > [Stora

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14550733#comment-14550733 ] Junping Du commented on YARN-3411: -- bq. Regarding the public/private annotations, I often

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14550717#comment-14550717 ] Karthik Kambatla commented on YARN-3411: By classes I meant outer classes. Inner cl

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14550714#comment-14550714 ] Karthik Kambatla commented on YARN-3411: My recommendation regarding visibility ann

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14550688#comment-14550688 ] Junping Du commented on YARN-3411: -- bq. I was thinking it is not necessary since the entit

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14550686#comment-14550686 ] Sangjin Lee commented on YARN-3411: --- Regarding the public/private annotations, I often go

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14550660#comment-14550660 ] Vrushali C commented on YARN-3411: -- Hi [~zjshen] Thanks for the review! bq I saw in HBas

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14549848#comment-14549848 ] Zhijie Shen commented on YARN-3411: --- [~vrushalic], thanks for working on the patch. Some

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14549776#comment-14549776 ] Sangjin Lee commented on YARN-3411: --- Or, better: {code} Configuration hbaseConf = HBaseC

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14549725#comment-14549725 ] Hadoop QA commented on YARN-3411: - \\ \\ | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14549692#comment-14549692 ] Sangjin Lee commented on YARN-3411: --- It seems like the line that adds the hbase configura

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14549664#comment-14549664 ] Hadoop QA commented on YARN-3411: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14549631#comment-14549631 ] Vrushali C commented on YARN-3411: -- Updating the code now to fix the javadoc warning and

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14549601#comment-14549601 ] Hadoop QA commented on YARN-3411: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14549563#comment-14549563 ] Sangjin Lee commented on YARN-3411: --- Thanks for updating the patch [~vrushalic]! A couple

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14548383#comment-14548383 ] Vrushali C commented on YARN-3411: -- The patch has an overall -1 due to a couple of javado

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14548379#comment-14548379 ] Vrushali C commented on YARN-3411: -- Hi [~djp] Thanks for the initial quick feedback! Some

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14548335#comment-14548335 ] Junping Du commented on YARN-3411: -- bq. No, we will never drop the last value. MIN_VERSION

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14547959#comment-14547959 ] Hadoop QA commented on YARN-3411: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14547730#comment-14547730 ] Hadoop QA commented on YARN-3411: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546176#comment-14546176 ] Vrushali C commented on YARN-3411: -- Hi [~jrottinghuis] Thanks for the review! My response

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14546166#comment-14546166 ] Vrushali C commented on YARN-3411: -- Hi [~djp] Thanks for the review! bq. In our case, the

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545857#comment-14545857 ] Li Lu commented on YARN-3411: - Hi [~djp]! I totally agree with your concerns. However, for now

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14545788#comment-14545788 ] Junping Du commented on YARN-3411: -- Hi [~vrushalic] and all, there is one question I had f

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544756#comment-14544756 ] Vrushali C commented on YARN-3411: -- Thanks [~sjlee0] and [~jrottinghuis] for the feedback

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544692#comment-14544692 ] Joep Rottinghuis commented on YARN-3411: Ok, admitted that I have not yet read Sang

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544659#comment-14544659 ] Sangjin Lee commented on YARN-3411: --- The latest patch looks pretty good. I think we're al

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544612#comment-14544612 ] Hadoop QA commented on YARN-3411: - \\ \\ | (/) *{color:green}+1 overall{color}* | \\ \\ ||

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14544190#comment-14544190 ] Sangjin Lee commented on YARN-3411: --- Vrushali and I spoke offline on the findbugs issues

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14543353#comment-14543353 ] Hadoop QA commented on YARN-3411: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14542980#comment-14542980 ] Sangjin Lee commented on YARN-3411: --- Here is some quick initial feedback: (HBaseTimeline

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14542950#comment-14542950 ] Sangjin Lee commented on YARN-3411: --- [~vrushalic], could you ensure the patch applies cle

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14542919#comment-14542919 ] Hadoop QA commented on YARN-3411: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14541730#comment-14541730 ] Junping Du commented on YARN-3411: -- Sure. Cancel the patch until we have new version. Thx!

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540383#comment-14540383 ] Vrushali C commented on YARN-3411: -- Sounds good, thanks [~djp]! But, would like to request

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540373#comment-14540373 ] Junping Du commented on YARN-3411: -- Sure. I start this rounds of review start several days

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540303#comment-14540303 ] Vrushali C commented on YARN-3411: -- bq. Also comments on latest (v5) patch Thanks [~djp] f

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540297#comment-14540297 ] Vrushali C commented on YARN-3411: -- Ah, I haven't added that patch, thanks [~gtCarrera9] l

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540220#comment-14540220 ] Junping Du commented on YARN-3411: -- Also comments on latest (v5) patch: {code} +public cla

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540211#comment-14540211 ] Li Lu commented on YARN-3411: - Hi [~vrushalic], sorry to hear the trouble. Have you tried to ap

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540078#comment-14540078 ] Junping Du commented on YARN-3411: -- PHOENIX-1757 should fix this problem, but the target r

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14540035#comment-14540035 ] Junping Du commented on YARN-3411: -- Sorry. I mean I met a similar problem before which is

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539552#comment-14539552 ] Junping Du commented on YARN-3411: -- bq. I get "Some Enforcer rules have failed" errors.

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539425#comment-14539425 ] Hadoop QA commented on YARN-3411: - \\ \\ | (x) *{color:red}-1 overall{color}* | \\ \\ || Vo

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14539303#comment-14539303 ] Vrushali C commented on YARN-3411: -- Yes, great to have the Phoenix patch in! I am updating

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14536225#comment-14536225 ] Sangjin Lee commented on YARN-3411: --- Thanks [~vrushalic] for the latest patch. I took a q

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533604#comment-14533604 ] Junping Du commented on YARN-3411: -- Thank you, [~vrushalic]! :) > [Storage implementation

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14533033#comment-14533033 ] Vrushali C commented on YARN-3411: -- bq. Given there is only very limited Ruby code in curr

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14532992#comment-14532992 ] Junping Du commented on YARN-3411: -- Thanks [~vrushalic] for updating the patch. I will rev

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14530990#comment-14530990 ] Vrushali C commented on YARN-3411: -- update: I will generate another patch, thanks [~gtCarr

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14522569#comment-14522569 ] Sangjin Lee commented on YARN-3411: --- +1 on 1.0.1. > [Storage implementation] explore the

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14522556#comment-14522556 ] Li Lu commented on YARN-3411: - Awesome, thanks! > [Storage implementation] explore the native

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14522539#comment-14522539 ] Li Lu commented on YARN-3411: - Hi [~vrushalic], one quick thing: do you have a rough estimation

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520291#comment-14520291 ] Li Lu commented on YARN-3411: - Hi [~vrushalic] [~zjshen], just a quick thing to confirm that we

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14520115#comment-14520115 ] Li Lu commented on YARN-3411: - Thanks [~stack] for the quick info! Yes let's go with HBase 1. W

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14519858#comment-14519858 ] stack commented on YARN-3411: - bq. So there are some major changes between hbase 0.98 and hbase

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14517838#comment-14517838 ] Zhijie Shen commented on YARN-3411: --- bq. Hmm. So, hbase stores values in bytes. Reading b

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14517347#comment-14517347 ] Vrushali C commented on YARN-3411: -- Hi [~gtCarrera9] Thanks for the feedback! bq. About

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14517334#comment-14517334 ] Vrushali C commented on YARN-3411: -- Hi [~djp] Thanks for the feedback! bq. Do each put i

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14517331#comment-14517331 ] Vrushali C commented on YARN-3411: -- Hi [~zjshen] >> For metrics, shall we be more genera

[jira] [Commented] (YARN-3411) [Storage implementation] explore the native HBase write schema for storage

[ https://issues.apache.org/jira/browse/YARN-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14517323#comment-14517323 ] Vrushali C commented on YARN-3411: -- Hi Sangjin, Thank you for the comments! bq. I’m sure

  1   2   >