[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13772934#comment-13772934
]
Hudson commented on YARN-353:
-
SUCCESS: Integrated in Hadoop-Yarn-trunk #338 (See
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13771670#comment-13771670
]
Hadoop QA commented on YARN-353:
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13771956#comment-13771956
]
Karthik Kambatla commented on YARN-353:
---
Thanks Hitesh. Dropping the try-catch blocks
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13772275#comment-13772275
]
Bikas Saha commented on YARN-353:
-
We should be storing the information inside the data of
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13772306#comment-13772306
]
Arun C Murthy commented on YARN-353:
No, I think we are good. branch-2.1 is too close
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13772296#comment-13772296
]
Hudson commented on YARN-353:
-
SUCCESS: Integrated in Hadoop-trunk-Commit #4443 (See
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13771393#comment-13771393
]
Karthik Kambatla commented on YARN-353:
---
[~hitesh], can you please take a look when
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13768725#comment-13768725
]
Karthik Kambatla commented on YARN-353:
---
The latest patch addresses Hitesh's latest
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13768773#comment-13768773
]
Hadoop QA commented on YARN-353:
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13768721#comment-13768721
]
Karthik Kambatla commented on YARN-353:
---
Thanks again for the detailed review,
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13761573#comment-13761573
]
Hitesh Shah commented on YARN-353:
--
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13759408#comment-13759408
]
Karthik Kambatla commented on YARN-353:
---
[~hitesh], when you get a chance, can you
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13752755#comment-13752755
]
Hadoop QA commented on YARN-353:
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13750825#comment-13750825
]
Karthik Kambatla commented on YARN-353:
---
Thanks for the detailed review, [~hitesh].
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13750830#comment-13750830
]
Hadoop QA commented on YARN-353:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13745516#comment-13745516
]
Hitesh Shah commented on YARN-353:
--
Sorry for the delay in the review. Been sidetracked by
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736688#comment-13736688
]
Karthik Kambatla commented on YARN-353:
---
Tested the latest patch on pseudo-dist
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736695#comment-13736695
]
Karthik Kambatla commented on YARN-353:
---
Assigned to myself for easier tracking. The
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13737667#comment-13737667
]
Hadoop QA commented on YARN-353:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736035#comment-13736035
]
Jian He commented on YARN-353:
--
Looks good overall, few nits
{code}
for (int retries = 0;
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736196#comment-13736196
]
Hadoop QA commented on YARN-353:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13736207#comment-13736207
]
Hadoop QA commented on YARN-353:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13734473#comment-13734473
]
Karthik Kambatla commented on YARN-353:
---
bq. Identation still off in yarn-default.xml
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13734570#comment-13734570
]
Hadoop QA commented on YARN-353:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13735088#comment-13735088
]
Karthik Kambatla commented on YARN-353:
---
Not quite sure why we see the findbugs
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13733576#comment-13733576
]
Hitesh Shah commented on YARN-353:
--
bq. For deleteWithRetries, the return code of exists()
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13733684#comment-13733684
]
Jian He commented on YARN-353:
--
bq. I am not sure I understand. If the RM is trying to delete
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13733760#comment-13733760
]
Karthik Kambatla commented on YARN-353:
---
Looking into this now. Will hopefully have an
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13732868#comment-13732868
]
Hitesh Shah commented on YARN-353:
--
Comments:
Identation still off in yarn-default.xml
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13733127#comment-13733127
]
Jian He commented on YARN-353:
--
Go ahead, thanks for that, Karthik !
Add
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13733164#comment-13733164
]
Jian He commented on YARN-353:
--
bq. why the catch and re-throw?
The intention was leaving there
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13731480#comment-13731480
]
Karthik Kambatla commented on YARN-353:
---
YARN-353.11.patch is the patch with findbugs
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13731528#comment-13731528
]
Hadoop QA commented on YARN-353:
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13729051#comment-13729051
]
Jian He commented on YARN-353:
--
The findbug -1 might be related to the test case is
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13727391#comment-13727391
]
Hitesh Shah commented on YARN-353:
--
[~jianhe] Could you please look at the findbug warnings
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13727174#comment-13727174
]
Hadoop QA commented on YARN-353:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13724585#comment-13724585
]
Sandy Ryza commented on YARN-353:
-
The patch looks good to me, other than the findbugs
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13712523#comment-13712523
]
Bikas Saha commented on YARN-353:
-
bq. ZKRMStateStore#getNewZooKeeper need not be
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13712533#comment-13712533
]
Karthik Kambatla commented on YARN-353:
---
bq. Make the ZKRMStateStore#NUM_RETRIES
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13712793#comment-13712793
]
Karthik Kambatla commented on YARN-353:
---
Looks good. +1 pending Jenkins.
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13712902#comment-13712902
]
Hadoop QA commented on YARN-353:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13712931#comment-13712931
]
Karthik Kambatla commented on YARN-353:
---
For the findbugs warning around NUM_RETRIES,
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13708734#comment-13708734
]
Jian He commented on YARN-353:
--
Thanks for the review, Karthik
bq.YarnConfiguration: how about
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13708796#comment-13708796
]
Hadoop QA commented on YARN-353:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709060#comment-13709060
]
Hadoop QA commented on YARN-353:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13703608#comment-13703608
]
Hadoop QA commented on YARN-353:
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13700487#comment-13700487
]
Bikas Saha commented on YARN-353:
-
I really don't know how to explain the downside of having
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13700490#comment-13700490
]
Devaraj K commented on YARN-353:
If we see,
{code:xml}
public static final String
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13700371#comment-13700371
]
Bikas Saha commented on YARN-353:
-
I dont think it makes sense to have default value for
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13700395#comment-13700395
]
Jian He commented on YARN-353:
--
bq. I dont think it makes sense to have default value for this.
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13700398#comment-13700398
]
Bikas Saha commented on YARN-353:
-
No. It must be required for the user to specify this. We
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13700422#comment-13700422
]
Jian He commented on YARN-353:
--
Any downside of doing that ?
Add
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13700440#comment-13700440
]
Bikas Saha commented on YARN-353:
-
Downside of doing what? Throwing clear exception will
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13700465#comment-13700465
]
Jian He commented on YARN-353:
--
sorry, I meant downside of giving a default ZK address. yeah,
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13698750#comment-13698750
]
Devaraj K commented on YARN-353:
The latest patch looks good to me except one nit.
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13699305#comment-13699305
]
Hadoop QA commented on YARN-353:
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13697629#comment-13697629
]
Devaraj K commented on YARN-353:
The patch overall looks good, here are my observations on
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13698099#comment-13698099
]
Hadoop QA commented on YARN-353:
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13697224#comment-13697224
]
Jian He commented on YARN-353:
--
I'm taking this over
Add Zookeeper-based
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13697417#comment-13697417
]
Hadoop QA commented on YARN-353:
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13695656#comment-13695656
]
Karthik Kambatla commented on YARN-353:
---
Thanks Bikas. Mostly looks good. Can you
[
https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13561929#comment-13561929
]
Hadoop QA commented on YARN-353:
{color:red}-1 overall{color}. Here are the results of
62 matches
Mail list logo
