[ https://issues.apache.org/jira/browse/YARN-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13708734#comment-13708734 ]
Jian He commented on YARN-353: ------------------------------ Thanks for the review, Karthik bq.YarnConfiguration: how about creating a common prefix for all of zk-state-store related parameters? bq.Make the ZKRMStateStore#NUM_RETRIES configurable with default set to 3. bq.ZKRMStateStore#getNewZooKeeper need not be synchronized fixed bq.Might be cleaner to move zkDoWithRetries to ZkAction we can implement no-retry functionalities with ZkAction if separate zkDoWithRetries out of ZkAction. same reason for 6 New patch also added test case for ZKClient disconnect and reconnect logic. > Add Zookeeper-based store implementation for RMStateStore > --------------------------------------------------------- > > Key: YARN-353 > URL: https://issues.apache.org/jira/browse/YARN-353 > Project: Hadoop YARN > Issue Type: Sub-task > Components: resourcemanager > Reporter: Hitesh Shah > Assignee: Bikas Saha > Attachments: YARN-353.1.patch, YARN-353.2.patch, YARN-353.3.patch, > YARN-353.4.patch, YARN-353.5.patch, YARN-353.6.patch > > > Add store that write RM state data to ZK -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira