[jira] [Commented] (YARN-3599) Fix the javadoc of DelegationTokenSecretManager in hadoop-yarn
[
https://issues.apache.org/jira/browse/YARN-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534097#comment-14534097
]
Tsuyoshi Ozawa commented on YARN-3599:
--
[~gliptak], thank you for taking this issue. Looks good to me overall. Could
you check following points?
Please check indentation of line of in milliseconds - it seems to have
additional space.
{code}
* @param delegationTokenRenewInterval how often the tokens must be renewed
+ * in milliseconds
{code}
A following line is over 80 characters.
{code}
+ * @param delegationTokenRemoverScanInterval how often the tokens are
scanned
{code}
The link looks to be broken. Should we just remove link annotation?
{code}
+ * @param rmContext current context of the {@link ResourceManager}
{code}
Fix the javadoc of DelegationTokenSecretManager in hadoop-yarn
--
Key: YARN-3599
URL: https://issues.apache.org/jira/browse/YARN-3599
Project: Hadoop YARN
Issue Type: Sub-task
Components: documentation
Reporter: Gabor Liptak
Priority: Trivial
Attachments: YARN-3599.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-3599) Fix the javadoc of DelegationTokenSecretManager in hadoop-yarn
[ https://issues.apache.org/jira/browse/YARN-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14534631#comment-14534631 ] Junping Du commented on YARN-3599: -- Hi [~ozawa], Thanks for reviewing the patch here. Can you check my last comments (and coming discussion) in YARN-3587 before any commit effort? Thx! Fix the javadoc of DelegationTokenSecretManager in hadoop-yarn -- Key: YARN-3599 URL: https://issues.apache.org/jira/browse/YARN-3599 Project: Hadoop YARN Issue Type: Sub-task Components: documentation Reporter: Gabor Liptak Priority: Trivial Attachments: YARN-3599.patch -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-3599) Fix the javadoc of DelegationTokenSecretManager in hadoop-yarn
[
https://issues.apache.org/jira/browse/YARN-3599?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14533664#comment-14533664
]
Hadoop QA commented on YARN-3599:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:blue}0{color} | pre-patch | 14m 39s | Pre-patch trunk compilation is
healthy. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 32s | There were no new javac warning
messages. |
| {color:red}-1{color} | javadoc | 9m 40s | The applied patch generated 1
additional warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:red}-1{color} | checkstyle | 0m 49s | The applied patch generated 1
new checkstyle issues (total was 8, now 6). |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 35s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 33s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 2m 5s | The patch does not introduce
any new Findbugs (version 2.0.3) warnings. |
| {color:green}+1{color} | yarn tests | 3m 8s | Tests passed in
hadoop-yarn-server-applicationhistoryservice. |
| {color:green}+1{color} | yarn tests | 52m 14s | Tests passed in
hadoop-yarn-server-resourcemanager. |
| | | 93m 3s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12731288/YARN-3599.patch |
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | trunk / 4d9f9e5 |
| javadoc |
https://builds.apache.org/job/PreCommit-YARN-Build/7784/artifact/patchprocess/diffJavadocWarnings.txt
|
| checkstyle |
https://builds.apache.org/job/PreCommit-YARN-Build/7784/artifact/patchprocess/diffcheckstylehadoop-yarn-server-applicationhistoryservice.txt
|
| hadoop-yarn-server-applicationhistoryservice test log |
https://builds.apache.org/job/PreCommit-YARN-Build/7784/artifact/patchprocess/testrun_hadoop-yarn-server-applicationhistoryservice.txt
|
| hadoop-yarn-server-resourcemanager test log |
https://builds.apache.org/job/PreCommit-YARN-Build/7784/artifact/patchprocess/testrun_hadoop-yarn-server-resourcemanager.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/7784/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf909.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/7784/console |
This message was automatically generated.
Fix the javadoc of DelegationTokenSecretManager in hadoop-yarn
--
Key: YARN-3599
URL: https://issues.apache.org/jira/browse/YARN-3599
Project: Hadoop YARN
Issue Type: Sub-task
Components: documentation
Reporter: Gabor Liptak
Priority: Trivial
Attachments: YARN-3599.patch
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
