[jira] [Commented] (YARN-4203) Add request/response logging & timing for each REST endpoint call
[ https://issues.apache.org/jira/browse/YARN-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15369716#comment-15369716 ] Hudson commented on YARN-4203: -- SUCCESS: Integrated in Hadoop-trunk-Commit #10074 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/10074/]) YARN-4203. Add request/response logging & timing for each REST endpoint (sjlee: rev da2b7bd08e27673945391b1ad17e8f22abf1) * hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice/src/main/java/org/apache/hadoop/yarn/server/timelineservice/reader/TimelineReaderWebServices.java > Add request/response logging & timing for each REST endpoint call > - > > Key: YARN-4203 > URL: https://issues.apache.org/jira/browse/YARN-4203 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelineserver >Affects Versions: YARN-2928 >Reporter: Vrushali C >Assignee: Varun Saxena >Priority: Minor > Fix For: YARN-2928 > > Attachments: YARN-4203-YARN-2928.003.patch, > YARN-4203-YARN-2928.01.patch, YARN-4203-YARN-2928.02.patch > > > The rest endpoints are being added as part of YARN-4075. Filing this jira to > add in request & response logging and timing for each REST call that comes > in. -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: yarn-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: yarn-issues-h...@hadoop.apache.org
[jira] [Commented] (YARN-4203) Add request/response logging & timing for each REST endpoint call
[ https://issues.apache.org/jira/browse/YARN-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938759#comment-14938759 ] Vrushali C commented on YARN-4203: -- Committed patch 003 in. Thanks [~varun_saxena] for the patch and [~gtCarrera] for the review. > Add request/response logging & timing for each REST endpoint call > - > > Key: YARN-4203 > URL: https://issues.apache.org/jira/browse/YARN-4203 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelineserver >Affects Versions: YARN-2928 >Reporter: Vrushali C >Assignee: Varun Saxena >Priority: Minor > Attachments: YARN-4203-YARN-2928.003.patch, > YARN-4203-YARN-2928.01.patch, YARN-4203-YARN-2928.02.patch > > > The rest endpoints are being added as part of YARN-4075. Filing this jira to > add in request & response logging and timing for each REST call that comes > in. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4203) Add request/response logging & timing for each REST endpoint call
[ https://issues.apache.org/jira/browse/YARN-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938212#comment-14938212 ] Vrushali C commented on YARN-4203: -- +1 on patch v3. Will commit it in now. > Add request/response logging & timing for each REST endpoint call > - > > Key: YARN-4203 > URL: https://issues.apache.org/jira/browse/YARN-4203 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelineserver >Affects Versions: YARN-2928 >Reporter: Vrushali C >Assignee: Varun Saxena >Priority: Minor > Attachments: YARN-4203-YARN-2928.003.patch, > YARN-4203-YARN-2928.01.patch, YARN-4203-YARN-2928.02.patch > > > The rest endpoints are being added as part of YARN-4075. Filing this jira to > add in request & response logging and timing for each REST call that comes > in. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4203) Add request/response logging & timing for each REST endpoint call
[ https://issues.apache.org/jira/browse/YARN-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938182#comment-14938182 ] Li Lu commented on YARN-4203: - +1, patch LGTM. Please feel free to commit when there's no objections. Thanks for the work [~varun_saxena]! > Add request/response logging & timing for each REST endpoint call > - > > Key: YARN-4203 > URL: https://issues.apache.org/jira/browse/YARN-4203 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelineserver >Affects Versions: YARN-2928 >Reporter: Vrushali C >Assignee: Varun Saxena >Priority: Minor > Attachments: YARN-4203-YARN-2928.003.patch, > YARN-4203-YARN-2928.01.patch, YARN-4203-YARN-2928.02.patch > > > The rest endpoints are being added as part of YARN-4075. Filing this jira to > add in request & response logging and timing for each REST call that comes > in. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4203) Add request/response logging & timing for each REST endpoint call
[
https://issues.apache.org/jira/browse/YARN-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936837#comment-14936837
]
Hadoop QA commented on YARN-4203:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 15m 39s | Findbugs (version ) appears to
be broken on YARN-2928. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 7m 57s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 10m 6s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 16s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 33s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 40s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 0m 51s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests | 3m 23s | Tests passed in
hadoop-yarn-server-timelineservice. |
| | | 40m 53s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12764416/YARN-4203-YARN-2928.003.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | YARN-2928 / def22b9 |
| hadoop-yarn-server-timelineservice test log |
https://builds.apache.org/job/PreCommit-YARN-Build/9309/artifact/patchprocess/testrun_hadoop-yarn-server-timelineservice.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/9309/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/9309/console |
This message was automatically generated.
> Add request/response logging & timing for each REST endpoint call
> -
>
> Key: YARN-4203
> URL: https://issues.apache.org/jira/browse/YARN-4203
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
>Affects Versions: YARN-2928
>Reporter: Vrushali C
>Assignee: Varun Saxena
>Priority: Minor
> Attachments: YARN-4203-YARN-2928.003.patch,
> YARN-4203-YARN-2928.01.patch, YARN-4203-YARN-2928.02.patch
>
>
> The rest endpoints are being added as part of YARN-4075. Filing this jira to
> add in request & response logging and timing for each REST call that comes
> in.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-4203) Add request/response logging & timing for each REST endpoint call
[
https://issues.apache.org/jira/browse/YARN-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936717#comment-14936717
]
Hadoop QA commented on YARN-4203:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 16m 23s | Findbugs (version ) appears to
be broken on YARN-2928. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 8m 13s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 10m 16s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 17s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 38s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 42s | The patch built with
eclipse:eclipse. |
| {color:red}-1{color} | findbugs | 0m 13s | Post-patch findbugs
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-timelineservice
compilation is broken. |
| {color:green}+1{color} | findbugs | 0m 13s | The patch does not introduce
any new Findbugs (version ) warnings. |
| {color:red}-1{color} | yarn tests | 0m 14s | Tests failed in
hadoop-yarn-server-timelineservice. |
| | | 38m 24s | |
\\
\\
|| Reason || Tests ||
| Failed build | hadoop-yarn-server-timelineservice |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12764393/YARN-4203-YARN-2928.03.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | YARN-2928 / def22b9 |
| hadoop-yarn-server-timelineservice test log |
https://builds.apache.org/job/PreCommit-YARN-Build/9307/artifact/patchprocess/testrun_hadoop-yarn-server-timelineservice.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/9307/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf905.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/9307/console |
This message was automatically generated.
> Add request/response logging & timing for each REST endpoint call
> -
>
> Key: YARN-4203
> URL: https://issues.apache.org/jira/browse/YARN-4203
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
>Affects Versions: YARN-2928
>Reporter: Vrushali C
>Assignee: Varun Saxena
>Priority: Minor
> Attachments: YARN-4203-YARN-2928.01.patch,
> YARN-4203-YARN-2928.02.patch, YARN-4203-YARN-2928.03.patch
>
>
> The rest endpoints are being added as part of YARN-4075. Filing this jira to
> add in request & response logging and timing for each REST call that comes
> in.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-4203) Add request/response logging & timing for each REST endpoint call
[ https://issues.apache.org/jira/browse/YARN-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936494#comment-14936494 ] Varun Saxena commented on YARN-4203: Updated patch as per discussion on YARN-4210 https://issues.apache.org/jira/browse/YARN-4210?focusedCommentId=14936407&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14936407 > Add request/response logging & timing for each REST endpoint call > - > > Key: YARN-4203 > URL: https://issues.apache.org/jira/browse/YARN-4203 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelineserver >Affects Versions: YARN-2928 >Reporter: Vrushali C >Assignee: Varun Saxena >Priority: Minor > Attachments: YARN-4203-YARN-2928.01.patch, > YARN-4203-YARN-2928.02.patch, YARN-4203-YARN-2928.03.patch > > > The rest endpoints are being added as part of YARN-4075. Filing this jira to > add in request & response logging and timing for each REST call that comes > in. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4203) Add request/response logging & timing for each REST endpoint call
[ https://issues.apache.org/jira/browse/YARN-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935562#comment-14935562 ] Vrushali C commented on YARN-4203: -- Looks good, thanks [~varun_saxena]! Will commit this in today unless anyone objects. > Add request/response logging & timing for each REST endpoint call > - > > Key: YARN-4203 > URL: https://issues.apache.org/jira/browse/YARN-4203 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelineserver >Affects Versions: YARN-2928 >Reporter: Vrushali C >Assignee: Varun Saxena >Priority: Minor > Attachments: YARN-4203-YARN-2928.01.patch, > YARN-4203-YARN-2928.02.patch > > > The rest endpoints are being added as part of YARN-4075. Filing this jira to > add in request & response logging and timing for each REST call that comes > in. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4203) Add request/response logging & timing for each REST endpoint call
[
https://issues.apache.org/jira/browse/YARN-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935558#comment-14935558
]
Hadoop QA commented on YARN-4203:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 17m 12s | Findbugs (version ) appears to
be broken on YARN-2928. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 8m 42s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 10m 48s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 26s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 19s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 52s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 46s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 1m 9s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests | 3m 21s | Tests passed in
hadoop-yarn-server-timelineservice. |
| | | 44m 43s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12764275/YARN-4203-YARN-2928.02.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | YARN-2928 / def22b9 |
| hadoop-yarn-server-timelineservice test log |
https://builds.apache.org/job/PreCommit-YARN-Build/9298/artifact/patchprocess/testrun_hadoop-yarn-server-timelineservice.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/9298/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf907.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/9298/console |
This message was automatically generated.
> Add request/response logging & timing for each REST endpoint call
> -
>
> Key: YARN-4203
> URL: https://issues.apache.org/jira/browse/YARN-4203
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
>Affects Versions: YARN-2928
>Reporter: Vrushali C
>Assignee: Varun Saxena
>Priority: Minor
> Attachments: YARN-4203-YARN-2928.01.patch,
> YARN-4203-YARN-2928.02.patch
>
>
> The rest endpoints are being added as part of YARN-4075. Filing this jira to
> add in request & response logging and timing for each REST call that comes
> in.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (YARN-4203) Add request/response logging & timing for each REST endpoint call
[ https://issues.apache.org/jira/browse/YARN-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935534#comment-14935534 ] Varun Saxena commented on YARN-4203: Updated patch as per [~vrushalic]'s suggestion > Add request/response logging & timing for each REST endpoint call > - > > Key: YARN-4203 > URL: https://issues.apache.org/jira/browse/YARN-4203 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelineserver >Affects Versions: YARN-2928 >Reporter: Vrushali C >Assignee: Varun Saxena >Priority: Minor > Attachments: YARN-4203-YARN-2928.01.patch, > YARN-4203-YARN-2928.02.patch > > > The rest endpoints are being added as part of YARN-4075. Filing this jira to > add in request & response logging and timing for each REST call that comes > in. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4203) Add request/response logging & timing for each REST endpoint call
[ https://issues.apache.org/jira/browse/YARN-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933726#comment-14933726 ] Vrushali C commented on YARN-4203: -- Thanks [~varun_saxena], patch looks good to me. + 1 One minor suggestion, we need not make it right now if there are no other changes. The log statement right now is ""URL " + url + " processed." or "URL " + url + " received". Perhaps we could make it "Received URL " + url and "Processed URL " + url. While browsing through the logs, it helps scan things visually faster. Also, if we have scripts parsing the logs, it is easier to parse out lines starting with "Received" or "Processed". > Add request/response logging & timing for each REST endpoint call > - > > Key: YARN-4203 > URL: https://issues.apache.org/jira/browse/YARN-4203 > Project: Hadoop YARN > Issue Type: Sub-task > Components: timelineserver >Affects Versions: YARN-2928 >Reporter: Vrushali C >Assignee: Varun Saxena >Priority: Minor > Attachments: YARN-4203-YARN-2928.01.patch > > > The rest endpoints are being added as part of YARN-4075. Filing this jira to > add in request & response logging and timing for each REST call that comes > in. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (YARN-4203) Add request/response logging & timing for each REST endpoint call
[
https://issues.apache.org/jira/browse/YARN-4203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14933192#comment-14933192
]
Hadoop QA commented on YARN-4203:
-
\\
\\
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
| {color:red}-1{color} | pre-patch | 16m 8s | Findbugs (version ) appears to
be broken on YARN-2928. |
| {color:green}+1{color} | @author | 0m 0s | The patch does not contain any
@author tags. |
| {color:red}-1{color} | tests included | 0m 0s | The patch doesn't appear
to include any new or modified tests. Please justify why no new tests are
needed for this patch. Also please list what manual steps were performed to
verify this patch. |
| {color:green}+1{color} | javac | 8m 5s | There were no new javac warning
messages. |
| {color:green}+1{color} | javadoc | 10m 19s | There were no new javadoc
warning messages. |
| {color:green}+1{color} | release audit | 0m 23s | The applied patch does
not increase the total number of release audit warnings. |
| {color:green}+1{color} | checkstyle | 0m 18s | There were no new checkstyle
issues. |
| {color:green}+1{color} | whitespace | 0m 0s | The patch has no lines that
end in whitespace. |
| {color:green}+1{color} | install | 1m 37s | mvn install still works. |
| {color:green}+1{color} | eclipse:eclipse | 0m 42s | The patch built with
eclipse:eclipse. |
| {color:green}+1{color} | findbugs | 0m 55s | The patch does not introduce
any new Findbugs (version 3.0.0) warnings. |
| {color:green}+1{color} | yarn tests | 2m 47s | Tests passed in
hadoop-yarn-server-timelineservice. |
| | | 41m 18s | |
\\
\\
|| Subsystem || Report/Notes ||
| Patch URL |
http://issues.apache.org/jira/secure/attachment/12763996/YARN-4203-YARN-2928.01.patch
|
| Optional Tests | javadoc javac unit findbugs checkstyle |
| git revision | YARN-2928 / def22b9 |
| hadoop-yarn-server-timelineservice test log |
https://builds.apache.org/job/PreCommit-YARN-Build/9282/artifact/patchprocess/testrun_hadoop-yarn-server-timelineservice.txt
|
| Test Results |
https://builds.apache.org/job/PreCommit-YARN-Build/9282/testReport/ |
| Java | 1.7.0_55 |
| uname | Linux asf906.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP
PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux |
| Console output |
https://builds.apache.org/job/PreCommit-YARN-Build/9282/console |
This message was automatically generated.
> Add request/response logging & timing for each REST endpoint call
> -
>
> Key: YARN-4203
> URL: https://issues.apache.org/jira/browse/YARN-4203
> Project: Hadoop YARN
> Issue Type: Sub-task
> Components: timelineserver
>Affects Versions: YARN-2928
>Reporter: Vrushali C
>Assignee: Varun Saxena
>Priority: Minor
> Attachments: YARN-4203-YARN-2928.01.patch
>
>
> The rest endpoints are being added as part of YARN-4075. Filing this jira to
> add in request & response logging and timing for each REST call that comes
> in.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
