[jira] [Commented] (YARN-4386) refreshNodesGracefully() looks at active RMNode list for recommissioning decommissioned nodes

[ https://issues.apache.org/jira/browse/YARN-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15157022#comment-15157022 ] Junping Du commented on YARN-4386: -- v2 patch LGTM. +1. Will commit it shortly. > refreshNodesGracefully()

[jira] [Commented] (YARN-4386) refreshNodesGracefully() looks at active RMNode list for recommissioning decommissioned nodes

[ https://issues.apache.org/jira/browse/YARN-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15154519#comment-15154519 ] Kuhu Shukla commented on YARN-4386: --- Thank you [~djp]! Will wait for your comments. >

[jira] [Commented] (YARN-4386) refreshNodesGracefully() looks at active RMNode list for recommissioning decommissioned nodes

[ https://issues.apache.org/jira/browse/YARN-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15134939#comment-15134939 ] Kuhu Shukla commented on YARN-4386: --- [~djp], requesting for comments/review from you on this. Thanks a

[jira] [Commented] (YARN-4386) refreshNodesGracefully() looks at active RMNode list for recommissioning decommissioned nodes

[ https://issues.apache.org/jira/browse/YARN-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15135419#comment-15135419 ] Junping Du commented on YARN-4386: -- Sorry that I was in travel since mid of this week. Will review on this

[jira] [Commented] (YARN-4386) refreshNodesGracefully() looks at active RMNode list for recommissioning decommissioned nodes

[ https://issues.apache.org/jira/browse/YARN-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15132611#comment-15132611 ] Sunil G commented on YARN-4386: --- Thanks [~kshukla] for the patch. I think patch generally cover the intended

[jira] [Commented] (YARN-4386) refreshNodesGracefully() looks at active RMNode list for recommissioning decommissioned nodes

[ https://issues.apache.org/jira/browse/YARN-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131390#comment-15131390 ] Hadoop QA commented on YARN-4386: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4386) refreshNodesGracefully() looks at active RMNode list for recommissioning decommissioned nodes

[ https://issues.apache.org/jira/browse/YARN-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15131526#comment-15131526 ] Kuhu Shukla commented on YARN-4386: --- bq. Updating patch with a test to check if a decommissioned node can

[jira] [Commented] (YARN-4386) refreshNodesGracefully() looks at active RMNode list for recommissioning decommissioned nodes

[ https://issues.apache.org/jira/browse/YARN-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15046954#comment-15046954 ] Sunil G commented on YARN-4386: --- Hi [~kshukla] Sorry for replying late here. bq. Unless there are 2

[jira] [Commented] (YARN-4386) refreshNodesGracefully() looks at active RMNode list for recommissioning decommissioned nodes

[ https://issues.apache.org/jira/browse/YARN-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15038283#comment-15038283 ] Kuhu Shukla commented on YARN-4386: --- [~sunilg], [~djp]. Request for comments on how to test this since

[jira] [Commented] (YARN-4386) refreshNodesGracefully() looks at active RMNode list for recommissioning decommissioned nodes

[ https://issues.apache.org/jira/browse/YARN-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026916#comment-15026916 ] Kuhu Shukla commented on YARN-4386: --- Sure that would help. I will update with revised patch soon. Thank

[jira] [Commented] (YARN-4386) refreshNodesGracefully() looks at active RMNode list for recommissioning decommissioned nodes

[ https://issues.apache.org/jira/browse/YARN-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026926#comment-15026926 ] Kuhu Shukla commented on YARN-4386: --- [~djp], without the patch, the decommissioned node is looked up in

[jira] [Commented] (YARN-4386) refreshNodesGracefully() looks at active RMNode list for recommissioning decommissioned nodes

[ https://issues.apache.org/jira/browse/YARN-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15027016#comment-15027016 ] Sunil G commented on YARN-4386: --- {{getRMNodes}} will have only Active/Decommissioning nodes. hence as you

[jira] [Commented] (YARN-4386) refreshNodesGracefully() looks at active RMNode list for recommissioning decommissioned nodes

[ https://issues.apache.org/jira/browse/YARN-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026890#comment-15026890 ] Kuhu Shukla commented on YARN-4386: --- Thank you [~djp] for your comments. TestClientRMTokens is failing

[jira] [Commented] (YARN-4386) refreshNodesGracefully() looks at active RMNode list for recommissioning decommissioned nodes

[ https://issues.apache.org/jira/browse/YARN-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026913#comment-15026913 ] Junping Du commented on YARN-4386: -- Thanks [~kshukla] for the patch. I agree these test failures are not

[jira] [Commented] (YARN-4386) refreshNodesGracefully() looks at active RMNode list for recommissioning decommissioned nodes

[ https://issues.apache.org/jira/browse/YARN-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026805#comment-15026805 ] Junping Du commented on YARN-4386: -- Thanks [~kshukla] to report this issue and [~sunilg] for review! I

[jira] [Commented] (YARN-4386) refreshNodesGracefully() looks at active RMNode list for recommissioning decommissioned nodes

[ https://issues.apache.org/jira/browse/YARN-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15024968#comment-15024968 ] Hadoop QA commented on YARN-4386: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-4386) refreshNodesGracefully() looks at active RMNode list for recommissioning decommissioned nodes

[ https://issues.apache.org/jira/browse/YARN-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022818#comment-15022818 ] Sunil G commented on YARN-4386: --- Hi [~kshukla], As I see it, we can RECOMMISSION only those nodes which are

[jira] [Commented] (YARN-4386) refreshNodesGracefully() looks at active RMNode list for recommissioning decommissioned nodes

[ https://issues.apache.org/jira/browse/YARN-4386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15022866#comment-15022866 ] Kuhu Shukla commented on YARN-4386: --- Yes I agree. Missed correlating the DECOMMISSIONED state transition