[
https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15563211#comment-15563211
]
Sergey Shelukhin commented on YARN-5659:
Thank you for the reviews!
> getPathFromYarnURL should
[
https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1306#comment-1306
]
Hudson commented on YARN-5659:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #10564 (See
[
https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15549888#comment-15549888
]
Daniel Templeton commented on YARN-5659:
LGTM.
> getPathFromYarnURL should use standard methods
>
[
https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15548186#comment-15548186
]
Junping Du commented on YARN-5659:
--
Latest patch LGTM. +1. Will commit it shortly if no further comments
[
https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15547382#comment-15547382
]
Hadoop QA commented on YARN-5659:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15547331#comment-15547331
]
Hadoop QA commented on YARN-5659:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15530407#comment-15530407
]
Hitesh Shah commented on YARN-5659:
---
[~sershe] Just annotate the functions that are only required by unit
[
https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15530399#comment-15530399
]
Sergey Shelukhin commented on YARN-5659:
Hmm.. which one should I add? I am not very familiar with
[
https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15527033#comment-15527033
]
Sergey Shelukhin commented on YARN-5659:
This is an added overload, so it doesn't break the public
[
https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15527046#comment-15527046
]
Wangda Tan commented on YARN-5659:
--
Oh got it, I looked at the patch in a wrong way.
IIUC,
{{public
[
https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15526969#comment-15526969
]
Wangda Tan commented on YARN-5659:
--
[~sershe],
I'm not quite sure why following is required:
{code}
[
https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15517984#comment-15517984
]
Sergey Shelukhin commented on YARN-5659:
[~templedf] does the patch make sense now? only the
[
https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15514795#comment-15514795
]
Hadoop QA commented on YARN-5659:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15514660#comment-15514660
]
Sergey Shelukhin commented on YARN-5659:
Apparently editing patches directly is not a good idea...
[
https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15514558#comment-15514558
]
Hadoop QA commented on YARN-5659:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15514302#comment-15514302
]
Daniel Templeton commented on YARN-5659:
The checkstyle and whitespace issue (both are the same)
[
https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511317#comment-15511317
]
Hadoop QA commented on YARN-5659:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511216#comment-15511216
]
Daniel Templeton commented on YARN-5659:
Ah, sorry. I assumed we were looking for something like
[
https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511217#comment-15511217
]
Daniel Templeton commented on YARN-5659:
Ah, sorry. I assumed we were looking for something like
[
https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511207#comment-15511207
]
Sergey Shelukhin commented on YARN-5659:
[~templedf] the test already has paths without a schema
>
[
https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511180#comment-15511180
]
Daniel Templeton commented on YARN-5659:
Thanks for the updated patch. The tests look good. Think
[
https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15511140#comment-15511140
]
Hadoop QA commented on YARN-5659:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508524#comment-15508524
]
Hadoop QA commented on YARN-5659:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15508231#comment-15508231
]
Junping Du commented on YARN-5659:
--
Thanks [~templedf] for review and comments! Patch looks OK to me but I
[
https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507971#comment-15507971
]
Hitesh Shah commented on YARN-5659:
---
\cc [~leftnoteasy] [~vvasudev] [~djp]
> getPathFromYarnURL should
[
https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507958#comment-15507958
]
Hadoop QA commented on YARN-5659:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15507840#comment-15507840
]
Daniel Templeton commented on YARN-5659:
Looks right to me. +1 (non-binding)
> getPathFromYarnURL
27 matches
Mail list logo
