[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786869#comment-16786869
]
Eric Payne commented on YARN-5714:
--
Okay, I will backport this through to branch-2.8
> ContainerExecutor
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786148#comment-16786148
]
Hadoop QA commented on YARN-5714:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786121#comment-16786121
]
Jim Brennan commented on YARN-5714:
---
Thanks [~eepayne]! I re-uploaded the branch-2 patch.
>
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785851#comment-16785851
]
Eric Payne commented on YARN-5714:
--
[~Jim_Brennan], the ASF warning is from dependency-reduced-pom.xml
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785031#comment-16785031
]
Hadoop QA commented on YARN-5714:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784990#comment-16784990
]
Eric Payne commented on YARN-5714:
--
I kicked the pre-commit build, and since the branch-2.8 patch is the
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16783437#comment-16783437
]
Jim Brennan commented on YARN-5714:
---
cc: [~eepayne]
I changed the assignee back to [~rcatherinot] - I
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375022#comment-16375022
]
Hudson commented on YARN-5714:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13708 (See
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373644#comment-16373644
]
Jason Lowe commented on YARN-5714:
--
+1 lgtm. I'll commit this tomorrow if there are no objections.
>
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373444#comment-16373444
]
Jim Brennan commented on YARN-5714:
---
This patch is ready for review.
> ContainerExecutor does not order
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373138#comment-16373138
]
genericqa commented on YARN-5714:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373113#comment-16373113
]
Jim Brennan commented on YARN-5714:
---
I believe this patch is now ready for review.
>
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373075#comment-16373075
]
genericqa commented on YARN-5714:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373045#comment-16373045
]
Jim Brennan commented on YARN-5714:
---
Original version of path.008 did not include the checkstyle fixes.
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16373032#comment-16373032
]
genericqa commented on YARN-5714:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372939#comment-16372939
]
Jim Brennan commented on YARN-5714:
---
Uploaded a new patch that addresses the check-style issues.
>
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372239#comment-16372239
]
genericqa commented on YARN-5714:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16372162#comment-16372162
]
Jim Brennan commented on YARN-5714:
---
As this has become a blocking issue for YARN-7677, I took the
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16370382#comment-16370382
]
Billie Rinaldi commented on YARN-5714:
--
It's true, the preserving order approach would require
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16369200#comment-16369200
]
Jason Lowe commented on YARN-5714:
--
While preserving the user's order sounds nice, I don't think it is
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350359#comment-16350359
]
Jason Lowe commented on YARN-5714:
--
On second thought, it's extremely unlikely that NM whitelist variables
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349312#comment-16349312
]
Jason Lowe commented on YARN-5714:
--
Sorry to come to this late. We ran across an instance of this
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16349304#comment-16349304
]
genericqa commented on YARN-5714:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15807883#comment-15807883
]
Remi Catherinot commented on YARN-5714:
---
Thanks for your feedbacks.
No problem for me if the patch
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15806273#comment-15806273
]
Miklos Szegedi commented on YARN-5714:
--
Thank you for the comment [~templedf].
That option raises the
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796644#comment-15796644
]
Daniel Templeton commented on YARN-5714:
Coming back to [~Naganarasimha]'s original comment,
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15796191#comment-15796191
]
Miklos Szegedi commented on YARN-5714:
--
The change looks good to me. (non-binding) Thank you,
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15777028#comment-15777028
]
Hadoop QA commented on YARN-5714:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15755009#comment-15755009
]
Miklos Szegedi commented on YARN-5714:
--
{quote}
are you sure about the double % ? i've tested it on
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15753981#comment-15753981
]
Remi Catherinot commented on YARN-5714:
---
Hi, thanks for the review too :)
# are you sure about the
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15745900#comment-15745900
]
Miklos Szegedi commented on YARN-5714:
--
Thank you, [~rcatherinot] for the reply!
1.
{quote}
echo %%A%%
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15744799#comment-15744799
]
Remi Catherinot commented on YARN-5714:
---
Hi,
thanks for the review and here are my answers :
1 -
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15713858#comment-15713858
]
Miklos Szegedi commented on YARN-5714:
--
Thank you, for the patch, [~rcatherinot]!
1. "%%A%%" should
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15589585#comment-15589585
]
Remi Catherinot commented on YARN-5714:
---
I think the patch is ready for a review.
>
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15563058#comment-15563058
]
Remi Catherinot commented on YARN-5714:
---
HOMELOC depends on both HADOOP_MAPRED_HOME and
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15562720#comment-15562720
]
Allen Wittenauer commented on YARN-5714:
I've got a concern that not all of the weird bash corner
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15561605#comment-15561605
]
Hadoop QA commented on YARN-5714:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15560883#comment-15560883
]
Hadoop QA commented on YARN-5714:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15560734#comment-15560734
]
Hadoop QA commented on YARN-5714:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15558145#comment-15558145
]
Hadoop QA commented on YARN-5714:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1261#comment-1261
]
Naganarasimha G R commented on YARN-5714:
-
Thanks for raising this issue [~rcatherinot], Agree to
[
https://issues.apache.org/jira/browse/YARN-5714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1260#comment-1260
]
Naganarasimha G R commented on YARN-5714:
-
Thanks for raising this issue [~rcatherinot], Agree to
42 matches
Mail list logo
