[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118286#comment-16118286
]
Yeliang Cang commented on YARN-6873:
Thanks [~ajisakaa] for committing this, and thanks for [~vincent
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16118149#comment-16118149
]
Akira Ajisaka commented on YARN-6873:
-
+1, checking this in.
> Moving logging APIs over to slf4j in
>
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116482#comment-16116482
]
Hadoop QA commented on YARN-6873:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116455#comment-16116455
]
Yeliang Cang commented on YARN-6873:
Sorry for the delay response! I have submitted branch-2 patch,
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116362#comment-16116362
]
Akira Ajisaka commented on YARN-6873:
-
Committed this to trunk. Hi [~Cyl], would you create a patch for
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116360#comment-16116360
]
Akira Ajisaka commented on YARN-6873:
-
+1
> Moving logging APIs over to slf4j in
>
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116352#comment-16116352
]
Akira Ajisaka commented on YARN-6873:
-
Sorry YARN-3511 is right. Thanks [~vincent he] and [~Cyl].
>
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116191#comment-16116191
]
Yeliang Cang commented on YARN-6873:
Yes, I think you are right, [~vincent he]. YARN-6873.003.patch
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116141#comment-16116141
]
Wenxin He commented on YARN-6873:
-
Verified +1:
I added {{EWMA}} to {{log4j.rootLogger}} in
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116024#comment-16116024
]
Hadoop QA commented on YARN-6873:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116014#comment-16116014
]
Yeliang Cang commented on YARN-6873:
Submit patch004, and it does not break YARN-2901
> Moving logging
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16115978#comment-16115978
]
Yeliang Cang commented on YARN-6873:
ok, [~vincent he]! I have just verified Log4jLoggerAdapter
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113991#comment-16113991
]
Wenxin He commented on YARN-6873:
-
[~Cyl], since HADOOP-14706 is commited, would you use the helper method
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108460#comment-16108460
]
Akira Ajisaka commented on YARN-6873:
-
+1 for adding a helper method. Thanks Wenxin.
> Moving logging
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108458#comment-16108458
]
Wenxin He commented on YARN-6873:
-
Is it a good idea to add a helper method in hadoop-common to determine
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108426#comment-16108426
]
Yeliang Cang commented on YARN-6873:
ok, I will modify the patch, and will verify it in my own
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108381#comment-16108381
]
Akira Ajisaka commented on YARN-6873:
-
{code:title=NavBlock.java}
Log log =
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108374#comment-16108374
]
Yeliang Cang commented on YARN-6873:
Thanks for correcting me, [~ajisakaa]! I will check in this!
>
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108344#comment-16108344
]
Hudson commented on YARN-6873:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12087 (See
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108316#comment-16108316
]
Akira Ajisaka commented on YARN-6873:
-
Reverted this. Sorry for back and forth.
> Moving logging APIs
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108295#comment-16108295
]
Hudson commented on YARN-6873:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12085 (See
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108283#comment-16108283
]
Akira Ajisaka commented on YARN-6873:
-
Committed this to trunk, but probably it broke YARN-2901. I'll
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16108272#comment-16108272
]
Akira Ajisaka commented on YARN-6873:
-
+1, checking this in.
> Moving logging APIs over to slf4j in
>
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107298#comment-16107298
]
Wenxin He commented on YARN-6873:
-
Looks good to me!
> Moving logging APIs over to slf4j in
>
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107197#comment-16107197
]
Hadoop QA commented on YARN-6873:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107140#comment-16107140
]
Yeliang Cang commented on YARN-6873:
Submit patch003!
> Moving logging APIs over to slf4j in
>
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107000#comment-16107000
]
Hadoop QA commented on YARN-6873:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106949#comment-16106949
]
Yeliang Cang commented on YARN-6873:
Thanks for the review, [~vincent he]! I have submit patch002 to
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106792#comment-16106792
]
Wenxin He commented on YARN-6873:
-
Mostly looks good to me, except some minor nits:
# checkstyle
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106755#comment-16106755
]
Yeliang Cang commented on YARN-6873:
[~wenxin he],[~ajisakaa], could you he help me reviewing this?
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101972#comment-16101972
]
Hadoop QA commented on YARN-6873:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-6873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16101929#comment-16101929
]
Yeliang Cang commented on YARN-6873:
Submit patch001!
> Moving logging APIs over to slf4j in
>
32 matches
Mail list logo
