[
https://issues.apache.org/jira/browse/YARN-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611973#comment-16611973
]
Hudson commented on YARN-7871:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #149
[
https://issues.apache.org/jira/browse/YARN-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394711#comment-16394711
]
Naganarasimha G R commented on YARN-7871:
-
Thanks for the contribution [~cheersyang
[
https://issues.apache.org/jira/browse/YARN-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392401#comment-16392401
]
Weiwei Yang commented on YARN-7871:
---
The remaining 1 checkstyle issue is not introduced b
[
https://issues.apache.org/jira/browse/YARN-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392387#comment-16392387
]
genericqa commented on YARN-7871:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392220#comment-16392220
]
Weiwei Yang commented on YARN-7871:
---
Hi [~Naganarasimha]
Thanks for the comments,
{quot
[
https://issues.apache.org/jira/browse/YARN-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392147#comment-16392147
]
Naganarasimha G R commented on YARN-7871:
-
Thanks [~cheersyang],
IMO Patch is good
[
https://issues.apache.org/jira/browse/YARN-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383256#comment-16383256
]
Weiwei Yang commented on YARN-7871:
---
Hi [~Naganarasimha]
Please take a look at v3 patch
[
https://issues.apache.org/jira/browse/YARN-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383251#comment-16383251
]
genericqa commented on YARN-7871:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16383118#comment-16383118
]
Weiwei Yang commented on YARN-7871:
---
Hi [~Naganarasimha]
bq. having a single api same as
[
https://issues.apache.org/jira/browse/YARN-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16382973#comment-16382973
]
Naganarasimha G R commented on YARN-7871:
-
Thanks for the patch [~cheersyang],
Ju
[
https://issues.apache.org/jira/browse/YARN-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381860#comment-16381860
]
genericqa commented on YARN-7871:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381681#comment-16381681
]
Weiwei Yang commented on YARN-7871:
---
V2 patch uploaded. Diff from v1 is
1. Added followi
[
https://issues.apache.org/jira/browse/YARN-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16372455#comment-16372455
]
Weiwei Yang commented on YARN-7871:
---
Hi [~sunilg]
RMNodeAttributesManager is a place hol
[
https://issues.apache.org/jira/browse/YARN-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16371815#comment-16371815
]
Sunil G commented on YARN-7871:
---
Make sense, with this assumption, is this patch good to go i
[
https://issues.apache.org/jira/browse/YARN-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355282#comment-16355282
]
Weiwei Yang commented on YARN-7871:
---
Hi [~sunilg]
Thanks for reviewing this patch.
bq.
[
https://issues.apache.org/jira/browse/YARN-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355204#comment-16355204
]
Sunil G commented on YARN-7871:
---
Thanks [~cheersyang]
Some comments in general:
# With this
[
https://issues.apache.org/jira/browse/YARN-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353933#comment-16353933
]
genericqa commented on YARN-7871:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/YARN-7871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16353758#comment-16353758
]
Weiwei Yang commented on YARN-7871:
---
Patch attached, some notes to help to review
# Adde
18 matches
Mail list logo