[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467958#comment-16467958 ] Hudson commented on YARN-8207: -- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14142 (See

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467950#comment-16467950 ] Eric Yang commented on YARN-8207: - [~jlowe] Thank you for the persistent reviews to make this better. :)

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467936#comment-16467936 ] Jason Lowe commented on YARN-8207: -- Thanks for updating the patch! +1 for patch v10. Thanks for all your

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467869#comment-16467869 ] genericqa commented on YARN-8207: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467853#comment-16467853 ] Eric Yang commented on YARN-8207: - [~jlowe] Patch 10 is posted. > Docker container launch use popen have

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467837#comment-16467837 ] genericqa commented on YARN-8207: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467783#comment-16467783 ] Jason Lowe commented on YARN-8207: -- {quote}One concern about the shallow copy, struct args buffer

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467762#comment-16467762 ] Eric Yang commented on YARN-8207: - [~jlowe] I see what you mean now, and patch 10 updated accordingly for

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467750#comment-16467750 ] Jason Lowe commented on YARN-8207: -- Additional comment on patch 9: extract_execv_args needs to set

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467727#comment-16467727 ] Eric Yang commented on YARN-8207: - [~jlowe] Patch 9 fixes most nits from your comments except init_args. I

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467725#comment-16467725 ] Jason Lowe commented on YARN-8207: -- init_args would not require the structure to be malloc'd, rather it

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467673#comment-16467673 ] Eric Yang commented on YARN-8207: - [~jlowe] {quote}At a bare minimum there should be a utility method, e.g:

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467488#comment-16467488 ] Jason Lowe commented on YARN-8207: -- {quote}Struct args is still evolving. I think it would be safer to

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466771#comment-16466771 ] genericqa commented on YARN-8207: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466716#comment-16466716 ] Eric Yang commented on YARN-8207: - [~jlowe] Patch 008 fixed the issues discovered except char array copy.

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466683#comment-16466683 ] Eric Yang commented on YARN-8207: - [~jlowe] {quote}Rather than make an expensive deep copy of the

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466649#comment-16466649 ] genericqa commented on YARN-8207: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466578#comment-16466578 ] Jason Lowe commented on YARN-8207: -- Thanks for updating the patch! Nit: Needing to initialize the args

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16466512#comment-16466512 ] Eric Yang commented on YARN-8207: - [~jlowe] Hadoop 3.1.1 release date was proposed for May 7th. This is a

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464894#comment-16464894 ] genericqa commented on YARN-8207: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464891#comment-16464891 ] genericqa commented on YARN-8207: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464873#comment-16464873 ] Eric Yang commented on YARN-8207: - [~jlowe] Patch 006 contains all style fixes from your recommendations.

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464035#comment-16464035 ] Eric Yang commented on YARN-8207: - [~jlowe] I see your concerns now. Thanks for the explanation. I will

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463950#comment-16463950 ] Jason Lowe commented on YARN-8207: -- bq. Args is array of strings. Null terminator is not required for

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463266#comment-16463266 ] Eric Yang commented on YARN-8207: - [~jlowe] Thank you for the review. A couple comments: Args is array of

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16463048#comment-16463048 ] Jason Lowe commented on YARN-8207: -- Thanks for updating the patch! It's looking much better. I didn't

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460387#comment-16460387 ] genericqa commented on YARN-8207: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460340#comment-16460340 ] genericqa commented on YARN-8207: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460297#comment-16460297 ] Eric Yang commented on YARN-8207: - Patch 005 removed bug found by cc. > Docker container launch use popen

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460255#comment-16460255 ] Eric Yang commented on YARN-8207: - [~Jim_Brennan] Thank you for the review. I made the changes according

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460139#comment-16460139 ] Jim Brennan commented on YARN-8207: --- [~eyang], I spent a little time looking at this one today. Didn't

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460098#comment-16460098 ] genericqa commented on YARN-8207: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16460010#comment-16460010 ] Eric Yang commented on YARN-8207: - Patch 003 restored the blocking and wait for child pid behavior, and

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459992#comment-16459992 ] Eric Yang commented on YARN-8207: - {quote}How would the docker run be aborted? The container executor will

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459923#comment-16459923 ] Jason Lowe commented on YARN-8207: -- bq. If docker run is aborted prior to complete download, it does not

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459839#comment-16459839 ] Eric Yang commented on YARN-8207: - {quote}One problem with the foreground change being implemented here is

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459276#comment-16459276 ] genericqa commented on YARN-8207: - | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459207#comment-16459207 ] Jason Lowe commented on YARN-8207: -- Thanks for updating the patch! I will try to take a look at it

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16459178#comment-16459178 ] Eric Yang commented on YARN-8207: - [~jlowe] Patch 002 has converted to use struct instead of char **out,

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457139#comment-16457139 ] Eric Yang commented on YARN-8207: - [~jlowe] Thank you for the review. Good suggestions on coding style

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16457085#comment-16457085 ] Jason Lowe commented on YARN-8207: -- Thanks for the patch! Nit: chosen_container_log_dir should be static.

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16456908#comment-16456908 ] genericqa commented on YARN-8207: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-8207) Docker container launch use popen have risk of shell expansion

[ https://issues.apache.org/jira/browse/YARN-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1645#comment-1645 ] Eric Yang commented on YARN-8207: - Extract logic from YARN-7654 patch 17 for using execvp for launching