[
https://issues.apache.org/jira/browse/YARN-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472399#comment-16472399
]
Szilard Nemeth commented on YARN-8248:
--
Thanks [~haibochen] for your answers.
It makes sense now why
[
https://issues.apache.org/jira/browse/YARN-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472335#comment-16472335
]
Haibo Chen commented on YARN-8248:
--
Thanks [~snemeth] for the clarification.
I think in general it's okay
[
https://issues.apache.org/jira/browse/YARN-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472258#comment-16472258
]
Szilard Nemeth commented on YARN-8248:
--
Thanks [~haibochen] for your comments!
# I added some code in
[
https://issues.apache.org/jira/browse/YARN-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16471309#comment-16471309
]
Haibo Chen commented on YARN-8248:
--
Thanks [~snemeth] for the patch. I have some questions.
1) Why the
[
https://issues.apache.org/jira/browse/YARN-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470210#comment-16470210
]
Gergo Repas commented on YARN-8248:
---
[~snemeth] Thanks for the updated patch, LGTM.
+1 (non-binding)
>
[
https://issues.apache.org/jira/browse/YARN-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16470013#comment-16470013
]
genericqa commented on YARN-8248:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469925#comment-16469925
]
Szilard Nemeth commented on YARN-8248:
--
Fixed the unit test failure and last whitespace style check
[
https://issues.apache.org/jira/browse/YARN-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469549#comment-16469549
]
genericqa commented on YARN-8248:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469291#comment-16469291
]
Szilard Nemeth commented on YARN-8248:
--
Hey [~grepas]!
Both are valid points, I was thinking about
[
https://issues.apache.org/jira/browse/YARN-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16469175#comment-16469175
]
genericqa commented on YARN-8248:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468961#comment-16468961
]
Gergo Repas commented on YARN-8248:
---
[~snemeth] Thanks for the new patch! I can see you introduced
[
https://issues.apache.org/jira/browse/YARN-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16468911#comment-16468911
]
Szilard Nemeth commented on YARN-8248:
--
Hi [~grepas]!
Thanks for your comments.
It is a very good
[
https://issues.apache.org/jira/browse/YARN-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16467091#comment-16467091
]
Gergo Repas commented on YARN-8248:
---
[~snemeth] Thanks for working on this. In the Resources class the
[
https://issues.apache.org/jira/browse/YARN-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465305#comment-16465305
]
genericqa commented on YARN-8248:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8248?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16465264#comment-16465264
]
genericqa commented on YARN-8248:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
15 matches
Mail list logo