[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619730#comment-16619730
]
Hudson commented on YARN-8648:
--
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14997 (See
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619670#comment-16619670
]
Jason Lowe commented on YARN-8648:
--
Thanks, [~billie.rinaldi]! Looks like this is good to go then.
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16619655#comment-16619655
]
Billie Rinaldi commented on YARN-8648:
--
Thanks for checking in, [~Jim_Brennan] and [~jlowe]. I don't
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614019#comment-16614019
]
Jason Lowe commented on YARN-8648:
--
Thanks for updating the patch! +1 lgtm. Waiting to hear back from
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613834#comment-16613834
]
Hadoop QA commented on YARN-8648:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613729#comment-16613729
]
Jim Brennan commented on YARN-8648:
---
[~jlowe] thanks for the review. I've made the change you
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612788#comment-16612788
]
Jason Lowe commented on YARN-8648:
--
Thanks for updating the patch!
It seems a bit awkward that
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612632#comment-16612632
]
Hadoop QA commented on YARN-8648:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612556#comment-16612556
]
Jim Brennan commented on YARN-8648:
---
Thanks [~jlowe] for the review! I have addressed all of this
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609735#comment-16609735
]
Jason Lowe commented on YARN-8648:
--
Thanks for updating the patch!
Should DockerRmCommand take the
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16609206#comment-16609206
]
Jim Brennan commented on YARN-8648:
---
This is ready for review.
> Container cgroups are leaked when
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608225#comment-16608225
]
Hadoop QA commented on YARN-8648:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16608212#comment-16608212
]
Jim Brennan commented on YARN-8648:
---
I have uploaded a patch that adds the cgroup cleanup to the
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603703#comment-16603703
]
Hadoop QA commented on YARN-8648:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603606#comment-16603606
]
Jim Brennan commented on YARN-8648:
---
Put up another patch to fix the checkstyle issue.
> Container
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603269#comment-16603269
]
Hadoop QA commented on YARN-8648:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603202#comment-16603202
]
Jim Brennan commented on YARN-8648:
---
I've uploaded a patch that addresses most of issues raised by
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599235#comment-16599235
]
Jim Brennan commented on YARN-8648:
---
{quote}
I explicitly check that the directory exists before calling
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599213#comment-16599213
]
Jim Brennan commented on YARN-8648:
---
[~jlowe] thanks for the review!
{quote}Why was the postComplete
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596699#comment-16596699
]
Jason Lowe commented on YARN-8648:
--
Thanks for the patch!
Why was the postComplete call moved in
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596345#comment-16596345
]
Jim Brennan commented on YARN-8648:
---
Looks like this is ready for review.
> Container cgroups are
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595740#comment-16595740
]
genericqa commented on YARN-8648:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16587681#comment-16587681
]
Eric Badger commented on YARN-8648:
---
IMO I like the idea of actually dealing with this problem via
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586076#comment-16586076
]
Eric Yang commented on YARN-8648:
-
[~Jim_Brennan] {quote}
I think this is mitigated if we use the "cgroup"
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16586060#comment-16586060
]
Jim Brennan commented on YARN-8648:
---
Thanks [~eyang]! My main concern about the minimal fix is the
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584600#comment-16584600
]
Eric Yang commented on YARN-8648:
-
I am in favor of minimal fix at this time. Let docker be docker seems
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16584479#comment-16584479
]
Jim Brennan commented on YARN-8648:
---
I have been experimenting with the following incomplete approach:
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580234#comment-16580234
]
Jim Brennan commented on YARN-8648:
---
{quote}I am wondering if this approach would break the docker
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580149#comment-16580149
]
Billie Rinaldi commented on YARN-8648:
--
I am wondering if this approach would break the docker
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580081#comment-16580081
]
Jason Lowe commented on YARN-8648:
--
bq. Is it worth breaking cgroups parameters temporarily for docker to
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580067#comment-16580067
]
Jim Brennan commented on YARN-8648:
---
[~jlowe] thanks for the comment.
{quote}We should consider breaking
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16580025#comment-16580025
]
Jason Lowe commented on YARN-8648:
--
+1 for the proposal to fix the cgroup leak by having docker place its
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576916#comment-16576916
]
Jim Brennan commented on YARN-8648:
---
One proposal to fix the leaking cgroups is to have docker put its
[
https://issues.apache.org/jira/browse/YARN-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16576855#comment-16576855
]
Jim Brennan commented on YARN-8648:
---
Another problem we have seen is that container-executor still has
34 matches
Mail list logo