[jira] [Commented] (YARN-9831) NMTokenSecretManagerInRM#createNMToken blocks ApplicationMasterService allocate flow

2020-04-15 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/YARN-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084186#comment-17084186 ] Bilwa S T commented on YARN-9831: - Hi [~surendrasingh] could you please help to review? >

[jira] [Commented] (YARN-9831) NMTokenSecretManagerInRM#createNMToken blocks ApplicationMasterService allocate flow

2020-04-11 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/YARN-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17081250#comment-17081250 ] Bilwa S T commented on YARN-9831: - Hi [~maniraj...@gmail.com] As nodeSet is ConcurrentHashSet there wont

[jira] [Commented] (YARN-9831) NMTokenSecretManagerInRM#createNMToken blocks ApplicationMasterService allocate flow

2020-03-01 Thread Manikandan R (Jira)
[ https://issues.apache.org/jira/browse/YARN-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17048639#comment-17048639 ] Manikandan R commented on YARN-9831: In latest patch, I think

[jira] [Commented] (YARN-9831) NMTokenSecretManagerInRM#createNMToken blocks ApplicationMasterService allocate flow

2020-02-28 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/YARN-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047515#comment-17047515 ] Bilwa S T commented on YARN-9831: - Hi [~maniraj...@gmail.com]  removeNodeKey is called when NM is

[jira] [Commented] (YARN-9831) NMTokenSecretManagerInRM#createNMToken blocks ApplicationMasterService allocate flow

2020-02-27 Thread Manikandan R (Jira)
[ https://issues.apache.org/jira/browse/YARN-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046840#comment-17046840 ] Manikandan R commented on YARN-9831: [~BilwaST] Thanks for the patch. Had a quick glance. Locks has

[jira] [Commented] (YARN-9831) NMTokenSecretManagerInRM#createNMToken blocks ApplicationMasterService allocate flow

2020-02-27 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/YARN-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046721#comment-17046721 ] Bilwa S T commented on YARN-9831: - Thanks [~ayushtkn] for reviewing. CheckStyle issues are unavoidable. 

[jira] [Commented] (YARN-9831) NMTokenSecretManagerInRM#createNMToken blocks ApplicationMasterService allocate flow

2020-02-27 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046634#comment-17046634 ] Hadoop QA commented on YARN-9831: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9831) NMTokenSecretManagerInRM#createNMToken blocks ApplicationMasterService allocate flow

2020-02-27 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/YARN-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046489#comment-17046489 ] Ayush Saxena commented on YARN-9831: Thanx [~BilwaST] for the patch. On a quick look. Looks good

[jira] [Commented] (YARN-9831) NMTokenSecretManagerInRM#createNMToken blocks ApplicationMasterService allocate flow

2020-02-17 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/YARN-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17038815#comment-17038815 ] Bilwa S T commented on YARN-9831: - [~bibinchundatt] could u please check patch >

[jira] [Commented] (YARN-9831) NMTokenSecretManagerInRM#createNMToken blocks ApplicationMasterService allocate flow

2020-01-31 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/YARN-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027472#comment-17027472 ] Hadoop QA commented on YARN-9831: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (YARN-9831) NMTokenSecretManagerInRM#createNMToken blocks ApplicationMasterService allocate flow

2020-01-31 Thread Bilwa S T (Jira)
[ https://issues.apache.org/jira/browse/YARN-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17027374#comment-17027374 ] Bilwa S T commented on YARN-9831: - Thank you [~maniraj...@gmail.com] for your patch.  I have handled it in

[jira] [Commented] (YARN-9831) NMTokenSecretManagerInRM#createNMToken blocks ApplicationMasterService allocate flow

2020-01-18 Thread Manikandan R (Jira)
[ https://issues.apache.org/jira/browse/YARN-9831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17018585#comment-17018585 ] Manikandan R commented on YARN-9831: [~BilwaST] Spent sometime on this Jira earlier. Attaching patch